On Wed, 1 Jun 2022 13:52:46 GMT, Adam Sotona wrote:
> LauncherCommon.gmk is unfortunately defining JAVA_ARGS with `-J-ms8m` option
> for all JDK launchers, including java launcher.
> JAVA_ARGS should not be defined for java launcher (in contrast to the other
> JDK launchers), and
LauncherCommon.gmk is unfortunately defining JAVA_ARGS with `-J-ms8m` option
for all JDK launchers, including java launcher.
JAVA_ARGS should not be defined for java launcher (in contrast to the other
JDK launchers), and the command line option `-J-ms8m` is obsolete for java
launcher.
Proposed
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request incrementally with two additional
commits since the last revision:
- re-enabled lossy-conversion javac warnings in JDK Build Too
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 12 commits:
- Merge branch 'openjdk:maste
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
8244681: Add a warning for possibly lossy conversion
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 10 commits:
- Merge branch 'op
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains ten commits:
- lossy conversions addressed in jav
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
enabled lossy-conversions warnings for jdk.jfr and jdk.manageme
On Wed, 11 May 2022 13:31:16 GMT, Roger Riggs wrote:
>> Thanks for quick reaction.
>> I'll keep my eyes on this race of patches and update this pull request
>> accordingly or create a new PR.
>
> I put out a PR for java.base, but thought I'd wait until the javac fixe were
> pushed before integr
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge
On Wed, 11 May 2022 13:10:10 GMT, Magnus Ihse Bursie wrote:
>> I agree, but if it doesn't happen, I can follow up with a separate PR where
>> I remove the disablement.
>
> That's good to know. I think the tricky part is mostly about keeping track of
> all these disabled warnings, so they are no
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
8244681: Add a warning for possibly lossy conversion in
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
8244681: Add a warning for possibly lossy conversion in compound
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the rig
Please review this patch adding new lint option, **lossy-conversions**, to
javac to warn about type casts in compound assignments with possible lossy
conversions.
The new lint warning is shown if the type of the right-hand operand of a
compound assignment is not assignment compatible with the t
make/jdk/src/classes/build/tools/depend/Depend.java method toString(byte[])
constructs hex string out of the given byte array.
Actual implementation is using custom conversion code, which does not pad byte
values <16 with leading zero.
Resulting hex string is invalid and for example sequence of b
16 matches
Mail list logo
