Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-16 Thread Alejandro E Murillo
On 12/16/2015 5:40 PM, David Holmes wrote: On 17/12/2015 7:35 AM, Erik Joelsson wrote: One more thing, where should this fix be pushed? Do you need it urgently in hs-rt? It is urgently needed in both the hs-rt and hs-comp repos as it affects nightly testing and JPRT. If Alejandro agrees I

Fwd: [verona.stage] RFR 8139986: Store debug level in java.vm.debug and conditionally print in "java -version"

2015-11-03 Thread Alejandro E Murillo
ue, 03 Nov 2015 10:45:31 -0700 From: Alejandro E Murillo <alejandro.muri...@oracle.com> Organization: Oracle Corporation To: hotspot-dev <hotspot-...@openjdk.java.net>, core-libs-dev Libs <core-libs-...@openjdk.java.net> CC: verona-...@openjdk.java.net Please revie

[9] RFR 8132947: Add tier2, tier2 and tier1_2 testsets to jprt.properties

2015-08-04 Thread Alejandro E Murillo
Please review the webrev below for this enhancement: 8132947: Add tier2, tier2 and tier1_2 testsets to jprt.properties webrev: http://cr.openjdk.java.net/~amurillo/9/8132947/ bug: https://bugs.openjdk.java.net/browse/JDK-8132947 Thanks -- Alejandro

Re: [9] RFR 8132947: Add tier2, tier2 and tier1_2 testsets to jprt.properties

2015-08-04 Thread Alejandro E Murillo
On 8/4/2015 1:11 AM, David Holmes wrote: Hi Alejandro, On 4/08/2015 4:56 PM, Alejandro E Murillo wrote: Please review the webrev below for this enhancement: 8132947: Add tier2, tier2 and tier1_2 testsets to jprt.properties webrev: http://cr.openjdk.java.net/~amurillo/9/8132947/ bug: https

Re: [9] RFR 8132947: Add tier2, tier2 and tier1_2 testsets to jprt.properties

2015-08-04 Thread Alejandro E Murillo
Holmes wrote: Hi Alejandro, On 4/08/2015 4:56 PM, Alejandro E Murillo wrote: Please review the webrev below for this enhancement: 8132947: Add tier2, tier2 and tier1_2 testsets to jprt.properties webrev: http://cr.openjdk.java.net/~amurillo/9/8132947/ bug: https://bugs.openjdk.java.net/browse

Re: [8u66] RFR 8079410: Hotspot version to share the same update and build version from JDK

2015-07-21 Thread Alejandro E Murillo
Thanks Dan. Will check why the patch is empty. Alejandro On 7/21/2015 12:57 PM, Daniel D. Daugherty wrote: On 7/20/15 6:45 PM, Alejandro E Murillo wrote: Please review the following change that allows setting the Hotspot minor version and build number to that of the --with-update-version

Re: [8u66] RFR 8079410: Hotspot version to share the same update and build version from JDK

2015-07-20 Thread Alejandro E Murillo
On 7/20/2015 7:01 PM, David Holmes wrote: Hi Alejandro, On 21/07/2015 10:45 AM, Alejandro E Murillo wrote: Please review the following change that allows setting the Hotspot minor version and build number to that of the --with-update-version and --with-build-number configure parameters when

Re: [8u66] RFR 8079410: Hotspot version to share the same update and build version from JDK

2015-07-20 Thread Alejandro E Murillo
On 7/20/2015 7:10 PM, David Holmes wrote: Hi Alejandro, On 21/07/2015 10:45 AM, Alejandro E Murillo wrote: Please review the following change that allows setting the Hotspot minor version and build number to that of the --with-update-version and --with-build-number configure parameters when

[8u66] RFR 8079410: Hotspot version to share the same update and build version from JDK

2015-07-20 Thread Alejandro E Murillo
Please review the following change that allows setting the Hotspot minor version and build number to that of the --with-update-version and --with-build-number configure parameters when provided. 8u builds only. webrev: http://javaweb.us.oracle.com/~amurillo/webrevs/8079410/ Background (since

RFR JDK-8130092: Backout Update jprt.properties with property listing tests subtrees

2015-06-29 Thread Alejandro E Murillo
We need to backout this change JDK-8098834: https://bugs.openjdk.java.net/browse/JDK-8098834 as it is impeding the execution of some jprt tests for control jobs and hence the integration of jdk9/hs into jdk9/dev Webrev: http://cr.openjdk.java.net/~amurillo/9/8130092/ CR:

Re: RFR JDK-8130092: Backout Update jprt.properties with property listing tests subtrees

2015-06-29 Thread Alejandro E Murillo
sounds good David Thanks Alejandro On 6/29/2015 6:34 PM, David Holmes wrote: Looks good Alejandro! We'll work with Dmitry to figure out the problem. Thanks, David On 30/06/2015 10:31 AM, Alejandro E Murillo wrote: We need to backout this change JDK-8098834: https://bugs.openjdk.java.net

Re: RFR: JDK-8085822 JEP 223: New Version-String Scheme (initial integration)

2015-06-10 Thread Alejandro E Murillo
On 6/10/2015 6:13 AM, Magnus Ihse Bursie wrote: On 2015-06-10 11:58, David Holmes wrote: Hi Magnus, Generally looks good - a few comments/queries below. In general, I believe most issues you found are valid. :-) However, as I said before in this thread, I'd like to see them resolved in the

Re: RFR: JDK-8073166: Unable to successfully build the merge of jdk9/hs with jdk9/dev

2015-02-16 Thread Alejandro E Murillo
Thanks for quickly fixing this Erik, reran the snapshot and everything built fine Alejandro On 2/16/2015 4:08 AM, Alan Bateman wrote: On 16/02/2015 10:57, Erik Joelsson wrote: Hello, When merging jdk9/dev and jdk9/hs, the following message appears and the build fails: gmake[2]: *** No

Re: build failure in perfMemory_solaris.cpp?

2015-01-23 Thread Alejandro E Murillo
by the timing when this started to happen, I believe this was caused by the CPU changes integrated into jdk9/dev on Wednesday (they didn't come through jdk9/hs). I went to check those changesets and this looks like the prime suspect: Changeset: c656c7540cb1 Author:gthornbr Date:

Re: RFR: JDK-8062521: 9-dev glinux/elinux configure: error: Could not find all X11 headers since 2014-10-28

2014-10-30 Thread Alejandro E Murillo
On 10/30/2014 7:32 AM, Erik Joelsson wrote: On 2014-10-30 13:52, David Holmes wrote: On 30/10/2014 10:42 PM, Erik Joelsson wrote: I think it would fail in JPRT too, I never ran JPRT with JDK-8062159 unfortunately. I assume very few people run jdk9-dev in JPRT with embedded platforms. All

Re: RFR 8030011: Update Hotspot version string output

2014-04-24 Thread Alejandro E Murillo
Thanks Vladimir Alejandro On 4/23/2014 11:53 AM, Vladimir Kozlov wrote: Looks good. Thanks, Vladimir On 4/22/14 7:32 PM, Alejandro E Murillo wrote: On 4/22/2014 6:12 PM, Vladimir Kozlov wrote: On 4/22/14 4:42 PM, Alejandro E Murillo wrote: On 4/21/2014 1:18 PM, Vladimir Kozlov wrote

Re: RFR 8030011: Update Hotspot version string output

2014-04-24 Thread Alejandro E Murillo
On 4/24/2014 2:52 PM, John Coomes wrote: Alejandro E Murillo (alejandro.muri...@oracle.com) wrote: ... I think I incorporated all the changes David, John and you suggested and started some sanity testing; Here's is the latest webrev: http://cr.openjdk.java.net/~amurillo/9/8030011/ Please

Re: RFR 8030011: Update Hotspot version string output

2014-04-22 Thread Alejandro E Murillo
for the feedback! Alejandro Regards, Vladimir On 4/21/14 10:13 AM, Alejandro E Murillo wrote: On 4/18/2014 6:50 PM, John Coomes wrote: Alejandro E Murillo (alejandro.muri...@oracle.com) wrote: Please review this change to make the hotspot related output produced by java -version match

Re: RFR 8030011: Update Hotspot version string output

2014-04-22 Thread Alejandro E Murillo
On 4/22/2014 6:12 PM, Vladimir Kozlov wrote: On 4/22/14 4:42 PM, Alejandro E Murillo wrote: On 4/21/2014 1:18 PM, Vladimir Kozlov wrote: Hi Alejandro, I don't think we need to rename make/hotspot_version file. It is still used to set JVM's version string and not JDK's version. Next

Re: RFR 8030011: Update Hotspot version string output

2014-04-21 Thread Alejandro E Murillo
On 4/18/2014 6:50 PM, John Coomes wrote: Alejandro E Murillo (alejandro.muri...@oracle.com) wrote: Please review this change to make the hotspot related output produced by java -version match the corresponding JDK output: webrev: http://cr.openjdk.java.net/~amurillo/9/8030011/ Bug: https

Re: RFR 8030011: Update Hotspot version string output

2014-04-10 Thread Alejandro E Murillo
to HOTSPOT_RELEASE_VERSION, we just don't get those values by parsing it, so we just pass those values to the vm_version.cpp, since they are already defined in the makefiles. The format of the JDK version is not that fixed. Thanks Alejandro David On 10/04/2014 10:15 AM, Alejandro E Murillo wrote

RFR 8030011: Update Hotspot version string output

2014-04-09 Thread Alejandro E Murillo
Please review this change to make the hotspot related output produced by java -version match the corresponding JDK output: webrev: http://cr.openjdk.java.net/~amurillo/9/8030011/ Bug: https://bugs.openjdk.java.net/browse/JDK-8030011 Note that we initially wanted to obtain more information

Re: How to increment JDK_MINOR_VERSION for JDK 9? -- request for review

2013-12-19 Thread Alejandro E Murillo
Hi David, since the hoptspot version should match the jdk version, I actually plan to remove this file as part of the fix for: https://bugs.openjdk.java.net/browse/JDK-8030011 and set those values appropriately thanks Alejandro On 12/19/2013 12:14 AM, David Holmes wrote: Joe,

Re: How to increment JDK_MINOR_VERSION for JDK 9? -- request for review

2013-12-19 Thread Alejandro E Murillo
On 12/19/2013 6:15 PM, David Holmes wrote: On 20/12/2013 2:22 AM, Alejandro E Murillo wrote: Hi David, since the hoptspot version should match the jdk version, I actually plan to remove this file as part of the fix for: https://bugs.openjdk.java.net/browse/JDK-8030011 and set those values

Re: RFR: 8016780: (xs) README-builds.html misses crucial requirement on bootstrap JDK

2013-06-18 Thread Alejandro E Murillo
On 6/17/2013 6:22 PM, Jonathan Gibbons wrote: On 06/17/2013 05:21 PM, Stuart Marks wrote: On 6/17/13 4:02 PM, Kelly O'Hair wrote: Rule #1 Nobody reads the README Rule #2 When things go wrong, blame the README I of course have no objection to the change, however, I'm not convinced it will