Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-12 Thread Alexey Semenyuk
On Thu, 12 May 2022 20:59:53 GMT, Michael Hall wrote: > However, I don't know how the app is supposed to be started without a > launcher... jpackage supplies an alternative launcher that doesn't have plist. - PR: https://git.openjdk.java.net/jdk/pull/8666

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

2022-05-12 Thread Alexey Semenyuk
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev wrote: >> - It is not possible to support native JDK commands such as "java" inside >> Mac App Store bundles due to embedded info.plist. Workarounds suggested in >> JDK-8286122 does not seems to be visible. >> - With proposed fix we will enf

Re: RFR: 8286429: jpackageapplauncher build fails intermittently in Tier[45]

2022-05-09 Thread Alexey Semenyuk
On Mon, 9 May 2022 23:18:47 GMT, Erik Joelsson wrote: > The way LauncherCommon.gmk is currently written, it's only meant to be > included from "make/module//Launcher.gmk", or at least only from one > single place for each module. This is because the man page generation that > happens in Launch

Integrated: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest

2022-05-05 Thread Alexey Semenyuk
On Thu, 5 May 2022 19:02:51 GMT, Alexey Semenyuk wrote: > Copy missing manifest-related parameters to `SetupJdkExecutable` calls > building app launchers from `SetupBuildLauncher` > function:https://github.com/openjdk/jdk/blob/0c3094c8186b4d53e8bad80e2369fc7b9ae9e201/make/commo

RFR: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest

2022-05-05 Thread Alexey Semenyuk
Copy missing manifest-related parameters to `SetupJdkExecutable` calls building app launchers from `SetupBuildLauncher` function:https://github.com/openjdk/jdk/blob/0c3094c8186b4d53e8bad80e2369fc7b9ae9e201/make/common/modules/LauncherCommon.gmk#L174-L175 - Commit messages: - 828467

Integrated: JDK-8236128: Allow jpackage create installers for services

2022-04-27 Thread Alexey Semenyuk
On Fri, 11 Mar 2022 23:37:06 GMT, Alexey Semenyuk wrote: > Implementation of [JDK-8275062: "Allow jpackage create installers for > services"](https://bugs.openjdk.java.net/browse/JDK-8275062) > CSR This pull request has now been integrated. Changeset: b675c597 Author:A

Re: RFR: JDK-8236128: Allow jpackage create installers for services [v2]

2022-04-14 Thread Alexey Semenyuk
> Implementation of [JDK-8275062: "Allow jpackage create installers for > services"](https://bugs.openjdk.java.net/browse/JDK-8275062) > CSR Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 121

RFR: JDK-8236128: Allow jpackage create installers for services

2022-03-11 Thread Alexey Semenyuk
Implementation of [JDK-8275062: "Allow jpackage create installers for services"](https://bugs.openjdk.java.net/browse/JDK-8275062) CSR - Commit messages: - Whitespace cleanup - Whitespace cleanup - JDK-8236128: Allow jpackage create installers for services - Sync l10n files. Fix

Integrated: 8277429: Conflicting jpackage static library name

2021-11-22 Thread Alexey Semenyuk
On Sat, 20 Nov 2021 03:26:51 GMT, Alexey Semenyuk wrote: > 8277429: Conflicting jpackage static library name This pull request has now been integrated. Changeset: e3911a85 Author: Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/commit/e3911a8532e9b93ba5e65c613bd79864485db

RFR: 8277429: Conflicting jpackage static library name

2021-11-19 Thread Alexey Semenyuk
8277429: Conflicting jpackage static library name - Commit messages: - 8277429: Conflicting jpackage static library name Changes: https://git.openjdk.java.net/jdk/pull/6485/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6485&range=00 Issue: https://bugs.openjdk.java.

Re: RFR: JDK-8264057: [redo] JDK-8248904: Add support to jpackage for the Mac App Store.

2021-03-24 Thread Alexey Semenyuk
On Wed, 24 Mar 2021 11:00:53 GMT, Andy Herrick wrote: > Restoring fix to JDK-8248904: Add support to jpackage for the Mac App Store. Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3172

Integrated: 8261281: Linking jdk.jpackage fails for linux aarch32 builds after 8254702

2021-02-08 Thread Alexey Semenyuk
On Mon, 8 Feb 2021 16:47:49 GMT, Alexey Semenyuk wrote: > Remove accidently added Linux build flags This pull request has now been integrated. Changeset: ad525bcd Author: Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/commit/ad525bcd Stats: 1 line in 1 file changed: 0

RFR: 8261281: Linking jdk.jpackage fails for linux aarch32 builds after 8254702

2021-02-08 Thread Alexey Semenyuk
Remove accidently added Linux build flags - Commit messages: - 8261281: Linking jdk.jpackage fails for linux aarch32 builds after 8254702 Changes: https://git.openjdk.java.net/jdk/pull/2459/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2459&range=00 Issue: https://b

Integrated: 8254702: jpackage app launcher crashes on CentOS

2021-02-05 Thread Alexey Semenyuk
On Fri, 29 Jan 2021 21:33:40 GMT, Alexey Semenyuk wrote: > Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. > App launcher is pure C and doesn't have C++ code. App launcher lib > in

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-05 Thread Alexey Semenyuk
On Mon, 1 Feb 2021 18:35:54 GMT, Alexey Semenyuk wrote: >>> "common" was perfectly enough until this change. Unfortunately we cant just >>> drop new C sources in "common" dir because we don't want them to be >>> comp

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v6]

2021-02-05 Thread Alexey Semenyuk
Linux and launcher code on other > platforms. > - `applaunchercommon`: code shared between launcher and launcher lib on Linux > and launcher code on other platforms. Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: 825

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v5]

2021-02-05 Thread Alexey Semenyuk
Linux and launcher code on other > platforms. > - `applaunchercommon`: code shared between launcher and launcher lib on Linux > and launcher code on other platforms. Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: 825

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v4]

2021-02-05 Thread Alexey Semenyuk
Linux and launcher code on other > platforms. > - `applaunchercommon`: code shared between launcher and launcher lib on Linux > and launcher code on other platforms. Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision: - 82547

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-01 Thread Alexey Semenyuk
On Mon, 1 Feb 2021 18:24:23 GMT, Erik Joelsson wrote: >> "common" was perfectly enough until this change. Unfortunately we cant just >> drop new C sources in "common" dir because we don't want them to be compiled >> with g++. That is why need new common directory (applauncherlibcommon) for C >

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v3]

2021-02-01 Thread Alexey Semenyuk
Linux and launcher code on other > platforms. > - `applaunchercommon`: code shared between launcher and launcher lib on Linux > and launcher code on other platforms. Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: 825

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-01 Thread Alexey Semenyuk
On Mon, 1 Feb 2021 12:19:56 GMT, Magnus Ihse Bursie wrote: >> Alexey Semenyuk has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull reques

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-02-01 Thread Alexey Semenyuk
On Mon, 1 Feb 2021 12:16:09 GMT, Magnus Ihse Bursie wrote: >> Alexey Semenyuk has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull reques

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v2]

2021-01-29 Thread Alexey Semenyuk
Linux and launcher code on other > platforms. > - `applaunchercommon`: code shared between launcher and launcher lib on Linux > and launcher code on other platforms. Alexey Semenyuk has refreshed the contents of this pull request, and previous commits have been removed. The incremen

Re: RFR: 8254702: jpackage app launcher crashes on CentOS

2021-01-29 Thread Alexey Semenyuk
On Fri, 29 Jan 2021 22:00:32 GMT, Phil Race wrote: >> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 >> >> The fix splits Linux app launcher in app launcher and launcher shared lib. >> App launcher is pure C and doesn't have C++ code. App launcher lib >> incorporates bulk of C++ code

RFR: 8254702: jpackage app launcher crashes on CentOS

2021-01-29 Thread Alexey Semenyuk
Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 The fix splits Linux app launcher in app launcher and launcher shared lib. App launcher is pure C and doesn't have C++ code. App launcher lib incorporates bulk of C++ code from app launcher. At startup app launcher loads launcher shared l

Re: RFR: 8254702: jpackage app launcher crashes on CentOS

2021-01-29 Thread Alexey Semenyuk
On Fri, 29 Jan 2021 21:33:40 GMT, Alexey Semenyuk wrote: > Fix for https://bugs.openjdk.java.net/browse/JDK-8254702 > > The fix splits Linux app launcher in app launcher and launcher shared lib. > App launcher is pure C and doesn't have C++ code. App launcher lib > in

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Alexey Semenyuk
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage >

Re: RFR: JDK-8242302 : Refactor jpackage native code

2020-04-23 Thread Alexey Semenyuk
On 2020-04-23 11:38, Alexey Semenyuk wrote: Erik, Please review updated patch with the suggested improvements at [1]. The webrev includes only incremental changes to Lib-jdk.incubator.jpackage.gmk for clarity. [1] http://cr.openjdk.java.net/~asemenyuk/8242302/webrev.01/webrev.01/index.html

Re: RFR: JDK-8242302 : Refactor jpackage native code

2020-04-23 Thread Alexey Semenyuk
$(filter-out -MD, $1) -MT /Erik On 2020-04-15 13:13, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Refactor jpackage native code. - Improve code reuse between different platforms. - Replace custom string classes with the standard std::basic_string. - Merge functionality of li

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2020-03-04 Thread Alexey Semenyuk
all support C++11 for several years already. [1] https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms - Alexey On 3/3/2020 7:29 PM, Kim Barrett wrote: On Mar 3, 2020, at 4:49 PM, Alexey Semenyuk wrote: How about C++11? I have a pending patch for jpackage that depends on C++11

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2020-03-03 Thread Alexey Semenyuk
How about C++11? I have a pending patch for jpackage that depends on C++11 features that I hesitate to pull in jdk15. - Alexey On 3/3/2020 5:22 AM, Volker Simonis wrote: On Tue, Mar 3, 2020 at 10:26 AM Andrew Haley wrote: On 3/2/20 10:46 PM, Volker Simonis wrote: As lead of the 8 and 11 up

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

2019-12-11 Thread Alexey Semenyuk
Yes, I did a test build. - Alexey On 12/11/2019 1:48 PM, Phil Race wrote: Looks OK. I presume you did a test build in our build system ? -phil On 12/11/19 10:46 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch

RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

2019-12-11 Thread Alexey Semenyuk
Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch contributed by Arthur Eubanks (aeuba...@google.com). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8235728 [2] http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-05-03 Thread Alexey Semenyuk
Andy, I've created the following CRs to track the findings: https://bugs.openjdk.java.net/browse/JDK-8223325 https://bugs.openjdk.java.net/browse/JDK-8223323 - Alexey On 5/2/2019 5:08 PM, Andy Herrick wrote: Alexey: Please file Bugs for these two issues. /Andy On 5/2/2019 1:49 PM, A

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-05-03 Thread Alexey Semenyuk
g the heat.exe tool on the application image. Scott On May 2, 2019, at 5:08 PM, Andy Herrick wrote: Alexey: Please file Bugs for these two issues. /Andy On 5/2/2019 1:49 PM, Alexey Semenyuk wrote: Some findings: http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/raw_files/new/make/lau

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-05-02 Thread Alexey Semenyuk
Some findings: http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/raw_files/new/make/launcher/Launcher-jdk.jpackage.gmk: I think definitions of BUILD_JPACKAGE_APPLAUNCHEREXE and BUILD_JPACKAGE_APPLAUNCHERWEXE targets should be moved to http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/

Re: [10] Request for review and approval: JDK-8177770: Need more precise control on build system logging

2017-03-30 Thread alexey semenyuk
ice to not break things first. Some contributors continually pull OpenJDK changes and run them through their own build and test systems. Thanks, David /Magnus Thanks, David On 30/03/2017 2:21 AM, alexey semenyuk wrote: Please review and approve enhancement for JDK10. Bug: https://bugs.

[10] Request for review and approval: JDK-8177770: Need more precise control on build system logging

2017-03-29 Thread alexey semenyuk
Please review and approve enhancement for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-810 Webrev: http://cr.openjdk.java.net/~asemenyuk/810/webrev.00/ Thanks, Alexey

Re: RFR: JDK-8160490: "installer-only" top level target is broken

2016-06-30 Thread alexey semenyuk
Erik, Looks good. Thanks, Alexey On 29.06.2016 16:01, Erik Joelsson wrote: Hello, A while ago, in JDK-8155689, a workaround was put in place because a temporary broken Jib configuration file. The Jib configuration has since been fixed and the workaround can now safely be removed. Bug: htt