Re: RFR: 8284853: Fix varios 'expected' typo

On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote: > Found various typos of expected: `exepected`, `exept`, `epectedly`, > `expeced`, `Unexpeted`, etc. Expect the Unexpeted. - Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8231

Re: [OpenJDK 2D-Dev] RFR: 8242325: Remove VIS version of medialib

+1 Brian > On Apr 8, 2020, at 2:15 PM, Philip Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8242325 > > Webrev : http://cr.openjdk.java.net/~prr/8242325/ > > > With the impending rem

Re: RFR: [8u] Build failed on Ubuntu 18.04 due to deprecated-declarations warnings

jdk8u-dev will build with this conf bash configure --with-extra-cflags=-Wno-error at least on Ubuntu 18.04. > On Mar 19, 2019, at 8:09 AM, Martin Buchholz wrote: > > Probably it's because glibc deprecated readdir, and we don't have > --disable-warnings-as-errors by default? > > (I think warni

Re: RFR 8214794 : java.specification.version should be only the major version number

Hi Roger, Looks fine. Brian > On Dec 4, 2018, at 8:23 AM, Roger Riggs wrote: > > Including build-dev for the change to GensrcMisc.gmk. > > thx. > > On 12/04/2018 11:16 AM, Roger Riggs wrote: >> Please review correctly setting the java.specification.version property >> with only the major ver

Re: [OpenJDK 2D-Dev] RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

On Aug 31, 2018, at 2:28 AM, Magnus Ihse Bursie wrote: >> Magnus, Philip, Brian, Goetz, can we have a vote? => "Fix" or >> "DisableWarnings" ? > > Note that this decision can be different for the two libraries. I'd argue > that the maintainer of each library decides. And if so, it seems to

Re: RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

l: 245913, external: 01962 815913 > internet email: andrew_m_leon...@uk.ibm.com > > > > > From:Magnus Ihse Bursie > To:Andrew Leonard , Brian Burkhalter > > Cc:core-libs-...@openjdk.java.net, build-dev > > Date:30/08/2018 13:49

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

On Mar 1, 2018, at 11:52 PM, Alan Bateman wrote: > I assume the copyright range should be 2003, 2018 (to match Launcher.java) as > this is not a new file in 2018. Will update before pushing. > So I think you good to go and it's great to have the .so files removed from > the repos. +1 Thanks

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

D’oh! Thanks, Brian On Mar 1, 2018, at 2:57 PM, Erik Joelsson wrote: > Note that you also need to update the declarations in the makefile.

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

I think shorter is better: http://cr.openjdk.java.net/~bpb/8198834/webrev.01/ I’ll hold off pushing until Alan comments again. Thanks, Brian On Mar 1, 2018, at 2:50 PM, Erik Joelsson wrote: > Either works for me. Thanks! > > /Erik > > > On 2018-03-01 14:09, Brian Burkh

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

HI Erik, You caught me just shy of checking this in. :-) I can change it to something else like “libInheritedChannelLauncher” or “libInheritedChannel.” Thanks, Brian On Mar 1, 2018, at 2:07 PM, Erik Joelsson wrote: > These native test libs all need to live in the same global namespace, > b

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

On Mar 1, 2018, at 12:17 PM, Alan Bateman wrote: >> The C source file beginning with “lib” is a requirement of the jtreg native >> test build. > Okay, we might have to live with it for now but hopefully it can be fixed to > be able to use sensible source file names in the future. Webrev update

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

On Mar 1, 2018, at 11:52 AM, Alan Bateman wrote: > The rename of Launcher.c looks a bit strange, the original name looks better > to me. The C source file beginning with “lib” is a requirement of the jtreg native test build. > I see it doesn't have a copyright header so we should fix that. Fo

Re: [9] RFR of 8140630: java/nio/Buffer/Basic.java crashes vm on linux-x64 using latest devkit to build

Looks reasonable so far. Thanks, Brian On Nov 6, 2015, at 3:49 PM, Mikael Vidstedt wrote: > http://cr.openjdk.java.net/~mikael/webrevs/8141491/webrev.01/webrev/ > > Feedback appreciated, but I'll get back with an official RFR when I have done > some benchmarking.

Re: [9] RFR of 8140630: java/nio/Buffer/Basic.java crashes vm on linux-x64 using latest devkit to build

y benchmarking to see what the effects are, nor have I > tried it on any platform except linux-x86_64 so far, but at least it passes > the unit tests there. > > Feedback appreciated. > > Cheers, > Mikael > > On 2015-11-05 10:46, Brian Burkhalter wrote: >> The follo

Re: [9] RFR of 8140630: java/nio/Buffer/Basic.java crashes vm on linux-x64 using latest devkit to build

The follow-on issue which was filed to track the underlying issue is this: https://bugs.openjdk.java.net/browse/JDK-8141491 As can be seen it is an alignment problem. Brian On Nov 5, 2015, at 4:57 AM, Alan Bateman wrote: > On 05/11/2015 04:19, Martin Buchholz wrote: >> Alright, it's a much be

Re: [9] RFR of 8140630: java/nio/Buffer/Basic.java crashes vm on linux-x64 using latest devkit to build

The problem is due to a non-alignment issue as you previously suggested. Suppressing it via the build configuration change is a procedural matter: work to find the root problem and a real solution continues nonetheless. On Nov 4, 2015, at 7:46 PM, Martin Buchholz wrote: > OK, I looked a little

Re: [9] RFR of 8140630: java/nio/Buffer/Basic.java crashes vm on linux-x64 using latest devkit to build

On Nov 4, 2015, at 2:12 PM, Martin Buchholz wrote: > At Google, we've also noticed crashes in Bits.c with recent gcc. > Adding nio-dev, since this is not really a build problem. Agreed. The posted patch is not intended to be a final solution. > It appears that Bits.c is resorting to undefined b

[9] RFR of 8140630: java/nio/Buffer/Basic.java crashes vm on linux-x64 using latest devkit to build

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8140630 Patch: Included below The change is to compile src/java.base/share/native/libjava/Bits.c only into libjava.so with normal optimization level (-O2) instead of high optimization level (-O3). The other obj

Re: OS X configure ignores --with-tools-dir

Attempting to build JDK 8 on Mavericks I found the same problem: $ sh configure --with-debug-level=fastdebug --with-tools-dir=/Applications/Xcode4.app/Contents/Developer/usr/bin […] checking for gcc... /Applications/Xcode4.app/Contents/Developer/usr/bin/gcc configure: Resolving CC (as /Applicati