On Mon, 6 Jun 2022 15:56:47 GMT, Tim Prinzing wrote:
> The idea was to reduce duplicate code. Changing to use objects to encapsulate
> the up calls got rid of a lot of repeated code and made things simpler and
> clearer. Objects are created with the class, method, and signature strings
> and
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote:
> One can select a testcase by ID when running a jtreg test case directly from
> jtreg (using the testcase.java#testID syntax). However, this has not been
> possible to do when launching jtreg indirectly from make.
>
> This fix attempts to
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Hi Tim,
Sorry but I have to ask why this test was created as a C++ program instead of
keeping it as a C program likes it predecessors? No need for C++ libs or
special
On Wed, 1 Jun 2022 03:18:44 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
The new assertion in src/hotspot/share/utilities/globalDefinitions.hpp
inline const char* type2name(BasicType t) {
assert((uint)t < T_CONFLICT + 1, "invalid type");
return type2name_tab[t];
}
is failing with test
compiler/jvmci/errors/TestInvalidDebugInfo.java
I have filed:
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
Marked as reviewed by dholmes (Reviewer).
On Thu, 14 Apr 2022 05:09:14 GMT, Joe Darcy wrote:
> Time to start getting ready for JDK 20...
One comment below.
I ignored the sym files.
Everything else appears okay.
Thanks.
src/java.base/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java line
312:
> 310: int V18 = 0 << 16 |
On Mon, 23 May 2022 17:25:30 GMT, Magnus Ihse Bursie wrote:
> We have a bunch of configure arguments that has been deprecated for multiple
> releases. These should be removed. In effect, this will raise an error
> instead of a warning if these argument is included on the command line for
>
On Sun, 15 May 2022 20:50:25 GMT, Kim Barrett wrote:
> Please review this cleanup of deprecation warning suppression when building
> for Windows.
>
> This change consists of several parts.
>
> (1) Remove the global deprecation warning suppression when building HotSpot
> for Windows.
>
> (2)
On 23/05/2022 8:22 am, Philip Race wrote:
Why is it that the vast majority of PRs are recording spurious looking
failures of github pre-submit tests ?
https://github.com/openjdk/jdk/pulls?q=type%3Apr+is%3Aopen+label%3Arfr
There seems to be so much noise in these that I pay no attention to
On Sun, 15 May 2022 20:50:25 GMT, Kim Barrett wrote:
> Please review this cleanup of deprecation warning suppression when building
> for Windows.
>
> This change consists of several parts.
>
> (1) Remove the global deprecation warning suppression when building HotSpot
> for Windows.
>
> (2)
On Mon, 16 May 2022 10:17:42 GMT, Markus Grönlund wrote:
> Greetings,
>
> [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to
> address artefact tagging for Compiler threads, letting threads run
> _thread_in_native to avoid the transition. Unfortunately, that attempt
On Mon, 16 May 2022 07:54:09 GMT, Jaikiran Pai wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright year
>
> Thank you Daniel and Lance for the reviews.
>
> Would anyone from the build team like to provide
On Wed, 11 May 2022 16:00:32 GMT, Maxim Kartashev
wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust API level to Windows 8 for security.cpp and do some cleanup
>
> This change seem to have made this
On Mon, 9 May 2022 23:18:47 GMT, Erik Joelsson wrote:
> The way LauncherCommon.gmk is currently written, it's only meant to be
> included from "make/module//Launcher.gmk", or at least only from one
> single place for each module. This is because the man page generation that
> happens in
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>>
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>>
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>>
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
>
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
>
On Mon, 11 Apr 2022 21:03:22 GMT, Magnus Ihse Bursie wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8284661: Reproducible assembly builds without relative linking
>>
>> Signed-off-by: Andrew Leonard
>
>
On Mon, 11 Apr 2022 12:04:41 GMT, Maurizio Cimadamore
wrote:
>> src/hotspot/share/prims/scopedMemoryAccess.cpp line 141:
>>
>>> 139:
>>> 140: /*
>>> 141: * This function performs a thread-local handshake against all threads
>>> running at the time
>>
>> Nit: thread-local??
>
> I was
On Mon, 4 Apr 2022 14:57:30 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On 29/03/2022 7:20 pm, Magnus Ihse Bursie wrote:
On 2022-03-29 03:42, Jaikiran Pai wrote:
Hello Magnus,
On 28/03/22 5:21 pm, Magnus Ihse Bursie wrote:
On 2022-03-28 09:03, David Holmes wrote:
On 28/03/2022 4:56 pm, Alan Bateman wrote:
On 28/03/2022 07:46, David Holmes wrote:
Hi Jai
On Mon, 28 Mar 2022 12:58:20 GMT, Thomas Stuefe wrote:
>> Christian Hagedorn has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 54 commits:
>>
>> - Updating some comments
>> - Cleanup loading dwarf file and add summary
>> -
On 28/03/2022 4:56 pm, Alan Bateman wrote:
On 28/03/2022 07:46, David Holmes wrote:
Hi Jai,
It isn't obvious to me that the bundled sources are actually intended
to build on macOS. There's no include of unistd.h to get the lseek
definition.
I think the context here is that Jai is chasing
Hi Jai,
It isn't obvious to me that the bundled sources are actually intended to
build on macOS. There's no include of unistd.h to get the lseek definition.
Cheers,
David
On 28/03/2022 2:50 pm, Jaikiran Pai wrote:
I'm using the following set of commands to build the JDK on my Mac M1
12.2.1
On Tue, 22 Mar 2022 12:08:01 GMT, Fei Yang wrote:
>> make/autoconf/libraries.m4 line 152:
>>
>>> 150: fi
>>> 151:
>>> 152: # Programs which use C11 or C++11 atomics, like #include ,
>>
>> Use of C++ atomics is not allowed in hotspot code base. See the style guide:
>>
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched
On Tue, 22 Mar 2022 03:31:16 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched
On 11/03/2022 4:50 pm, Thomas Stuefe wrote:
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
Thanks for pointing this out. I ran more tests and found that on certain
platforms, there are other structures that have problems with uninitialized
gaps. I ended up changing `os::malloc
On 11/03/2022 4:40 pm, Ioi Lam wrote:
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
I ended up changing `os::malloc()` to zero the buffer when running with
-Xshare:dump. Hopefully one extra check of `if (DumpSharedSpaces)` doesn't
matter too much for regular VM executions because
I can't find this comment in the PR so replying via email ...
On 11/03/2022 9:24 am, Ioi Lam wrote:
On Wed, 9 Mar 2022 07:47:19 GMT, Thomas Stuefe wrote:
Ioi Lam has updated the pull request incrementally with one additional commit
since the last revision:
Fixed zero build
On Thu, 10 Mar 2022 19:41:03 GMT, Ioi Lam wrote:
>> I think he already did. I'm quoting:
>>
>>> However, the CDS archive also contains a heap dump, which includes Java
>>> HashMaps. If I allow those 3 Java threads to start, some HashMaps in the
>>> module graph will have unstable ordering. I
On Thu, 10 Mar 2022 12:50:58 GMT, Magnus Ihse Bursie wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> Well, previously we'd get different dumps on different runs. If that was an
> issue, surely it
On Thu, 10 Mar 2022 12:11:06 GMT, Magnus Ihse Bursie wrote:
>> The "heap dump" aspect of this is not something I'm familiar with, but if
>> the threads don't affect the list of classes dumped, they surely must affect
>> what is in the heap dump otherwise their execution would not be an issue.
On Wed, 9 Mar 2022 05:10:44 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On Wed, 9 Mar 2022 05:10:44 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On Mon, 7 Mar 2022 08:07:30 GMT, Julian Waters wrote:
>> Some of the --without options are not properly handled and will crash when
>> processed (For example, --without-version-string), in other cases the
>> --without-* option will actually silently produce incorrect results instead
>> of
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
I eyeballed the diff file and all seems okay.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR:
On 3/03/2022 11:29 pm, Julian Waters wrote:
Windows seems to commonly confuse object file names that are created during
the build process
I don't understand what you mean by that, please elaborate.
Thanks,
David
, despite .obj being the normal file format for object
files on it (Weirdly
On Thu, 3 Mar 2022 16:48:40 GMT, Julian Waters wrote:
>> Currently the only other option for manually configuring the build platform
>> while cross compiling are devkits, which don't work on certain systems and
>> are also more focused on differentiating the build and target compilers
>>
On Thu, 24 Feb 2022 10:52:00 GMT, Alan Hayward wrote:
>> Alan Hayward has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 34 commits:
>>
>> - Merge master
>> - Merge master
>> - Merge master
>> - Error on
On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński wrote:
> Please review this PR that enables
> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170)
> compiler flag, which makes assigning a string literal
Hi Simmias,
On 14/02/2022 1:24 pm, 殷玉婷 wrote:
Hi,
When I ran
make images in my local computer to compile the openjdk9u by guideline
<>, I encountered the following problems:
9u is not expected to be built by recent Xcode, it was a much older
release (not sure if anyone is actually updating
On Wed, 2 Feb 2022 10:18:38 GMT, Andrew Haley wrote:
>> And this change will keep ROP protection enabled if we fall into the "this
>> VM was built without ROP-protection support.". In that case we'll be
>> protecting generated code, but the VM itself won't be protected. This will
>> run
On 2/02/2022 3:53 pm, Abigail G wrote:
On Wed, 2022-02-02 at 15:48 +1000, David Holmes wrote:
Hi Abigail,
On 2/02/2022 3:01 pm, Abigail G wrote:
Hello,
I'm working on packaging several openjdk versions for Void Linux.
When I build jdk13 with jdk12 as the boot jdk, I get a segfault
very
soon
Hi Abigail,
On 2/02/2022 3:01 pm, Abigail G wrote:
Hello,
I'm working on packaging several openjdk versions for Void Linux.
When I build jdk13 with jdk12 as the boot jdk, I get a segfault very
soon into the build. I am not a java developer, so I'm not quite sure
what to make of the log,
On Tue, 1 Feb 2022 11:05:46 GMT, Alan Hayward wrote:
>> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 429:
>>
>>> 427: #else
>>> 428: warning("UseROPProtection specified, but not supported in the
>>> VM.");
>>> 429: #endif
>>
>> If we issue these warnings should `_rop_protection`
On Mon, 24 Jan 2022 15:56:06 GMT, Alan Hayward wrote:
>> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One
>> of its uses is to protect against ROP based attacks. This is done by
>> signing the Link Register whenever it is stored on the stack, and
>> authenticating the value
Hi Christian,
Sorry for the delay in coming back to this, I wanted to see what other
feedback arose.
On 25/01/2022 7:43 pm, Christian Hagedorn wrote:
Hi David
This will be really useful - thank you. :)
I'm glad to hear that! :-) Thanks for your overall comments!
All build file changes
On Sun, 30 Jan 2022 00:39:20 GMT, Kim Barrett wrote:
> Please review this change to the HotSpot Style Guide change process.
>
> The current process involves gathering consensus among the HotSpot Group
> Members. That's fine for changes of substance. But it seems overly weighty
> for editorial
On 27/01/2022 9:01 pm, Goetz Lindenmaier wrote:
On Mon, 24 Jan 2022 22:23:33 GMT, Tyler Steele wrote:
Just in time for the holidays I have completed an implementation of the JFR
functionality for AIX. As a side note, this is my first submission to OpenJDK
### Implementation notes and
On 27/01/2022 10:19 am, Tyler Steele wrote:
On Tue, 25 Jan 2022 06:10:19 GMT, Thomas Stuefe wrote:
Tyler Steele has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
- Merge branch 'master' into JDK-8203290
-
On 25/01/2022 7:14 pm, Thomas Stuefe wrote:
src/hotspot/os/aix/libperfstat_aix.cpp line 2:
1: /*
2: * Copyright (c) 2022, 2022, Oracle and/or its affiliates. All rights
reserved.
Is there a reason for this copyright addition?
Just FYI that is an invalid copyright line for Oracle. There
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote:
> Please review,
> When jlink with --compress=2, zip is used to compress the files while doing
> copy. The user case failed to load zip.dll, since zip.dll is not set in PATH.
> This failure is after we get NULL from
On Tue, 18 Jan 2022 23:09:12 GMT, Liam Miller-Cushon wrote:
> Update links to the chromium style guide in the HotSpot Style Guide.
Looks good. Thanks for noticing the problem and fixing it.
David
-
Marked as reviewed by dholmes (Reviewer).
PR:
ements
Microsoft Visual Studio
I cloned the Git Repo for jdk8u, master branch.
Ken
On Sunday, January 16, 2022, 10:35:53 PM CST, David Holmes
wrote:
Hi Ken,
On 13/01/2022 9:52 am, Ken Taylor wrote:
> I am trying to build JDK 8 from the jdk8u repo, master branch.Project
was forked a
On 15/01/2022 2:13 am, Tyler Steele wrote:
To follow up on an item mentioned above so that it is documented here: I
reviewed the functionality from `src/hotspot/os/aix/libperfstat_aix` and found
it didn't fit well with the needs of this pr. If it were extended in the future
to include the
Hi Ken,
On 13/01/2022 9:52 am, Ken Taylor wrote:
I am trying to build JDK 8 from the jdk8u repo, master branch.Project was
forked and cloned into a Windows 10 VM.Building in Cygwin.
It appears that the change to support VS 2019 has not been checked in.
On 7/01/2022 5:21 am, tim.b...@oracle.com wrote:
Forwarded Message
Subject: RE: Need OpenJDK to be used on PowerPC for our products.
Date: Thu, 6 Jan 2022 19:16:10 +
From: Dipendu Ghosh
To: mailman-owner
Hi,
I am an Engineer from Keysight Technologies.
On Wed, 22 Dec 2021 02:59:43 GMT, Erik Gahlin wrote:
>> Just in time for the holidays I have completed an implementation of the JFR
>> functionality for AIX. As a side note, this is my first submission to
>> OpenJDK
>>
>> ### Implementation notes and alternatives considered
>>
>> After
On Sun, 19 Dec 2021 07:37:19 GMT, Alan Bateman wrote:
>> Enable the security manager in rmiregistry's launcher arguments.
>
> As things stand, `rmiregsitry -J-Djava.security.manager` and `rmiregistry
> -J-Djava.security.manager=allow` are equivalent because rmiregistry sets the
> default SM.
On Fri, 17 Dec 2021 20:01:27 GMT, Stuart Marks wrote:
> Enable the security manager in rmiregistry's launcher arguments.
My concern is that having the SM installed during part of VM initialization
could lead to different behaviour compared to installing the SM after that.
This may be a small
On Fri, 17 Dec 2021 20:01:27 GMT, Stuart Marks wrote:
> Enable the security manager in rmiregistry's launcher arguments.
Hi Stuart,
I think specifying "allow" would be the behaviour preserving change here. That
avoids any risk that enabling the SM earlier changes some behaviour during VM
On Mon, 13 Dec 2021 05:51:37 GMT, David Holmes wrote:
> Trivial update to change the version to 19-ea, and update the single
> reference to the "current release".
>
> Content changes for 19 will follow.
>
> Thanks,
> David
Thanks for the reviews Erik, Jon and
On Mon, 13 Dec 2021 05:51:37 GMT, David Holmes wrote:
> Trivial update to change the version to 19-ea, and update the single
> reference to the "current release".
>
> Content changes for 19 will follow.
>
> Thanks,
> David
This pull request has now been i
On Mon, 13 Dec 2021 05:51:37 GMT, David Holmes wrote:
> Trivial update to change the version to 19-ea, and update the single
> reference to the "current release".
>
> Content changes for 19 will follow.
>
> Thanks,
> David
This "mechanical" update is
Trivial update to change the version to 19-ea, and update the single reference
to the "current release".
Content changes for 19 will follow.
Thanks,
David
-
Commit messages:
- 8278275:Initial nroff manpage generation for JDK 19
Changes:
On Thu, 2 Dec 2021 22:45:37 GMT, Magnus Ihse Bursie wrote:
> In JDK-8237858, -pthread was added to all native tests, instead of the one
> single test that needed it. In the meantime, two new tests with pthread
> dependencies has crept in unnoticed due to this.
Looks good.
I don't think
On Thu, 2 Dec 2021 09:16:59 GMT, Alan Hayward wrote:
> @dholmes-ora
>
> Fixed flags based on comments on the CSR:
Flag updates look good - thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/6334
On Tue, 23 Nov 2021 19:23:40 GMT, Joe Darcy wrote:
>> The time to get JDK 19 underway draws nigh, please review this usual set of
>> start-of-release updates, including CSRs for the javac and javax.lang.model
>> updates:
>>
>> JDK-8277512: Add SourceVersion.RELEASE_19
>>
On Mon, 22 Nov 2021 04:30:38 GMT, Joe Darcy wrote:
>> The time to get JDK 19 underway draws nigh, please review this usual set of
>> start-of-release updates, including CSRs for the javac and javax.lang.model
>> updates:
>>
>> JDK-8277512: Add SourceVersion.RELEASE_19
>>
On Mon, 22 Nov 2021 03:15:51 GMT, Joe Darcy wrote:
> The time to get JDK 19 underway draws nigh, please review this usual set of
> start-of-release updates, including CSRs for the javac and javax.lang.model
> updates:
>
> JDK-8277512: Add SourceVersion.RELEASE_19
>
On Thu, 18 Nov 2021 07:16:56 GMT, Kim Barrett wrote:
> There is nothing here to make the various GCs take advantage of finalization
> being disabled. Is the plan to leave that to followup changes?
@kimbarrett I provided the basic VM parts here. I'm not aware of what
specifically a GC might
On Thu, 18 Nov 2021 07:44:05 GMT, Aleksey Shipilev wrote:
>> @shipilev not sure what you mean by "a flag on the Java side". The Java
>> code just queries the VM for the finalization enabled/disabled state and
>> uses that to control things.
>
> Yeah, "flag" is `Holder.ENABLED` here. I mean,
On Thu, 18 Nov 2021 07:27:30 GMT, Aleksey Shipilev wrote:
>> @stuart-marks not sure I see how anything is different here compared to the
>> existing logic. The `Finalizer` class is explicitly initialized quite early
>> in the init process, but if a preceding class's initialization created an
On Thu, 18 Nov 2021 05:20:02 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/lang/ref/Finalizer.java line 195:
>>
>>> 193:
>>> 194: static {
>>> 195: if (Holder.ENABLED) {
>>
>> Hello Stuart,
>> My understanding of the the lazy `Holder` is that it's there to delay the
On Thu, 18 Nov 2021 01:34:36 GMT, Stuart Marks wrote:
> Pretty much what it says. The new option controls a static member in
> InstanceKlass that's consulted to determine whether the finalization
> machinery is activated for instances when a class is loaded. A new native
> method is added so
On Thu, 11 Nov 2021 14:32:18 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source code in src/utils. This scripts
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
> have manually checked the changes made by the script to make sure they
On Tue, 26 Oct 2021 11:13:19 GMT, Jiří Vaněk wrote:
>> Jiří Vaněk has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> Attmept done. Looks like the summary is
On Mon, 25 Oct 2021 14:33:27 GMT, Doug Simon wrote:
> [JDK-8275645](https://bugs.openjdk.java.net/browse/JDK-8275645) resulted in
> loosing single-copy atomicity for reads in `c2v_readFieldValue`. This PR
> fixes that by using `_field_acquire` accessors for all aligned reads
> and only using
On Tue, 19 Oct 2021 19:21:24 GMT, Harold Seigel wrote:
> Please review this small change to enable CHECK_UNHANDLED_OOPs for Windows
> fastdebug builds. The change was tested by running Mach5 tiers 1-6 on
> Windows-x64-debug.
>
> Thanks, Harold
Seems fine to me.
Thanks,
David
-
On Sat, 16 Oct 2021 11:11:59 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-419 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
linked, as the system's glibc I'm
using (2.18) is also too outdated to run those.
--------
*From:* David Holmes
*Sent:* Sunday, October 10, 2021 6:22 PM
*To:* Aleksey Shipilev ; John Cummings
; build-dev@openjdk.java.net
*Su
On Sun, 10 Oct 2021 13:05:40 GMT, Jie Fu wrote:
> Hi all,
>
> gtest build fails due to stringop-overflow warning with gcc11.
>
> This is because gcc11 seems to be smart enough to detect the following
> stringop-overflow at test/hotspot/gtest/memory/test_guardedMemory.cpp:125:11.
>
> * For
On 9/10/2021 3:58 pm, Aleksey Shipilev wrote:
Hi,
This does not look a build issue per se, but rather a Hotspot bug.
The SIGILL in ThreadGroup.add looks to me like an issue with atomic
operations as that is the first synchronized method that gets executed
during VM initialization.
David
On Sun, 10 Oct 2021 13:05:40 GMT, Jie Fu wrote:
> Hi all,
>
> gtest build fails due to stringop-overflow warning with gcc11.
>
> This is because gcc11 seems to be smart enough to detect the following
> stringop-overflow at test/hotspot/gtest/memory/test_guardedMemory.cpp:125:11.
>
> * For
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request
On 23/09/2021 8:33 pm, Thomas Stuefe wrote:
On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote:
Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's
mention them in `testing.md`.
Current patch is my braindump, I am open for suggestions :)
Aleksey Shipilev
On 23/09/2021 8:53 pm, Magnus Ihse Bursie wrote:
On Thu, 23 Sep 2021 02:56:05 GMT, David Holmes wrote:
Update links to the chromium style guide in the HotSpot Style Guide.
Update looks good and trivial.
Aside: no idea why changes to these files mapped to build-dev ??
Thanks,
David
On Wed, 22 Sep 2021 12:28:18 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request
On Wed, 22 Sep 2021 20:48:11 GMT, Liam Miller-Cushon wrote:
> Update links to the chromium style guide in the HotSpot Style Guide.
Update looks good and trivial.
Aside: no idea why changes to these files mapped to build-dev ??
Thanks,
David
-
Marked as reviewed by dholmes
On Tue, 21 Sep 2021 16:06:28 GMT, Aleksey Shipilev wrote:
>> doc/testing.html line 77:
>>
>>> 75: tier1: This test group is the first line of defense
>>> against bugs. Multiple developers run these tests every day. Normally, at
>>> least this tier is ran before integration. Because of the
On 20/09/2021 9:43 pm, Magnus Ihse Bursie wrote:
On Thu, 16 Sep 2021 12:02:38 GMT, David Holmes wrote:
Building with --with-jvm-variants=core currently produces a binary that replies
an odd version:
$ build/linux-x86_64-core-fastdebug/images/jdk/bin/java -version
openjdk version &qu
On Wed, 15 Sep 2021 09:55:22 GMT, Aleksey Shipilev wrote:
> Building with --with-jvm-variants=core currently produces a binary that
> replies an odd version:
>
>
> $ build/linux-x86_64-core-fastdebug/images/jdk/bin/java -version
> openjdk version "18-internal" 2022-03-15
> OpenJDK Runtime
On 15/09/2021 11:34 pm, Aleksey Shipilev wrote:
On Wed, 15 Sep 2021 12:45:51 GMT, David Holmes wrote:
But perhaps we should be looking to remove "core" going forward?
Yes, we should consider it. @magicus [told
me](https://github.com/openjdk/jdk/pull/5440#discussion_
On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote:
> As the follow-up for Zero-specific JDK-8273494, we might want to clean up
> build system logic for all VM variants: stop impersonating "server" VMs for
> all of them. This basically leaves "core" and "custom" variants to be handled
>
1 - 100 of 1894 matches
Mail list logo
