Withdrawn: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain

On Fri, 2 Jul 2021 15:20:50 GMT, Denghui Dong wrote: > Hi, > > Could I have a review of this improvement that eliminates 'is_large' check if > the event size range is certain? > > JDK-8246260 introduced event large checks to reduce the recording size. > Th

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v5]

On Thu, 8 Jul 2021 04:46:18 GMT, Denghui Dong wrote: >> Hi, >> >> Could I have a review of this improvement that eliminates 'is_large' check >> if the event size range is certain? >> >> JDK-8246260 introduced event large checks to reduce the rec

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v5]

of the > following conditions is satisfied: > 1. if the max size is < 128 > 2. if the min size is >= 128 > > The max size and the min size could be computed for the most native events at > the generation phase. > > And I think this improvement may also be do

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v2]

On Wed, 7 Jul 2021 14:28:27 GMT, Erik Gahlin wrote: > The large check should only happen once `if (written > 127) {` in EventWriterHost::end_event_write could also be eliminated. - PR: https://git.openjdk.java.net/jdk/pull/4670

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v4]

On Tue, 6 Jul 2021 06:19:07 GMT, Denghui Dong wrote: >> Hi, >> >> Could I have a review of this improvement that eliminates 'is_large' check >> if the event size range is certain? >> >> JDK-8246260 introduced event large checks to reduce the rec

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v4]

of the > following conditions is satisfied: > 1. if the max size is < 128 > 2. if the min size is >= 128 > > The max size and the min size could be computed for the most native events at > the generation phase. > > And I think this improvement may also be done for

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v3]

of the > following conditions is satisfied: > 1. if the max size is < 128 > 2. if the min size is >= 128 > > The max size and the min size could be computed for the most native events at > the generation phase. > > And I think this improvement may also be do

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v2]

On Sat, 3 Jul 2021 00:46:13 GMT, Denghui Dong wrote: >> Hi, >> >> Could I have a review of this improvement that eliminates 'is_large' check >> if the event size range is certain? >> >> JDK-8246260 introduced event large checks to reduce the rec

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v2]

of the > following conditions is satisfied: > 1. if the max size is < 128 > 2. if the min size is >= 128 > > The max size and the min size could be computed for the most native events at > the generation phase. > > And I think this improvement may also be do

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain

On Fri, 2 Jul 2021 15:20:50 GMT, Denghui Dong wrote: > Hi, > > Could I have a review of this improvement that eliminates 'is_large' if the > event size range is certain? > > JDK-8246260 introduced event large checks to reduce the recording size. > This check

RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain

Hi, Could I have a review of this improvement that eliminates 'is_large' if the event size range is certain? JDK-8246260 introduced event large checks to reduce the recording size. This check could be eliminated at compile/build time when one of the following conditions is satisfied: 1. if the