Integrated: 8287811: JFR: jfr configure error message should not print stack trace

On Fri, 3 Jun 2022 15:54:47 GMT, Erik Gahlin wrote: > Could I have a review of PR that removes a printStackTrace() for the jfr > tool. > > Testing: jdk/jfr/tool > > Thanks > Erik This pull request has now been integrated. Changeset: 41d5809c Author:Erik Gahl

RFR: 8287811: JFR: jfr configure error message should not print stack trace

Could I have a review of PR that removes a printStackTrace() for the jfr tool. Testing: jdk/jfr/tool Thanks Erik - Commit messages: - Initial Changes: https://git.openjdk.java.net/jdk/pull/9018/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9018&range=00 Issue: ht

Re: RFR: 8280844: Epoch shift synchronization point for Compiler threads is inadequate [v2]

On Mon, 16 May 2022 11:37:43 GMT, Markus Grönlund wrote: >> Greetings, >> >> [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to >> address artefact tagging for Compiler threads, letting threads run >> _thread_in_native to avoid the transition. Unfortunately, that atte

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v3]

On Wed, 11 May 2022 12:59:49 GMT, Magnus Ihse Bursie wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8244681: Add a warning for possibly lossy conversion in compound >> assignments >> recommended correction of th

Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v3]

On Wed, 11 May 2022 07:45:39 GMT, Adam Sotona wrote: >> Please review this patch adding new lint option, **lossy-conversions**, to >> javac to warn about type casts in compound assignments with possible lossy >> conversions. >> >> The new lint warning is shown if the type of the right-hand ope

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v7]

On Fri, 14 Jan 2022 16:18:37 GMT, Tyler Steele wrote: > > I'm looking for some clarification on the purpose > > TestNativeLibrariesEvent.java. Currently it fails with "Missing > > libraries:libjvm.so, libjava.so, libzip.so: expected true, was false". I > > find those libs in my build directory

RFR: 8279825: JFR: JFCModel should use SecuritySupport for predefined .jfc files

Hi, Could I have review of a fix that allows the new parser, used by JFCModel, to read known configuration files in JAVA_HOME/lib/jfr without FilePermission, similar to the older parser. Testing: jdk/jdkjfr Thanks Erik - Commit messages: - Merge branch 'openjdk:master' into smst

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder)

On Fri, 17 Dec 2021 19:07:54 GMT, Tyler wrote: > Just in time for the holidays I have completed an implementation of the JFR > functionality for AIX. As a side note, this is my first submission to OpenJDK > 👋 > > ### Implementation notes and alternatives considered > > After modifying the bui

RFR: 8274559: JFR: Typo in 'jfr help configure' text

Hi, Could I have review of a typo. Testing: jdk/jdk/jfr Thanks Erik - Commit messages: - Initial Changes: https://git.openjdk.java.net/jdk/pull/5803/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5803&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-82745

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v2]

On Sun, 4 Jul 2021 08:32:03 GMT, Denghui Dong wrote: > ``` > BenchmarkMode SamplesScore Score error Units > o.s.MyBenchmark.testEmitthrpt 20 8251457.275 2707.578 ops/s > ``` > > without this patch: That sounds too much. Could you please show the te

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v2]

On Sat, 3 Jul 2021 00:46:13 GMT, Denghui Dong wrote: >> Hi, >> >> Could I have a review of this improvement that eliminates 'is_large' check >> if the event size range is certain? >> >> JDK-8246260 introduced event large checks to reduce the recording size. >> This check could be eliminated at

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default) [v4]

On Wed, 9 Dec 2020 20:58:48 GMT, Markus Grönlund wrote: >> Greetings, >> >> please help review this enhancement to let JFR sample object allocations by >> default. >> >> A description is provided in the JIRA issue. >> >> Thanks >> Markus > > Markus Grönlund has updated the pull request increm

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package [v5]

On Wed, 23 Sep 2020 18:41:06 GMT, Philippe Marschall wrote: >> Hello, newbie here >> >> I picked JDK-8138732 to work on because it has a "starter" label and I >> believe I understand what to do. >> >> - I tried to update the copyright year to 2020 in every file. >> - I decided to change `@sin

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package [v2]

On Sat, 12 Sep 2020 00:19:00 GMT, Vladimir Kozlov wrote: >> Philippe Marschall has refreshed the contents of this pull request, and >> previous commits have been removed. The >> incremental views will show differences compared to the previous content of >> the PR. The pull request contains one

Re: RFR (16): JFR: Separate metadata per JVM-feature

Thanks for the explanation. I think it would better to keep things as is going forward. Erik > On 23 Jul 2020, at 22:29, Roman Kennke wrote: > > Hi Erik, > > >> Hi Roman, >> >> What is the problem you are trying to solve? >> > > It is mostly an exercise in cleanliness. In the effort to u

Re: RFR (16): JFR: Separate metadata per JVM-feature

Hi Roman, What is the problem you are trying to solve? Speed up compilation, or exclude metadata from recordings? Having metadata per JVM-features adds complexity with little added benefit from what I can see. Thanks Erik > On 23 Jul 2020, at 19:48, Roman Kennke wrote: > > This is a fall-

Re: RFR: 8246436: JFR: Avoid parsing metadata.xml during startup

ches # 485.148 M/sec > ( +- 1.08% ) >44,986,319 branch-misses #4.03% of all branches >( +- 0.85% ) > > 0.481467615 seconds time elapsed ( +- 1.27% ) > > > On 2020-06-18 01:16, Erik Ga

RFR: 8246436: JFR: Avoid parsing metadata.xml during startup

Hi, Could I have review of an enhancement that will avoid parsing the XML metadata for the JVM events during startup/runtime. Thanks to Magnus for helping out with changes to the make files. Bug: https://bugs.openjdk.java.net/browse/JDK-8246436 Webrev: http://cr.openjdk.java.net/~egahlin/8246

Re: RFR: 8216303: JFR: Simplify generated files

Thanks for the reviews. Erik > On 28 May 2020, at 22:55, Erik Joelsson wrote: > > > On 2020-05-28 13:51, Erik Gahlin wrote: >> Hello Erik, >> >>> On 28 May 2020, at 19:47, Erik Joelsson wrote: >>> >>> Hello Erik, >>> >>

Re: RFR: 8216303: JFR: Simplify generated files

gt; as it gives a predictable iteration order, but forgot to remove the import. > > Do you know if the generated files are stable over several builds? They should be stable. Events are numbered after how they are specified in /hotspot/share/jfr/metadata/metadata.xml. Erik > > /Erik &g

RFR: 8216303: JFR: Simplify generated files

Hi, Could I have a review of a fix that removes legacy in the generated JFR event files, in particular hard coded numbers for type / event IDs. Event IDs are now numbered from zero, which has the benefit that most of them can be represented as a single byte instead of two. This will reduce the

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

jfr should be JDK Flight Recorder. Erik On 2020-02-21 16:05, Magnus Ihse Bursie wrote: The JVM feature rewrite was actually somewhat of a step backwards in terms of presenting information for the user what different configure arguments do. I've compensated for this by making it far better! :

Re: RFR(S) : 8228448 : Jconsole can't connect to itself

Looks good. Erik Hi all, Please review this small patch. Added "-Djdk.attach.allowAttachSelf=true" to jconsole launcher make file. This will allow jconsole to connect to itself. JBS: https://bugs.openjdk.java.net/browse/JDK-8228448 Webrev: http://cr.openjdk.java.net/~vaibhav/8228

Re: RFR(XL): 8199712: Flight Recorder

future to generate additional files using the jfr tool. Will fix this in a follow up bug: https://bugs.openjdk.java.net/browse/JDK-8203221 Thanks Erik /Erik On 2018-05-14 07:36, Erik Gahlin wrote: Here is an updated webrev: http://cr.openjdk.java.net/~egahlin/8199712.1/ [1] that in

Re: RFR(XL): 8199712: Flight Recorder

Here is an updated webrev: http://cr.openjdk.java.net/~egahlin/8199712.1/ [1] that incorporates: - build changes - new event prefix, i.e. "com.oracle.jdk.CPULoad" becomes "jdk.CPULoad" - obsolete command line options EnableTracing and UseLockedTracing - fixed typos in the Javadoc - simplified #

Re: RFR(XL): 8199712: Flight Recorder

Hi Magnus, Sorry about not including build-dev. See comments inline. On 2018-04-25 13:06, Erik Gahlin wrote: Greetings, Could I have a review of 8199712: Flight Recorder As mentioned in the preview [1] the tracing backend has been removed. Event metadata has been consolidated into a

Re: (8u) RFR: 8152000: Java FlightRecorder does not run on Java 8 compact 3 profile since u65

Looks good Erik Bug: https://bugs.openjdk.java.net/browse/JDK-8152000 webrev: http://cr.openjdk.java.net/~dholmes/8152000/webrev/ This is a small adjustment to the build of compact profiles to allow a useful but unsupported configuration to continue to work after it stopped working in 8u60.

Re: RFR: JDK-8166202: Tracefile gensrc cannot handle closed src dir in different location

Looks good. Erik The xml/xsl source files used to generate sources for trace in hotspot have hard coded relative paths in them that make assumptions on where the oracle closed files are located. The source files should not make these kind of assumptions since that makes it difficult to change

Re: RFR: JDK-8075056 Remove Version.java.template from jconsole

Looks good, jconsole now compile in Eclipse! Erik Staffan Larsen skrev 2015-03-12 13:54: The build for jconsole currently takes a template file and inserts the version number of the build into the file. We can simplify this by removing the template file and reading the java.runtime.version sys

Re: Le roi est mort, vive le roi!

I know 5-10 Hotspot developers who uses Visual Studio (me included) so I hope it's not something that is going away. Erik Staffan Larsen skrev 2013-11-26 20:10: I am in full agreement with you that an IDE is a very powerful tool and I much prefer to work in an IDE than outside one. However, I

RFR: 2228582: Licensee source bundle tries to compile JFR

Hi, Could you please review this fix for licensee source bundle. This is a forward port of: https://bugs.openjdk.java.net/browse/JDK-8001697 I removed: ifndef OPENJDK ifndef JAVASE_EMBEDDED and only check for BUILD_JFR. Not sure if it is correct? I tried to build with: make newbuild=true