On Tue, 16 Mar 2021 10:53:06 GMT, Robin Westberg wrote:
> When the Skara feature "dependent pull requests" is activated for the JDK
> repository, branches with the name "pr/" will start to appear. These
> will not be synced into personal forks by the Skara sync command, but if they
> are synce
On Fri, 13 Nov 2020 11:48:31 GMT, Robin Westberg wrote:
> We should be more explicit about OS and compiler versions used in the GitHub
> Actions builds, to avoid problems caused by unexpected changes to the
> defaults. This patch changes the OS and Xcode versions used from latest
> (currently
On Sat, 5 Sep 2020 09:14:47 GMT, Erik Helin wrote:
> Hi all,
>
> please ignore this "RFR" e-mail, this is just a final test of the Skara [0]
> tooling.
>
> Thanks,
> Erik
>
> [0]: https://openjdk.java.net/projects/skara/
This pull request has
On Wed, 7 Oct 2020 18:19:40 GMT, Aleksey Shipilev wrote:
> After migration to Git, this serves no purpose. The file is not updated, does
> not seem to be used. We can easily remove
> it.
> There is also .hgtags, but that might have some value for verification, so
> let's keep it around until Me
On Tue, 6 Oct 2020 06:39:55 GMT, Robin Westberg wrote:
> The `set-env` command was recently deprecated in favor of a different method
> of setting environment variables, due to a
> security vulnerability [1]. The vulnerability does not affect our usage of
> GitHub Actions, but we should neverth
On Fri, 25 Sep 2020 13:10:01 GMT, Robin Westberg wrote:
>> A few days ago I posted an initial version of the necessary configuration
>> required to run pre-submit build and tests
>> for JDK main-line contributions using GitHub Actions [2] and the free tier
>> [3] available to everyone working w
On Tue, 15 Sep 2020 01:19:32 GMT, Aditya Mandaleeka wrote:
>> The symbol generation script assumed Mercurial was being used as the SCM.
>> This should now be updated to Git.
>
> make/scripts/generate-symbol-data.sh line 66:
>
>> 64: fi;
>> 65:
>> 66: if [ "`git status -s .`x" != "x" ] ; then
>
On Fri, 11 Sep 2020 14:28:41 GMT, Kevin Rushforth wrote:
> In the fix for
> [JDK-8252844](https://bugs.openjdk.java.net/browse/JDK-8252844) the tags
> entry in `.jcheck/conf` was
> copied from the Skara Java code. The `` chars were escaped as `\` in the Java
> String so that it would contain `
On Tue, 8 Sep 2020 10:31:42 GMT, Robin Westberg wrote:
> The initial version of the Skara-formatted jcheck configuration file
> contained a small error, this change corrects it.
>
> Best regards,
> Robin
Looks good, thanks for fixing!
-
Marked as reviewed by ehelin (Reviewer).
P
On Mon, 7 Sep 2020 08:03:25 GMT, Robin Westberg wrote:
>> Now that the JDK main-line repository is using the Skara tooling, the jcheck
>> configuration file should be updated to
>> the new format.
>> Best regards,
>> Robin
>
> Robin Westberg has updated the pull request incrementally with one ad
Please ignore this reply as well, this is just testing the Skara mailing
list synchronization.
Thanks,
Erik
On 9/5/20 12:22 PM, Erik Helin wrote:
Hi all,
please ignore this "RFR" e-mail, this is just a final test of the Skara [0]
tooling.
Thanks,
Erik
[0]: https://openjd
Hi all,
please ignore this "RFR" e-mail, this is just a final test of the Skara [0]
tooling.
Thanks,
Erik
[0]: https://openjdk.java.net/projects/skara/
-
Commit messages:
- 8252819: This is just a test
Changes: https://git.openjdk.java.net/jdk/pull/18/files
Webrev: https://webr
Looks good, Reviewed.
Thanks!
Erik
On 9/3/20 5:49 PM, Magnus Ihse Bursie wrote:
This is an old bug that was opened long time ago, but with a much better
solution for the "autocrlf" problem. Erik and I have agreed that using
"-text" as attribute for all files is the best solution to mimic the o
On 6/3/20 12:54 PM, Magnus Ihse Bursie wrote:
The JSON parser comes from Project Skara. I have made a few patches,
which cleans up some code (to stop IntelliJ from complaining about
ugliness), and added some functionality that was needed by this use
case. For those who are interested, the patch
,
Erik
/Erik
On 2020-02-13 04:44, Erik Helin wrote:
Hi all,
this small patch changes FindTest.gmk to only include TEST.ROOT files
that actually are present. The motivation for this change is that both
Git and Mercurial supports so called "sparse" checkouts [0][1] (still
somewhat experi
Hi all,
this small patch changes FindTest.gmk to only include TEST.ROOT files
that actually are present. The motivation for this change is that both
Git and Mercurial supports so called "sparse" checkouts [0][1] (still
somewhat experimental for both, but actively worked on). While
experimenti
On 2/11/20 11:29 PM, Roger Riggs wrote:
Please review a small change to the idea.sh script that generates an
IntelliJ project.
It detects either Mercurial or Git repos and generates the appropriate
vcs.xml.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-idea-git-8238918/
Looks good!
> On 28 Jan 2019, at 23:17, Erik Joelsson wrote:
>
> Hello,
>
> While investigating performance with different linkers and linker
> configuration, we discovered that the devkit linker on Linux (both bfd and
> gold) was a lot slower than the native linker on Ubuntu (23s vs 12s for bfd
> to lin
On 10/4/18 2:31 PM, Magnus Ihse Bursie wrote:>> 4 okt. 2018 kl. 10:57
skrev Martijn Verburg :
I like this initiative. I'm wondering if some of these rules can be easily
codified or written into a jcheck style checker (ccheck?) so that Authors
can adhere to the conventions and not rely on a Human
On 09/05/2018 06:51 PM, Erik Joelsson wrote:
It was pointed out offline that I had missed some "Mercurial" in log
messages. This webrev also reintroduces the .gitignore file that was
mistakenly omitted in the last webrev.
http://cr.openjdk.java.net/~erikj/8210283/webrev.03/
Hi Erik,
thanks
, 2018, at 9:50 PM, Erik Helin wrote:
On 06/29/2018 06:42 AM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8206088/webrev.00/index.html
1 line changed: 0 ins; 0 del; 1 mod;
Hi all,
could you please review this one liner fix?
webrev: http://cr.openjdk.java.net/~iignatyev//8206088
On 06/29/2018 06:42 AM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8206088/webrev.00/index.html
1 line changed: 0 ins; 0 del; 1 mod;
Hi all,
could you please review this one liner fix?
webrev: http://cr.openjdk.java.net/~iignatyev//8206088/webrev.00/index.html
Hmmm, it see
On 05/15/2018 08:58 PM, Igor Ignatyev wrote:
Hi Erik,
please see my answers inline.
can I consider this RFR as reviewed by you?
Yep!
Thanks,
-- Igor
On May 14, 2018, at 4:23 AM, Erik Helin wrote:
On 05/08/2018 12:35 AM, Igor Ignatyev wrote:
Hi all,
Hi Igor,
On 05/08/2018 12:35 AM
On 05/08/2018 12:35 AM, Igor Ignatyev wrote:
Hi all,
Hi Igor,
On 05/08/2018 12:35 AM, Igor Ignatyev wrote:
could you please review the patch which open sources GC tests from vm testbase?
it introduces the following test groups:
- vmTestbase_vm_g1classunloading
- vmTestbase_vm_gc_compact
- vm
On 05/02/2018 04:37 PM, Stefan Karlsson wrote:
> Hi all,
Hi Stefan,
thanks for taking on this work, much appreciated!
On 05/02/2018 04:37 PM, Stefan Karlsson wrote:
> The first patch simply cleans up some INCLUDE_ALL_GCS usages in
platform-specific files. Some of these changes are already bein
On 03/20/2018 02:54 PM, Edward Nevill wrote:
On Tue, 2018-03-20 at 08:39 +0100, Erik Helin wrote:
Please review the following webrev
Bugid: https://bugs.openjdk.java.net/browse/JDK-8199138
Webrev: http://cr.openjdk.java.net/~enevill/8199138/webrev.00
32 # First, filter out everything
On 03/02/2018 01:48 PM, Magnus Ihse Bursie wrote:
In make/doc/testing.md, the descriptions of the TEST option for jtreg
tests has not been updated to account for the repository layout change.
For example, "hotspot/test:hotspot_gc" should be
"test/hotspot/jtreg:hotspot_gc".
Bug: https://bugs.o
On 01/19/2018 07:18 AM, Martin Buchholz wrote:
Differing projects have come to different conclusions about whether to
include a generated configure.
But the standard seems to be to include one. The mantra is: "./configure &&
make" without an autoconf step.
And this is still the mantra (except
Hi all,
here is small patch that allows the configure option --with-jtreg to
accept a zip compressed jtreg image (the option currently accepts a
jtreg image directory). The jtreg image will be unpacked into
$CONFIGURE_SUPPORT/jtreg.
Patch:
http://cr.openjdk.java.net/~ehelin/8193686/00/
Issu
Hi all,
while working a bit on the configure code I noticed that the error
message when autoconf is missing prints the wrong path to autogen.sh.
This tiny patch updates the error message:
diff -r 589a6f1d86e9 -r 3ba5af45725a make/autoconf/configure
--- a/make/autoconf/configure Sat Dec 09 0
et/~ehelin/8193189/02/
- inc: http://cr.openjdk.java.net/~ehelin/8193189/01-02/
What do you think?
Thanks,
Erik
/Erik
On 2017-12-08 05:56, Erik Helin wrote:
On 12/07/2017 07:05 PM, Erik Joelsson wrote:
Hello Erik,
On macosx, the tar.gz distribution usually has the java home dir in
"jdk
/Erik
On 2017-12-07 09:05, Erik Helin wrote:
Hi all,
this small patch allows the --boot-jdk flag to configure to accept a
gzip compressed JDK image. For example:
$ wget
http://download.java.net/java/GA/jdk9/9.0.1/binaries/openjdk-9.0.1_linux-x64_bin.tar.gz
$ bash configure --wit
Hi all,
this small patch allows the --boot-jdk flag to configure to accept a
gzip compressed JDK image. For example:
$ wget
http://download.java.net/java/GA/jdk9/9.0.1/binaries/openjdk-9.0.1_linux-x64_bin.tar.gz
$ bash configure --with-boot-jdk=openjdk-9.0.1_linux-x64_bin.tar.gz
The com
On 11/22/2017 03:01 PM, Magnus Ihse Bursie wrote:
We should not have "zipped" as default for native-debug-symbols. In the
future, this option should probably be dropped completely, but for now,
start by not making it default.
Bug: https://bugs.openjdk.java.net/browse/JDK-8191205
Patch inline:
On 11/10/2017 09:01 AM, Thomas Stüfe wrote:
Hi Erik,
On Fri, Nov 10, 2017 at 12:52 AM, Erik Joelsson
wrote:
Hello,
On 2017-11-09 15:26, Thomas Stüfe wrote:
Do you think this for all platforms or just for Windows? With removed, do
you really mean the feature removed, not just the default cha
will submit
webrev/RFR soon and will request help confirm similar issues with
latest gcc7 gets solved.
Thanks,
Rahul
On Tuesday 19 September 2017 07:07 PM, Erik Helin wrote:
Hi all,
with gcc 7.1.1 from Fedora 26 on x86-64 there are warnings about the
potential usage of maybe uninitialized m
On 09/19/2017 03:55 PM, Kim Barrett wrote:
On Sep 19, 2017, at 9:37 AM, Erik Helin wrote:
Hi all,
with gcc 7.1.1 from Fedora 26 on x86-64 there are warnings about the potential
usage of maybe uninitialized memory in src/hotspot/cpu/x86/assembler_x86.cpp
and in src/hotspot/cpu/x86
Hi all,
with gcc 7.1.1 from Fedora 26 on x86-64 there are warnings about the
potential usage of maybe uninitialized memory in
src/hotspot/cpu/x86/assembler_x86.cpp and in
src/hotspot/cpu/x86/interp_masm_x86.cpp.
The problems arises from the class RelocationHolder in
src/hotspot/share/code/r
On 07/14/2017 11:23 AM, John Paul Adrian Glaubitz wrote:
Hi Erik!
On Thu, Jul 06, 2017 at 02:55:53PM +0200, Erik Helin wrote:
Yes, you now have two reviewers. But for these changes (hotspot) you
need a sponsor, which needs to be an Oracle employee, which I am not.
Maybe Eric could sponsor the
On 07/04/2017 11:33 AM, John Paul Adrian Glaubitz wrote:
On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote:
I think the first three patches (hotspot-add-missing-log-header.diff,
hotspot-fix-checkbytebuffer.diff, rename-sparc-linux-atomic-header.diff) all
look good, thanks for fixing
On 07/05/2017 09:23 PM, Thomas Stüfe wrote:
On Wed 5. Jul 2017 at 19:39, John Paul Adrian Glaubitz
mailto:glaub...@physik.fu-berlin.de>> wrote:
On 07/05/2017 07:37 PM, Thomas Stüfe wrote:
> Nah, I believe you :) Changes are trivial enough.
OK. So we're good to merge then?
--
On 06/19/2017 09:06 AM, John Paul Adrian Glaubitz wrote:
On Mon, Jun 19, 2017 at 08:59:38AM +0200, Erik Helin wrote:
I'm asking because running the testsuite on Linux sparc64 will only be
possible with all four patches applied as they are build fixes. Running
the testsuite on Linux x
On 06/18/2017 01:40 AM, John Paul Adrian Glaubitz wrote:
> Hi Erik!
>
> On 06/14/2017 02:04 PM, John Paul Adrian Glaubitz wrote:
>> On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote:
>>> thanks for contributing and signing the OCA!
>>
>> Thanks for r
On 06/14/2017 02:21 PM, Severin Gehwolf wrote:
> Hi Eric,
>
> On Wed, 2017-06-14 at 13:50 +0200, Erik Helin wrote:
>> For the fourth patch, fix-zero-build-on-sparc.diff, I'm not so sure. For
>> example, the following is a bit surprising to me (mostly because I&#x
On 06/14/2017 02:04 PM, John Paul Adrian Glaubitz wrote:
Hi Erik!
On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote:
thanks for contributing and signing the OCA!
Thanks for reviewing my patches ;-).
I think the first three patches (hotspot-add-missing-log-header.diff,
hotspot-fix
Hey Adrian,
thanks for contributing and signing the OCA!
I think the first three patches (hotspot-add-missing-log-header.diff,
hotspot-fix-checkbytebuffer.diff, rename-sparc-linux-atomic-header.diff)
all look good, thanks for fixing broken code. Consider them Reviewed by
me. Every patch needs
Hi Magnus,
thank you so much for doing this patch! Having a convenient way to run
tests from the Makefiles is something I have wanted for a very long time
:) Unfortunately I don't have the required Makefile knowledge to review
this, but if I can help out with testing the patch, just let me kno
e sense to remove "-server" from @run instead?
>
> Thanks,
> Dima
>
>
>
>
> On 06.10.2016 15:57, Erik Helin wrote:
> >On 2016-10-06, David Holmes wrote:
> >>On 4/10/2016 7:42 PM, Erik Helin wrote:
> >>>On 2016-09-30, Leonid Mesnik wrote
On 2016-10-06, David Holmes wrote:
> On 4/10/2016 7:42 PM, Erik Helin wrote:
> >On 2016-09-30, Leonid Mesnik wrote:
> >>Hi
> >>
> >>I think that it would be better to split this test into 4 tests. Currently
> >>this test is going to be skipped if any
p://cr.openjdk.java.net/~ehelin/8166790/hotspot/01/
Thanks,
Erik
> Leonid
>
>
> On 28.09.2016 18:01, Erik Helin wrote:
> >Hi all,
> >
> >this patch adds a new GC stress test called GCBasher. GCBasher builds up
> >large (well, for some definiton of large) obj
On 2016-09-29, David Holmes wrote:
>
>
> On 29/09/2016 5:52 PM, Erik Helin wrote:
> >On 2016-09-29, David Holmes wrote:
> >>Hi Erik,
> >
> >Hi David, thanks for reviewing!
> >
> >>On 29/09/2016 1:01 AM, Erik Helin wrote:
> >>>
On 2016-09-29, David Holmes wrote:
> Hi Erik,
Hi David, thanks for reviewing!
> On 29/09/2016 1:01 AM, Erik Helin wrote:
> >Hi all,
> >
> >this patch adds a new GC stress test called GCBasher. GCBasher builds up
> >large (well, for some definiton of large) object
Hi all,
this patch adds a new GC stress test called GCBasher. GCBasher builds up
large (well, for some definiton of large) object graphs by figuring out
the relations between classes in the JDK. The test usually stresses the
GC quite a lot, especially when run with a smaller heap.
The changes in
On 2016-07-20, Mikael Gerdin wrote:
> Hi all,
>
> Please review this small fix to work around a problem where incremental
> builds of hotspot would fail due to the symbol runUnitTests missing.
>
> The cause for the problem is that the unit tests launcher linker command
> line contains a -L path c
er.cpp from
PRECOMPILED_HEADER_EXCLUDE before I push.
> Otherwise looks good.
Thanks,
Erik
> /Erik
>
> On 2016-06-14 02:50, Erik Helin wrote:
> >Hi all,
> >
> >this patch adds support for pre-compiled headers (PCH) to the gtest unit
> >tests.
> >
> &
Hi all,
this patch adds support for pre-compiled headers (PCH) to the gtest unit
tests.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8159364
Webrev:
http://cr.openjdk.java.net/~ehelin/8159364/00/
Testing:
- JPRT
Thanks,
Erik
Hi all,
this small patch adds an extension to CompileGtest.gmk.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8159340
Webrev:
http://cr.openjdk.java.net/~ehelin/8159340/00/
Testing:
- JPRT
Thanks,
Erik
Hi all,
this small patch ensures that the Makefiles correctly excludes gtest
unit tests for a minimal build. Right now, if you add a test to e.g.
hotspot/native/gc/g1, the test will be included in a minimal build,
which will fail.
Thanks to Erik Joelsson for helping out with this patch!
Bug:
htt
Hi all,
this small patch adds a top-level Makefile target for conveniently
running the gtest unit tests.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8157028
Webrev:
http://cr.openjdk.java.net/~ehelin/8157028/webrev.00/
Testing:
- Running locally on Linux x86-64
Thanks,
Erik
it to handle
parallel make execution.
/Erik
On 2016-02-05 13:34, Erik Helin wrote:
Hi all,
this tiny patch makes the common test targets in test/Makefile a bit
more silent. The patch silences the `make` command and also silences the
"Entering directory" output from make. For example, run
Hi all,
this tiny patch makes the common test targets in test/Makefile a bit
more silent. The patch silences the `make` command and also silences the
"Entering directory" output from make. For example, running
`make test-hotspot-internal` currently prints:
Building target 'test-hotspot-internal
t use ALT_OUTPUTDIR, the output will be stored in
build/-/testoutput/
which JPRT seems to handle just fine.
Thanks,
Erik
On 2016-01-13, Erik Helin wrote:
> Hi all,
>
> this patch changes the output directory for hotspot's jtreg tests when
> run via the top-level Makefile target
duplication, but that's a separate issue.
>
> Cheers,
> Mikael
>
> On 2016-01-13 06:04, Erik Helin wrote:
> >(added missing subject)
> >
> >On 2016-01-13, Erik Helin wrote:
> >>Hi all,
> >>
> >>this patch changes the output dir
>same way in both cases, to avoid confusion and all of that.
> >
> >It would be even better to share the logic all together to avoid
> >duplication, but that's a separate issue.
> >
> >Cheers,
> >Mikael
> >
> >On 2016-01-13 06:04, Erik Helin wrote:
>
e?
Thanks,
Erik
> Thanks,
> /Staffan
>
>
> > On 13 jan. 2016, at 15:01, Erik Helin wrote:
> >
> > Hi all,
> >
> > this patch changes the output directory for hotspot's jtreg tests when
> > run via the top-level Makefile targets suc
(added missing subject)
On 2016-01-13, Erik Helin wrote:
> Hi all,
>
> this patch changes the output directory for hotspot's jtreg tests when
> run via the top-level Makefile targets such as
> `make test-hotspot-jtreg`.
>
> The current directory is
> /build//hotsp
Hi all,
this patch changes the output directory for hotspot's jtreg tests when
run via the top-level Makefile targets such as
`make test-hotspot-jtreg`.
The current directory is
/build//hotspot/linux-x64/testoutput
(on an x86-64 machine running Linux). There is no need to place the
"testoutput" d
Hi all,
this very small patches silences the 'clean' target in
hotspot/test/Makefile (the 'prep' target is already silent).
Enhancement:
https://bugs.openjdk.java.net/browse/JDK-8146871
Webrev:
http://cr.openjdk.java.net/~ehelin/8146871/00/webrev/
Testing:
- Buiding locally and verified that th
On 2015-11-04, Thomas Schatzl wrote:
> Hi,
>
> On Wed, 2015-11-04 at 12:12 +0100, Volker Simonis wrote:
> > Hi Erik,
> >
> > thanks a lot for your understanding :)
> >
> > Your suggestion is perfectly fine for me and we can live with both
> > versions of the fix.
>
> I went for the change in
rted build platform.
> >
> > Also there seems to be enough interest in the community about keeping the
> > VS2010 build alive, see
> > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-October/015978.html
> >
> > We (SAP) unfortunately still use Visual
On 2015-10-09, Magnus Ihse Bursie wrote:
> Looks good to me.
Thanks!
Erik
> /Magnus
>
> > 9 okt 2015 kl. 14:23 skrev Erik Helin :
> >
> > Hi all,
> >
> > this patch adds a new top-level Makefile to run the hotspot jtreg tests.
> > This is alrea
On 2015-10-09, Erik Joelsson wrote:
> Looks good to me.
Thanks!
Erik
> /Erik
>
> On 2015-10-09 14:23, Erik Helin wrote:
> >Hi all,
> >
> >this patch adds a new top-level Makefile to run the hotspot jtreg tests.
> >This is already possible today by runni
On 2015-10-14, Magnus Ihse Bursie wrote:
> On 2015-10-09 14:09, Erik Helin wrote:
> >Hi all,
> >
> >this patch adds a new configure variable: --with-test-jobs. The new
> >variable configures how many tests jobs we run concurrently (aka the
> >-concurrency fla
On 2015-10-09, Magnus Ihse Bursie wrote:
> On 2015-10-09 10:35, Erik Helin wrote:
> >Hi all,
> >
> >this small patch add a new top-level Makefile target:
> >test-hotspot-internal. The target is just an easier way to run the unit
> >tests in hotspot (the ones you
On 2015-10-09, Erik Joelsson wrote:
> Looks good to me.
Thanks!
Erik
> /Erik
>
> On 2015-10-09 10:35, Erik Helin wrote:
> >Hi all,
> >
> >this small patch add a new top-level Makefile target:
> >test-hotspot-internal. The target is just an easier way to r
Hi all,
this patch adds a new top-level Makefile to run the hotspot jtreg tests.
This is already possible today by running:
$ make test TEST="hotspot_all"
The new target, test-hotspot-jtreg, is a bit more discoverable in my
opinion (will also work with tab completion in supported shells).
Enhanc
Hi all,
this patch adds a new configure variable: --with-test-jobs. The new
variable configures how many tests jobs we run concurrently (aka the
-concurrency flag to JTReg). Today --with-jobs is passed as the
-concurrency flag to JTReg which most likely is too big for most
systems with many cores.
Hi all,
this small patch add a new top-level Makefile target:
test-hotspot-internal. The target is just an easier way to run the unit
tests in hotspot (the ones you execute by using the flag
-XX:+ExecuteInternalVMTests).
Enhancement:
https://bugs.openjdk.java.net/browse/JDK-8139256
Webrev:
- roo
On 2015-03-24, Mikael Gerdin wrote:
> Hi Volker,
>
> On 2015-03-19 15:26, Volker Simonis wrote:
> >Hi Mikael,
> >
> >the change looks good (and I think it is really reasonable to have
> >this warning).
> >I've also checked that our ancient gcc 4.1.2 already supports this option:)
>
> Thanks!
>
>
On 2014-12-16, David Holmes wrote:
> On 16/12/2014 1:20 AM, Erik Helin wrote:
> >Hi all,
> >
> >this patch changes the dependency for the target `test` in make/Main.gmk
> >from exploded-image to jimages. This is needed because PRODUCT_HOME in
> >`make test` ne
Hi all,
this patch changes the dependency for the target `test` in make/Main.gmk
from exploded-image to jimages. This is needed because PRODUCT_HOME in
`make test` needs to be set to a full JDK image directory, because there
are tests in hotspot/test that uses -Xshare:dump and -Xshare:dump does
no
ly in some future
GCC 4.9.x release).
Thanks,
Erik
[2]:
https://gcc.gnu.org/onlinedocs/gcc-4.9.2/gcc/Debugging-Options.html#Debugging-Options
> /Erik
>
> On 2014-11-21 15:57, Erik Helin wrote:
> >Hi all,
> >
> >this patch removes the usage of the flag -fsanitize=unde
Hi all,
this patch changes the debug symbols format on Solaris from STABS
[0] to DWARF [1] for libjvm.so. Since the supported compiler on Solaris
has been updated to Oracle Solaris Studio 12.3 [2], the STABS debug format
is now deprecated in the supported compiler [3]:
-xdebugformat=stabs gener
Hi all,
this patch removes the usage of the flag -fsanitize=undefined introduced
in GCC 4.9. The reason for not using this flag is that the implementation
in GCC still seem to have some bugs [0] (which I have encountered). The
flag is currently only enabled for slowdebug builds.
My suggestion is
Hi Mikael,
thanks for fixing this! Looks good, Reviewed.
Erik
On 2014-09-18 10:39, Mikael Gerdin wrote:
Hi all,
As you may know, linking an ELF shared object allows unresolved external
symbols at link time. This is sometimes problematic for JVM developers since
the JVM does not depend on unre
On 2014-09-15 18:43, Volker Simonis wrote:
On Mon, Sep 15, 2014 at 11:49 AM, Erik Joelsson
wrote:
On 2014-09-15 10:26, Erik Helin wrote:
On 2014-09-12 17:17, Erik Joelsson wrote:
Hello Erik,
Looks good to me.
Thanks!
On 2014-09-12 17:17, Erik Joelsson wrote:
Don't forget to
Hi Tim,
thanks for reviewing!
Erik
On 2014-09-12 17:25, Tim Bell wrote:
Looks good to me as well.
Tim
On 09/12/14 08:17, Erik Joelsson wrote:
Hello Erik,
Looks good to me. Don't forget to also push the generated-configure.sh
files.
/Erik
On 2014-09-12 17:05, Erik Helin wrote:
H
wing steps the preferred way of updating
generated-configure.sh?
$ sh common/autoconf/autogen.sh
$ hg add common/autoconf/generated-configure.sh
Thanks,
Erik
/Erik
On 2014-09-12 17:05, Erik Helin wrote:
Hi all,
the top-level Makefiles are using the target jvm in the HotSpot
Makefiles when
Hi all,
the top-level Makefiles are using the target jvm in the HotSpot
Makefiles when configured with --debug-level=slowdebug. The jvmg target
has been deprecated in the HotSpot Makefiles, the debug target should be
used instead.
This small patch changes jdk-options.m4 to use the debug targ
014 23:18:40 PM Dmitry Samersoff wrote:
> -Dmitry
>
> On 2014-02-10 19:21, Erik Helin wrote:
> > Sigh, I forgot the subject...
> >
> > "RFR: 8034094: SA agent can't compile when jni_x86.h is used"
> >
> > Thanks,
> > Erik
> >
>
Hi Erik,
thanks for having a look at the patches!
On Wednesday 30 April 2014 13:39:01 PM Erik Joelsson wrote:
> I think option 2 seems best.
Ok, that is my preferred option as well, thanks!
Erik
> /Erik
>
> On 2014-04-30 13:26, Erik Helin wrote:
> > Anyone interested in
Anyone interested in this patch? I ran into this issue again yesterday...
Thanks,
Erik
On 2014-02-10 16:21, Erik Helin wrote:
Sigh, I forgot the subject...
"RFR: 8034094: SA agent can't compile when jni_x86.h is used"
Thanks,
Erik
On 2014-02-10 16:08, Erik Helin wrote:
Hi a
ng of the rule lines themselves...
If you change the indenting, I don't see a reason for
another round of review.
Dan
On 2/14/14 6:21 AM, Erik Helin wrote:
Dan,
On 2014-02-14 00:29, Daniel D. Daugherty wrote:
> http://cr.openjdk.java.net/~ehelin/8033580/webrev.01/
make/Makefile
run.
Thanks,
Erik
Dan
On 2/13/14 1:59 PM, Erik Helin wrote:
Hi Dan,
thanks for reviewing! See my replies inline.
On 02/13/2014 12:40 AM, Daniel D. Daugherty wrote:
> http://cr.openjdk.java.net/~ehelin/8033580/webrev.00/
make/Makefile
277 ifeq ($(ZIP_DEBUGINFO_FILES),1)
278
eparate patch.
Thanks,
Erik
Dan
On 2/12/14 8:03 AM, Erik Helin wrote:
Hi all,
this patch changes how old debug information copied from IMPORT_JDK is
treated.
When running the copy_*_jdk target, HotSpot's makefiles copies the
entire IMPORT_JDK folder, including additional files (such as unzi
Hi all,
this patch changes how old debug information copied from IMPORT_JDK is
treated.
When running the copy_*_jdk target, HotSpot's makefiles copies the
entire IMPORT_JDK folder, including additional files (such as unzipped
debug information). The export_*_jdk targets will then, via the
g
Sigh, I forgot the subject...
"RFR: 8034094: SA agent can't compile when jni_x86.h is used"
Thanks,
Erik
On 2014-02-10 16:08, Erik Helin wrote:
Hi all,
this patch fixes an issue with HotSpot's makefiles, IMPORT_JDK and
jni_md.h.
The bug manifests itself when using
Hi all,
this patch fixes an issue with HotSpot's makefiles, IMPORT_JDK and jni_md.h.
The bug manifests itself when using an IMPORT_JDK which
include/linux/jni_md.h has a timestamp that is older than
hotspot/src/cpu/x86/jni_x86.h. When this happens, the Makefiles will
copy hotspot/src/cpu/x86/jn
98 matches
Mail list logo
