Error using JIB on linux lab machine

2016-07-06 Thread Gerald Thornbrugh
Hi Everyone, I am trying to use JIB to do a build on a linux lab machine (sc11137378.us.oracle.com) and get an error during the “make” command. The “configure” completes without error and when I do the “make” I get an an error that seems to related to this message in the output: error: Bad owne

Re: RFR 8144278 [TESTBUG] hotspot/runtime/StackGuardPages/testme.sh should use native library build support

2016-06-12 Thread Gerald Thornbrugh
Hi David, I will make the change you suggested. Thanks! Jerry Hi Jerry, On 11/06/2016 2:16 AM, Gerald Thornbrugh wrote: Hi Everyone, I have address Erik's, Dmitry's and David's concerns in a new webrev: Bug: https://bugs.openjdk.java.net/browse/JDK-8144278 J

Re: RFR 8144278 [TESTBUG] hotspot/runtime/StackGuardPages/testme.sh should use native library build support

2016-06-12 Thread Gerald Thornbrugh
Hi Dmitry, Thanks! Jerry Gerald, Looks good for me. -Dmitry On 2016-06-10 19:16, Gerald Thornbrugh wrote: Hi Everyone, I have address Erik's, Dmitry's and David's concerns in a new webrev: Bug: https://bugs.openjdk.java.net/browse/JDK-8144278 JDK Webrev: http://cr.o

Re: RFR 8144278 [TESTBUG] hotspot/runtime/StackGuardPages/testme.sh should use native library build support

2016-06-10 Thread Gerald Thornbrugh
Hi Everyone, I have address Erik's, Dmitry's and David's concerns in a new webrev: Bug: https://bugs.openjdk.java.net/browse/JDK-8144278 JDK Webrev: http://cr.openjdk.java.net/~gthornbr/8144278/jdk-webrev.01/ Hotspot Webrev: ht

Re: RFR 8144278 [TESTBUG] hotspot/runtime/StackGuardPages/testme.sh should use native library build support

2016-06-02 Thread Gerald Thornbrugh
Hi David, Hi Jerry, Some additional comments to those you are already working on ... On 3/06/2016 1:28 AM, Gerald Thornbrugh wrote: Hi Everyone, Please review my changes to address JDK-8144278. Bug: https://bugs.openjdk.java.net/browse/JDK-8144278 JDK Webrev: http://cr.openjdk.java.net

Re: RFR 8144278 [TESTBUG] hotspot/runtime/StackGuardPages/testme.sh should use native library build support

2016-06-02 Thread Gerald Thornbrugh
e etc) parameters error from other kind of errors. It's where exit(7) comes from in this test. So it might be better to use exit(1) if (retval < 0) -Dmitry On 2016-06-02 19:25, Gerald Thornbrugh wrote: Hi Dmitry, I will discuss the disabling of optimization with Erik Joelsson and g

Re: RFR 8144278 [TESTBUG] hotspot/runtime/StackGuardPages/testme.sh should use native library build support

2016-06-02 Thread Gerald Thornbrugh
LOW as the default. If this particular test needs to be compiled without optimizations, it can be configured by adding this declaration in JtregNative.gmk: BUILD_HOTSPOT_JTREG_EXECUTABLES_OPTIMIZATION_exeinvoke := NONE /Erik On 2016-06-02 18:25, Gerald Thornbrugh wrote: Hi Dmitry, I will d

Re: RFR 8144278 [TESTBUG] hotspot/runtime/StackGuardPages/testme.sh should use native library build support

2016-06-02 Thread Gerald Thornbrugh
s return value. > > > 295: Please change usage() to return value 7 rather than call exit and > change this line to > > return usage(); > > to avoid unreachable statements. > > -Dmitry > > On 2016-06-02 18:28, Gerald Thornbrugh wrote: >>

RFR 8144278 [TESTBUG] hotspot/runtime/StackGuardPages/testme.sh should use native library build support

2016-06-02 Thread Gerald Thornbrugh
Hi Everyone, Please review my changes to address JDK-8144278. Bug: https://bugs.openjdk.java.net/browse/JDK-8144278 JDK Webrev: http://cr.openjdk.java.net/~gthornbr/8144278/jdk-webrev.00/ Hotspot Webrev: http://cr.openjdk.java.

Re: Questions about including a library for a JTREG native test being built in JPRT

2016-05-17 Thread Gerald Thornbrugh
ks for you. /Erik On 2016-05-17 15:26, Gerald Thornbrugh wrote: Hi Everyone I am trying to fix JDK-8144278 which is a bug to convert a "c" source file test from being built at test run time to being built and included in the test bundle. The test relies on the "jvm" library to

Questions about including a library for a JTREG native test being built in JPRT

2016-05-17 Thread Gerald Thornbrugh
Hi Everyone I am trying to fix JDK-8144278 which is a bug to convert a "c" source file test from being built at test run time to being built and included in the test bundle. The test relies on the "jvm" library to call JVM functions from a "c" program. Here are my changes to JtregNative.gmk:

Re: code review round 0 for MacOS X FDS whitespace/indent fixes (8027117)

2013-10-23 Thread Gerald Thornbrugh
Hi Dan, Thanks for the explanation. Jerry Jerry, Thanks for the fast review! On 10/23/13 2:41 PM, Gerald Thornbrugh wrote: Hi Dan, Your changes look good but I have a question. On source files that do not have an Oracle copyright like generated-configure.sh is the correct method to

Re: code review round 0 for MacOS X FDS whitespace/indent fixes (8027117)

2013-10-23 Thread Gerald Thornbrugh
Hi Dan, Your changes look good but I have a question. On source files that do not have an Oracle copyright like generated-configure.sh is the correct method to leave the copyright as it is? Thanks! Jerry - Original Message - From: daniel.daughe...@oracle.com To: hotspot-runtime-...@op