Re: RFR (XXS) 8233422 : Extra space in the title of the HTML javadoc page

2019-11-04 Thread Ivan Gerasimov
-folk, This one's for you. -- Jon On 11/1/19 4:24 PM, Ivan Gerasimov wrote: Hello! Every javadoc HTML page has a title, which includes the product and the version information. For example, for the page [1] it is "String (Java 13 SE & JDK 13 )" [1] https://docs.oracle.com/en/

Re: RFR 9: 8074818: Resolve disabled warnings for libjava

2015-05-21 Thread Ivan Gerasimov
Hi Roger On 22.05.2015 0:09, Roger Riggs wrote: Please review these native code and build changes to clear compilation warnings. Most are due to mixing unsigned types with signed types or providing the correct type to an invoked function. The code changes look good! Webrev: http://bussund04

Re: RFR: [8038961] kinit, klist and ktab aren't built from jdk7u51 in licensee src bundles

2014-04-28 Thread Ivan Gerasimov
Thanks Erik! On 28.04.2014 17:12, Erik Joelsson wrote: Hello Ivan, The change looks good to me, but I'm not a reviewer for 7u. No problem, I'll wait for one :) Thank you anyway. Sincerely yours, Ivan /Erik On 2014-04-28 14:45, Ivan Gerasimov wrote: Ping. Could someone p

Re: RFR: [8038961] kinit, klist and ktab aren't built from jdk7u51 in licensee src bundles

2014-04-28 Thread Ivan Gerasimov
r the licensee bundle, the kerberoes tools for windows are now created. Any comments/suggestions? Sincerely yours, Ivan On 21.04.2014 22:43, Ivan Gerasimov wrote: Hello! This is a 7u only issue. I was reported that kerberos tools aren't built from the licensee source bundle. The cau

RFR: [8038961] kinit, klist and ktab aren't built from jdk7u51 in licensee src bundles

2014-04-21 Thread Ivan Gerasimov
Hello! This is a 7u only issue. I was reported that kerberos tools aren't built from the licensee source bundle. The cause is that building of the launchers is started from the 'build' target in the Makefile. On Windows, the 'build' target is only defined, if ./common/Library.gmk is included,

make dist-clean should remove javacservers directory

2013-08-01 Thread Ivan Gerasimov
Hello! When sjavac is enabled, configure creates $OUTPUT_ROOT/javacservers directory. However, make dist-clean doesn't remove it. Please find a simple fix below. Sincerely yours, Ivan diff --git a/common/makefiles/Main.gmk b/common/makefiles/Main.gmk --- a/common/makefiles/Main.gmk +++ b/co