On Thu, 20 Jan 2022 19:03:36 GMT, Joe Darcy wrote:
> Update of JDK 18 symbol information for build 32.
>
> @lahodaj , can you take a look at the diff? Given the code changes for
> JDK-8270416: "Enhance construction of Identity maps"
> (https://github.com/openjdk/jdk/commit/5832a3440489d0967dc3
On Tue, 30 Nov 2021 10:46:12 GMT, Adam Sotona wrote:
> make/jdk/src/classes/build/tools/depend/Depend.java method toString(byte[])
> constructs hex string out of the given byte array.
> Actual implementation is using custom conversion code, which does not pad
> byte values <16 with leading zero
While working on JDK-8277105[1], it turned out the historical data in `ct.sym`
are not quite right in two directions:
a) some API classes extend classes from non-exported packages (often from the
`java.base` module). Examples include `jdk.jfr.Event` which extends
`jdk.internal.event.Event`. As t
On Sun, 18 Jul 2021 19:33:20 GMT, Joe Darcy wrote:
> Usual kind of updates for the symbol information in JDK 18 to reflect
> changes in the JDK 17 API. Bug fixes with API changes since JDK 17 b28
> include JDK-8266313, JDK-8268972, and JDK-8266269.
Looks good, thanks!
-
Marked a
On Fri, 11 Jun 2021 13:09:55 GMT, Jan Lahoda wrote:
> [this is an improved version of openjdk/jdk PR:
> https://github.com/openjdk/jdk/pull/4428
> ]
>
> The ct.sym may contain classfiles referring to annotations that are not
> present in ct.sym (liek JDK
darcy, we also need a special handling of ValueBased, which
> this patch should do, so it also solves
> https://bugs.openjdk.java.net/browse/JDK-8258421
Jan Lahoda has updated the pull request incrementally with one additional
commit since the last revision:
Fixing typo.
-
On Fri, 11 Jun 2021 21:06:41 GMT, Joe Darcy wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six addi
darcy, we also need a special handling of ValueBased, which
> this patch should do, so it also solves
> https://bugs.openjdk.java.net/browse/JDK-8258421
Jan Lahoda has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelat
[this is an improved version of openjdk/jdk PR:
https://github.com/openjdk/jdk/pull/4428
]
The ct.sym may contain classfiles referring to annotations that are not present
in ct.sym (liek JDK's internal annotation sun.misc.Contended). If javac will
try to load them (while discovering annotations
On Wed, 9 Jun 2021 11:05:37 GMT, Jan Lahoda wrote:
> The ct.sym may contain classfiles referring to annotations that are not
> present in ct.sym (liek JDK's internal annotation `sun.misc.Contended`). If
> javac will try to load them (while discovering annotations for
On Thu, 10 Jun 2021 21:38:28 GMT, Joe Darcy wrote:
> Does jdk.internal.ValueBased also need special handling? See JDK-8258421.
@jddarcy, you are right, there needs to be special handling for it.
I have created a new PR for JDK 17 here:
https://github.com/openjdk/jdk17/pull/27
It should also in
On Thu, 10 Jun 2021 15:28:16 GMT, Vicente Romero wrote:
>> The ct.sym may contain classfiles referring to annotations that are not
>> present in ct.sym (liek JDK's internal annotation `sun.misc.Contended`). If
>> javac will try to load them (while discovering annotations for the purpose
>> of
On Wed, 9 Jun 2021 12:13:20 GMT, Alan Bateman wrote:
> Seems to be linked to the wrong issue, the issue you want is JDK-8266036.
Yes, sorry for the wrong issue. Fixed now.
Thanks for noticing!
-
PR: https://git.openjdk.java.net/jdk/pull/4428
The ct.sym may contain classfiles referring to annotations that are not present
in ct.sym (liek JDK's internal annotation `sun.misc.Contended`). If javac will
try to load them (while discovering annotations for the purpose of detecting
which annotation processors should be run), an error will be
On Tue, 4 May 2021 16:41:44 GMT, Jan Lahoda wrote:
> This is a preview of a patch implementing JEP 406: Pattern Matching for
> switch (Preview):
> https://bugs.openjdk.java.net/browse/JDK-8213076
>
> The current draft of the specification is here:
> http://cr.openjdk.java.ne
On Fri, 4 Jun 2021 18:23:28 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing typo.
>
> test/langtools/tools/javac/patterns/SealedTypeChanges.java line 71:
>
On Fri, 4 Jun 2021 15:46:32 GMT, Paul Sandoz wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing typo.
>
> test/langtools/tools/javac/patterns/DisambiguateParenthesizedPat
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdi
On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>>
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdi
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdi
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdiff.prev
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdi
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdi
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdiff
On Thu, 27 May 2021 10:38:08 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Post-merge fix - need to include jdk.internal.javac in the l
On Thu, 27 May 2021 18:28:13 GMT, Evgeny Mandrikov wrote:
>>> > I've updated the code to produce better/more useful LineNumberTable for
>>> > rule switches.
>>>
>>> @lahodaj I re-tested previous example and tested few others. Now everything
>>> seems to be good with `LineNumberTable` entries +
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdi
On Wed, 26 May 2021 17:52:36 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>>
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdiff.prev
On Tue, 25 May 2021 16:00:43 GMT, Rémi Forax wrote:
> > The reason for this integer (which is not a constant in the case of this
> > switch) is to restart the matching in case guards fail to "match".
> > Considering the example here:
> > ```
> > class Example {
> > void example(Object o
On Tue, 25 May 2021 14:13:55 GMT, Rémi Forax wrote:
> > Thanks Evgeny, I'll take a look.
> > @forax, do you mean why there is "0" in:
> > 11: invokedynamic #13, 0
> > ?
>
> Not this one, the one on the stack.
>
> 7: iconst_0 < this zero
> 8: istore_3
> 9: aload_2
> 10: iload_3
> 11: invoked
On Wed, 19 May 2021 08:00:12 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>>
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdi
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdi
On Tue, 4 May 2021 20:48:34 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Reflecting recent spec changes.
>> - Reflecting review comments.
>&
null`/`case null, String s`/`case
> null: case String s:`/`case String s: case null:`, handling of these required
> a few tricks in `Attr`, `Flow` and `TransPatterns`.
>
> The specdiff for the change is here (to be updated):
> http://cr.openjdk.java.net/~jlahoda/8265981/specdiff
On Tue, 4 May 2021 20:48:34 GMT, Maurizio Cimadamore
wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~g
This is a preview of a patch implementing JEP 406: Pattern Matching for switch
(Preview):
https://bugs.openjdk.java.net/browse/JDK-8213076
The current draft of the specification is here:
http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html
A summary of notab
On Sun, 2 May 2021 02:10:26 GMT, Vicente Romero wrote:
>> Please review this PR that intents to make sealed classes a final feature in
>> Java. This PR contains compiler and VM changes. In line with similar PRs,
>> which has made preview features final, this one is mostly removing preview
>> r
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote:
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc behavior to more closely adhere
> to JEP 12.
>
> The notable changes are:
>
> * adding sup
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk.ja
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk
On Fri, 8 Jan 2021 01:51:52 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 57 commits:
>>
>> - Fixing tests after a merge.
>> - Merging master into JD
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk.ja
On Wed, 9 Dec 2020 13:30:14 GMT, Magnus Ihse Bursie wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 55 commits:
>>
>> - Merging recent master changes into JDK-8250768
>> - Fi
On Fri, 27 Nov 2020 13:21:15 GMT, Jan Lahoda wrote:
> Adding support for record classes in the historical data for ct.sym. This
> includes a few changes not strictly needed for the change:
> -updating and moving tests into test/langtools, so that it is easier to run
> them.
>
ader (used for tests, but
> seems like the proper thing to do anyway).
> -fixing the -Xprint annotation processor to print record component
> annotations.
>
> Changes to jdk.jdeps' classfile library are needed so that the ct.sym
> creation works.
Jan Lahoda has updated
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk.ja
On Mon, 7 Dec 2020 19:38:41 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains eight a
On Sat, 5 Dec 2020 03:17:56 GMT, Mikael Vidstedt wrote:
>> Start of JDK 17 updates.
>
> Marked as reviewed by mikael (Reviewer).
The langtools changes look fine to me. There were additions/changes to jcod
files under `test/hotspot/jtreg/runtime/sealedClasses/` made under JDK-8246778,
so these
On Tue, 1 Dec 2020 12:06:25 GMT, Jan Lahoda wrote:
>> test/langtools/tools/javac/platform/createsymbols/CreateSymbolsTestImpl.java
>> line 513:
>>
>>> 511: public java.util.List
>>> l();
>>&
ader (used for tests, but
> seems like the proper thing to do anyway).
> -fixing the -Xprint annotation processor to print record component
> annotations.
>
> Changes to jdk.jdeps' classfile library are needed so that the ct.sym
> creation works.
Jan Lahoda has upda
On Tue, 1 Dec 2020 02:18:18 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests on Windows - normalizing line endings.
>
> Looks mostly OK; some minor co
On Tue, 1 Dec 2020 01:43:47 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests on Windows - normalizing line endings.
>
> test/langtools/tool
ader (used for tests, but
> seems like the proper thing to do anyway).
> -fixing the -Xprint annotation processor to print record component
> annotations.
>
> Changes to jdk.jdeps' classfile library are needed so that the ct.sym
> creation works.
Jan Lahoda has upda
ader (used for tests, but
> seems like the proper thing to do anyway).
> -fixing the -Xprint annotation processor to print record component
> annotations.
>
> Changes to jdk.jdeps' classfile library are needed so that the ct.sym
> creation works.
Jan Lahoda has upda
On Mon, 30 Nov 2020 12:17:46 GMT, Chris Hegarty wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests on Windows - normalizing line endings.
>
> make/langtools/src/class
ader (used for tests, but
> seems like the proper thing to do anyway).
> -fixing the -Xprint annotation processor to print record component
> annotations.
>
> Changes to jdk.jdeps' classfile library are needed so that the ct.sym
> creation works.
Jan Lahoda has upda
Adding support for record classes in the historical data for ct.sym. This
includes a few changes not strictly needed for the change:
-updating and moving tests into test/langtools, so that it is easier to run
them.
-fixing Record attribute reading in javac's ClassReader (used for tests, but
seem
On Tue, 24 Nov 2020 09:59:44 GMT, Chris Hegarty wrote:
> The `Depend` build tool creates a hash of a module's API elements, so that it
> can determine if downstream modules require recompilation. The build tool
> fails (throws an exception) when it encounters an "unknown" record
> attribute/co
o go to the Preview
> page, the word DEPRECATED is highlighted in the top navbar instead of
> PREVIEW.
>
> -- Jon
>
>
> On 11/5/20 10:13 AM, mlbridge[bot] wrote:
>>
>> /Mailing list message from Alex Buckley
>> <mailto:alex.buck...@oracle.com> on
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openj
On Wed, 4 Nov 2020 19:40:33 GMT, Jan Lahoda wrote:
>> I have read all the files.
>>
>> I have added a n umber of various minor non-blocking comments (no need for
>> re-review( to fix these. But I have a couple of comments/questions before
>> finally giving app
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk.ja
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk.ja
On Mon, 2 Nov 2020 20:21:44 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk.ja
On Mon, 2 Nov 2020 19:59:10 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK
On Mon, 2 Nov 2020 19:41:08 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK
On Mon, 2 Nov 2020 19:37:39 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK
On Mon, 2 Nov 2020 18:39:59 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk.ja
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk.ja
On Fri, 23 Oct 2020 18:19:13 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing unnecessary cast.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/d
On Tue, 27 Oct 2020 16:11:18 GMT, Jan Lahoda wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java
>> line 2980:
>>
>>> 2978: }
>>> 2979:
>>> 2980: public enum DeclarationPreviewLanguageFeatures {
&
On Fri, 23 Oct 2020 17:58:42 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing unnecessary cast.
>
> src/jdk.javadoc/share/classes/jdk/javadoc
On Fri, 23 Oct 2020 18:28:12 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing unnecessary cast.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/t
On Fri, 23 Oct 2020 17:22:33 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing unnecessary cast.
>
> src/jdk.javadoc/share/classes/jdk/javadoc
On Wed, 21 Oct 2020 15:25:59 GMT, Hannes Wallnöfer wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 35 commits:
>>
>> - Merge branch 'JDK-8250768-dev' of https://github.co
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk
ahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5] http://cr.openjdk.java.net/~jlahoda/8250768/test.javadoc.00/
> [6] https://bugs.openjdk.
On Fri, 16 Oct 2020 16:47:25 GMT, Erik Joelsson wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains 35 commits:
>> - Merge branch 'JDK-8250768-dev' of https://github.co
t;
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
> [4]
> http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.00/api/preview-list.html
> [5]
> http://cr.openjdk.java.net/~jlahoda/8250768/
On Mon, 19 Oct 2020 14:22:17 GMT, Hannes Wallnöfer wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
>> line 2238:
>>
>>> 2236: if (previewTree != null) {
>>> 2237: previewDiv.add(new
>>> HtmlTree(TagName.A).put(
This is an update to javac and javadoc, to introduce support for Preview APIs,
and generally improve javac and javadoc
behavior to more closely adhere to JEP 12.
The notable changes are:
* adding support for Preview APIs (javac until now supported primarily only
preview language features, and
This is the current proposed patch for the upcoming JEP 394, for pattern
matching for instanceof.
A summary of changes:
-making the feature permanent (non-preview)
-making the binding variables non-final (as per current specification proposal)
-producing a compile-time error for the case where th
On Tue, 15 Sep 2020 09:10:54 GMT, Hannes Wallnöfer wrote:
> This pull request is identical with the RFR previously sent for the Mercurial
> repository:
>
> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
>
> I'm copy-pasting the comments from the original RFR below.
Looks good to me.
Jan
On 24. 07. 20 23:38, Joe Darcy wrote:
Hello,
The fix for JDK-8248476 in JDK 15 b33 changed the symbol information
used to represent --release 15 in JDK 16.
Please review the change to update the info:
http://cr.openjdk.java.net/~darcy/8249219.0/
Patch below; tha
Looks good to me. (A new innerclass entry was added for
java/security/Provider$Service, and the current format sadly needs to
restate the whole class header, including all innerclass entries for any
change to the header.)
Jan
On 30. 06. 20 23:58, Joe Darcy wrote:
Hello,
Please review a smal
a.net/~jlahoda/8244763/webrev.01-data/
I believe the data patch is reviewed, and is not controversial. Please
let me know if you see any issues with this split.
Thanks,
Jan
On 01. 06. 20 10:07, Jan Lahoda wrote:
Further testing revealed some issues with the patch, especially:
-use of un-en
ttp://cr.openjdk.java.net/~jlahoda/8244763/webrev.01-create-symbols/
Does this look OK?
Thanks!
Jan
On 28. 05. 20 16:47, Jonathan Gibbons wrote:
Looks good to me.
-- Jon
On 5/18/20 9:36 AM, Jan Lahoda wrote:
I apologize, I used a wrong patch for the "data" webrev. The "class
name java/u
MAX_RADIX is 36, so this is about 20 more releases, i.e. about 10 years
from now.
Jan
On 29. 05. 20 8:59, Magnus Ihse Bursie wrote:
On 2020-05-28 23:51, Joe Darcy wrote:
Hello,
The start of JDK 16 is right around the corner with JDK 15 forking off
from jdk/jdk at ramp down 1 [1].
Please
ass innerClass java/lang/invoke/MethodHandles$Lookup outerClass
---end---
but this may not be correct upon further contemplation.
Anyway, I approve the MR3 (ALPN/PSS) entries, but did not review the
symbol creation code.
Brad
On 5/18/2020 7:55 AM, Jan Lahoda wrote:
Hi,
Some new APIs hav
Hi,
The langtools-specific ant build for NetBeans appears to be broken after
JDK-8244093:
---
$ ant -f make/ide/netbeans/langtools/build.xml
-Dlangtools.jdk.home=$PWD/build/linux-x86_64-server-release/jdk/ build
Buildfile: /home/jlahoda/src/jdk/jdk/make/ide/netbeans/langtools/build.xml
BUILD
the correct data is here:
http://cr.openjdk.java.net/~jlahoda/8244763/webrev.01-data/
The only change is the above difference in order of entries in
Attributes$Name.
Sorry for trouble.
Jan
On 18. 05. 20 16:55, Jan Lahoda wrote:
Hi,
Some new APIs have been introduced in JSR 337 MR3 (JDK 8). W
Hi,
Some new APIs have been introduced in JSR 337 MR3 (JDK 8). We should
update the historical data for JDK 8 with these new APIs.
As this was the first time we need to update data for a release that
other release data use as a baseline, it was necessary to improve the
CreateSymbols tool a l
t -
that would probably make testing reproducible builds much easier.
How does this look?
Thanks,
Jan
On 07. 05. 20 17:48, Magnus Ihse Bursie wrote:
On 2020-04-30 14:50, Jan Lahoda wrote:
On 30. 04. 20 14:29, Magnus Ihse Bursie wrote:
On 2020-04-30 12:41, Alan Bateman wrote:
On 30/04/
t relevant.
Good idea. I've tried to do that, and also fixed some bugs in the AST
hashing, and enhanced tests.
All is still on "jlahoda-depend-in-module" branch in jdk/sandbox.
Jan
-- Jon
On 5/6/20 9:49 AM, Jan Lahoda wrote:
Hi Jon,
Good question. I was first experiment
1 - 100 of 171 matches
Mail list logo