On Thu, 11 Nov 2021 05:52:18 GMT, Jayathirth D V wrote:
> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
> any deployment target when when we use xcrun to create .air file and t
On Mon, 15 Nov 2021 14:33:21 GMT, Magnus Ihse Bursie wrote:
> Looks good to me also. Please let Phil have a say as well before integrating.
Thanks Magnus for the review. Yes i have already Re-Requested review from Phil
on latest patch.
Also i am waiting on Vitaly(JBS submitter) to verify the la
On Mon, 15 Nov 2021 13:46:29 GMT, Kevin Rushforth wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use 10.14 macOS version
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line
On Mon, 15 Nov 2021 13:28:30 GMT, Kevin Rushforth wrote:
> The JDK itself has a minimum version of 11.0 on macOS aarch64 systems
> (because apple only supports it on macOS >= 11), so it probably doesn't
> matter much. You might wish to file a low-priority follow-up issue to change
> the runtim
ther we should keep 10.12.00 or 10.13/14 is open to discussion for metal
> pipeline.
>
> SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter)
> has confirmed that patch resolves the issue.
Jayathirth D V has updated the pull request incrementally wit
ther we should keep 10.12.00 or 10.13/14 is open to discussion for metal
> pipeline.
>
> SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter)
> has confirmed that patch resolves the issue.
Jayathirth D V has updated the pull request incrementally with one
On Mon, 15 Nov 2021 05:46:30 GMT, Jayathirth D V wrote:
> " Also note that on aarch64 the global value is 11.00.00, and in that case we
> should use the global value."
>
> I have no idea what happens if you specify 10.14 to the metal compiler on
> aarch64 Somethi
On Fri, 12 Nov 2021 20:27:32 GMT, Phil Race wrote:
> " Also note that on aarch64 the global value is 11.00.00, and in that case we
> should use the global value."
>
> I have no idea what happens if you specify 10.14 to the metal compiler on
> aarch64 Something else to check although probably t
On Fri, 12 Nov 2021 03:59:52 GMT, Phil Race wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 850:
>>
>>> 848: COMMAND := $(METAL) -c -std=osx-metal2.0 \
>>> 849: -mmacosx-version-min=$(MACOSX_VERSION_MIN) \
>>> 850: -o $(SHADERS_AIR) $(SHADERS_SRC), \
>>
On Thu, 11 Nov 2021 13:53:05 GMT, Magnus Ihse Bursie wrote:
> Also, if you did not create this patch yourself, please make sure to use
> `/contributor` to give proper credits. Or maybe you mean that Vitaly
> submitted the bug report, not the patch?
By Submitter i meant submitter of bug in JBS.
ther we should keep 10.12.00 or 10.13/14 is open to discussion for metal
> pipeline.
>
> SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter)
> has confirmed that patch resolves the issue.
Jayathirth D V has updated the pull request incrementally with one
On Thu, 11 Nov 2021 13:52:13 GMT, Magnus Ihse Bursie wrote:
> We should not hard-code version numbers like that.
>
> Fortunately for you, there already exists a variable $(MACOSX_VERSION_MIN)
> that you can use.
Thanks for the review i have updated code to use the Macro.
-
PR: ht
When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set any
deployment target when when we use xcrun to create .air file and this issue
looks similar to https://developer.apple.com/forums/thread/105719.
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal API
> On 12-Mar-2021, at 10:30 AM, Sergey Bylokhov wrote:
>
> On Fri, 12 Mar 2021 00:09:54 GMT, Kevin Rushforth wrote:
>
>>> Ajit Ghaisas has updated the pull request with a new target base due to a
>>> merge or a rebase. The incremental webrev excludes the unrelated changes
>>> brought in by
> On 12-Mar-2021, at 9:29 AM, Scott Palmer wrote:
>
>
>> On Mar 11, 2021, at 9:53 PM, Sergey Bylokhov wrote:
>>
>> On Fri, 12 Mar 2021 02:29:04 GMT, Jayathirth D V wrote:
>>
>>>> src/java.desktop/macosx/classes/sun/java2d/metal/MTLSur
On Fri, 12 Mar 2021 00:42:35 GMT, Sergey Bylokhov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 47 additional
>> commit
On Thu, 11 Feb 2021 05:41:15 GMT, Ajit Ghaisas wrote:
>> According to Xcode Instruments leak profile, there are 2 minor memory leaks
>> in the Metal rendering pipeline:
>>
>> `#1 Malloc 80 Bytes 1 0x7fde0d4247b0 80 Byteslibjava.dylib
>> getStringUTF8`
>>0 libsystem_malloc
On Mon, 8 Feb 2021 18:05:02 GMT, Gerard Ziemski wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> src/java.desktop/macosx/classes/sun/java2d/metal/MTLRenderQueue.java line 97:
>
On Tue, 15 Sep 2020 22:18:09 GMT, Kevin Rushforth wrote:
> This adds the following extensions to the list of source files that git
> jcheck will check for whitespace errors:
>
> .cc, .hh, .m, .mm
>
> All files with the above extensions are now white-space clean after the fix
> for
> [JDK-824
20 matches
Mail list logo
