Integrated: Merge jdk18

2022-01-17 Thread Jesper Wilhelmsson
On Tue, 18 Jan 2022 01:13:45 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 39f140a2 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/39f140a20120300074167597580f9be34e812cad Stats:

Integrated: Merge jdk18

2022-01-04 Thread Jesper Wilhelmsson
On Tue, 4 Jan 2022 18:37:53 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 191f7307 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/191f7307bb2f2e2ce93480b4fc5fbbef216ff7cd Stats:

RFR: Merge jdk18

2022-01-04 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge remote-tracking branch 'jdk18/master' into Merge_jdk18 - 8275830: C2: Receiver downcast is missing when inlining through method handle linkers - 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value

Integrated: Merge jdk18

2021-12-23 Thread Jesper Wilhelmsson
On Thu, 23 Dec 2021 17:11:15 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: a3b1c6b0 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/a3b1c6b03600da21b00a1f37ea4712096d636b14 Stats:

Re: RFR: Merge jdk18 [v2]

2021-12-23 Thread Jesper Wilhelmsson
> Forwardport JDK 18 -> JDK 19 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 113 commits: - Merge - 8279115: Fix internal doc comment errors. Reviewed-by: mli - 8276302: Locale.filterTags methods

RFR: Merge jdk18

2021-12-23 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge - 8279204: [BACKOUT] JDK-8278413: C2 crash when allocating array of size too large - 8268297: jdk/jfr/api/consumer/streaming/TestLatestEvent.java times out - 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0 -

Integrated: Merge jdk18

2021-12-22 Thread Jesper Wilhelmsson
On Wed, 22 Dec 2021 16:03:43 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: f1fbba23 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/f1fbba23ebdb28a32977241f8e85b60e10878cbc Stats:

Re: RFR: Merge jdk18 [v2]

2021-12-22 Thread Jesper Wilhelmsson
> Forwardport JDK 18 -> JDK 19 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 104 commits: - Merge - 8279063: Consolidate push and push_if_necessary in PreservedMarks Reviewed-by: rkennke, mli, ts

RFR: Merge jdk18

2021-12-22 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge - 8274315: JFR: One closed state per file or stream - 8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters - 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION

Integrated: Merge jdk17

2021-08-02 Thread Jesper Wilhelmsson
On Mon, 2 Aug 2021 23:30:55 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: c8add223 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/c8add223a10030e40ccef42e081fd0d8f00e0593 Stats:

Re: RFR: Merge jdk17 [v2]

2021-08-02 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Revert "8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34)" Thi

RFR: Merge jdk17

2021-08-02 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8067223: [TESTBUG] Rename Whitebox API package - 8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34) The webrevs contain the adjustments done while merging with regards to

Integrated: Merge jdk17

2021-07-14 Thread Jesper Wilhelmsson
On Wed, 14 Jul 2021 21:35:34 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 7d0edb57 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/7d0edb5743aacfc22f76ee8aa7b03d7dc0f90dca Stats:

RFR: Merge jdk17

2021-07-14 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848 - 8266313: (JEP-356) - RandomGenerator spec implementation requirements tightly coupled to JDK internal classes - 8270075: SplittableRandom extends

Integrated: Merge jdk17

2021-07-13 Thread Jesper Wilhelmsson
On Wed, 14 Jul 2021 00:13:41 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 4a7ccf36 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/4a7ccf36e9a3978c437db3efe892dd23e8a0b772 Stats:

RFR: Merge jdk17

2021-07-13 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE - 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for lambdas - 8269281: java/foreign/Test{Down,Up}call.java time out - 8269635: Stress

Re: RFR: Merge jdk17 [v2]

2021-07-07 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 180 commits: - Merge - 8264735: Make dynamic dump repeatable Reviewed-by: ccheung, iklam - 8269481: SctpMultiChannel

Integrated: Merge jdk17

2021-07-07 Thread Jesper Wilhelmsson
On Thu, 8 Jul 2021 00:01:43 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 270fbcb3 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/270fbcb3f5755baf045fa6dec3fba459d32c32e1 Stats:

RFR: Merge jdk17

2021-07-07 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for unexpected output - 8269185: Directories in /opt/runtimepackagetest and /path/to/jdk-17 are different - 8269879: [PPC64] C2: Math.rint intrinsic uses

Integrated: Merge jdk17

2021-06-27 Thread Jesper Wilhelmsson
On Sun, 27 Jun 2021 23:05:10 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: a29953d8 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/a29953d805ac6360bcfe005bcefa60e112788494 Stats:

RFR: Merge jdk17

2021-06-27 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8258746: illegal access to global field _jvmci_old_thread_counters by terminated thread causes crash - 8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component

Withdrawn: Merge jdk17

2021-06-27 Thread Jesper Wilhelmsson
On Thu, 24 Jun 2021 00:36:38 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/4579

RFR: Merge jdk17

2021-06-23 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8266854: LibraryCallKit::inline_preconditions_checkIndex modifies control flow even if the intrinsic bailed out - 8254571: Erroneous generic type inference in a lambda expression with a checked exception - 8269125: Klass

Integrated: Merge jdk17

2021-06-21 Thread Jesper Wilhelmsson
On Mon, 21 Jun 2021 22:03:59 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 0458113c Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/0458113c6b1cf500ffdf049c1e3a698b16ce12ce Stats:

Re: RFR: Merge jdk17 [v2]

2021-06-21 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 52 commits: - Merge - 8268458: Add verification type for evacuation failures Reviewed-by: kbarrett, iwalulya - 8

RFR: Merge jdk17

2021-06-21 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop or out of both loops only - 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh native thread fails - 8268362: [REDO] C2

Integrated: Merge jdk17

2021-06-16 Thread Jesper Wilhelmsson
On Thu, 17 Jun 2021 00:49:27 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 3637e50b Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/3637e50b30e92538510c1a8e8893cedc3bd4ccd5 Stats:

Re: RFR: Merge jdk17 [v2]

2021-06-16 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 35 additional commits since the last re

RFR: Merge jdk17

2021-06-16 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8260194: Update the documentation for -Xcheck:jni - 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC - 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on

Integrated: Merge jdk17

2021-06-15 Thread Jesper Wilhelmsson
On Tue, 15 Jun 2021 21:51:33 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: e0f6f70d Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/e0f6f70d3f9e748d2bc53f371beca487e9343d4a Stats:

Re: RFR: Merge jdk17 [v2]

2021-06-15 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 25 additional commits since the last re

RFR: Merge jdk17

2021-06-15 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge jdk17 - 8268768: idea.sh has been updated in surprising and incompatible ways - 8268828: ProblemList compiler/intrinsics/VectorizedMismatchTest.java on win-x64 - 8268723: Problem list SA core file tests on OSX when using

Integrated: Merge jdk16

2021-02-03 Thread Jesper Wilhelmsson
On Thu, 4 Feb 2021 01:17:48 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 16 -> JDK 17 This pull request has now been integrated. Changeset: 9b7a8f19 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/9b7a8f19 Stats: 2645 lines in 56 files changed

RFR: Merge jdk16

2021-02-03 Thread Jesper Wilhelmsson
Forwardport JDK 16 -> JDK 17 - Commit messages: - Merge - 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35) - 8260704: ParallelGC: oldgen expansion needs release-store for _end - 8260927: StringBuilder::insert is incorrect

[jdk16] Integrated: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

2021-02-02 Thread Jesper Wilhelmsson
On Tue, 2 Feb 2021 18:17:55 GMT, Jesper Wilhelmsson wrote: > We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to > remove the EA from version string for this build (b35) and going forward. > > Pushing this for @pashh This pull request has now bee

[jdk16] RFR: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

2021-02-02 Thread Jesper Wilhelmsson
We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to remove the EA from version string for this build (b35) and going forward. Pushing this for @pashh - Commit messages: - Remove ea Changes: https://git.openjdk.java.net/jdk16/pull/146/files Webrev:

Integrated: Merge jdk16

2021-01-11 Thread Jesper Wilhelmsson
On Mon, 11 Jan 2021 22:04:16 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 16 -> JDK 17 This pull request has now been integrated. Changeset: b378f54d Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/b378f54d Stats: 139 lines in 12 files change

Re: RFR: Merge jdk16 [v2]

2021-01-11 Thread Jesper Wilhelmsson
> Forwardport JDK 16 -> JDK 17 Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Merge - Changes: - all: https://git.openjdk.java.net/jdk/pull/2040/files - new: https://git.openjdk.java.net/jdk/pull/2040

RFR: Merge jdk16

2021-01-11 Thread Jesper Wilhelmsson
Forwardport JDK 16 -> JDK 17 - Commit messages: - Merge - 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing - 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl - 8259043: More Zero architectures need linkage with

Integrated: Merge jdk16

2021-01-07 Thread Jesper Wilhelmsson
Forwardport JDK 16 -> JDK 17 - Commit messages: - Merge - 8258484: AIX build fails in Harfbuzz with XLC 16.01..0006 - 8039278: console.sh failed Automatically with exit code 1 - 8258972: unexpected compilation error with generic sealed interface - 8259227: C2 crashes with

Integrated: Merge jdk16

2021-01-07 Thread Jesper Wilhelmsson
On Thu, 7 Jan 2021 23:46:55 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 16 -> JDK 17 This pull request has now been integrated. Changeset: 56a354eb Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/56a354eb Stats: 198 lines in 15 files changed: 1

Integrated: Merge jdk16

2021-01-07 Thread Jesper Wilhelmsson
On Thu, 7 Jan 2021 20:40:49 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 16 -> JDK 17 This pull request has now been integrated. Changeset: 555641ed Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/555641ed Stats: 2957 lines in 68 files change

RFR: Merge jdk16

2021-01-07 Thread Jesper Wilhelmsson
Forwardport JDK 16 -> JDK 17 - Commit messages: - Merge - 8249633: doclint reports missing javadoc for JavaFX property methods that have a property description - 8251200: False positive messages about missing comments for serialization - 8259312: VerifyCACerts.java fails as

Integrated: Merge jdk16

2020-12-17 Thread Jesper Wilhelmsson
On Thu, 17 Dec 2020 20:38:45 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 16 -> JDK 17 This pull request has now been integrated. Changeset: f15528eb Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/f15528eb Stats: 773 lines in 63 files change

Integrated: Merge jdk16

2020-12-17 Thread Jesper Wilhelmsson
Forwardport JDK 16 -> JDK 17 - Commit messages: - Merge - 8247994: Localize javadoc search - 8258515: javac should issue an error if an annotation is nested in a local class or interface - 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter - 8258293:

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

2020-12-07 Thread Jesper Wilhelmsson
On Mon, 7 Dec 2020 19:38:41 GMT, Joe Darcy wrote: >> Start of JDK 17 updates. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains eight

Re: RFR: JDK-8241271 Make hotspot build reproducible

2020-03-23 Thread Jesper Wilhelmsson
Hotspot change looks good, and trivial. /Jesper > On 23 Mar 2020, at 09:45, Magnus Ihse Bursie > wrote: > > On 2020-03-20 14:19, Stefan Karlsson wrote: >> HotSpot changes look good. > > Can I have a second hotspot reviewer on this, or a confirmation that it's > considered trivial? > >

Re: RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

2020-02-04 Thread Jesper Wilhelmsson
Thank you David! /Jesper > On 5 Feb 2020, at 03:37, David Holmes wrote: > > Looks good and trivial. > > Thanks, > David > > On 5/02/2020 12:36 pm, Jesper Wilhelmsson wrote: >> Hi. >> I need a review for this tiny change. >> The "ea" suffix

Re: RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

2020-02-04 Thread Jesper Wilhelmsson
Thank you Tim! /Jesper > On 5 Feb 2020, at 03:40, Tim Bell wrote: > > Jesper: > > Looks good to me as well. > > Tim > > On 2/4/20 6:37 PM, David Holmes wrote: >> Looks good and trivial. >> Thanks, >> David >> On 5/02/2020 12:36 pm, Jesper

RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

2020-02-04 Thread Jesper Wilhelmsson
Hi. I need a review for this tiny change. The "ea" suffix was removed from the JDK 14 version string with JDK-8236092. Since that change is forwardported to jdk/jdk I need to back it out there. This is the backout diff as created by hg backout: diff --git a/make/autoconf/version-numbers

Re: RFR: JDK-8238281 Raise minimum gcc version needed to 5.0

2020-02-04 Thread Jesper Wilhelmsson
Looks good! In a few comments you refer to the version with just the number 5. Would it be more correct to write 5.0? (doc/building.html and doc/building.md) /Jesper > On 4 Feb 2020, at 22:48, Magnus Ihse Bursie > wrote: > > Can I have one more hotspot reviewer, please? > > /Magnus > > On

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-11 Thread jesper . wilhelmsson
Looks good to me. /Jesper > On 11 Jun 2018, at 22:42, Erik Joelsson wrote: > > Hello, > > Based on the discussion here, I have reverted back to something more similar > to webrev.02, but with a few changes. Mainly fixing a bug that caused > JVM_FEATURES_hardened to not actually be the same

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-07 Thread jesper . wilhelmsson
> On 6 Jun 2018, at 06:17, David Holmes wrote: > > Hi Erik, Jesper, > > On 6/06/2018 2:59 AM, jesper.wilhelms...@oracle.com > wrote: >>> On 5 Jun 2018, at 08:10, David Holmes wrote: >>> >>> Sorry to be late to this party ... >>> >>> On 5/06/2018 6:10

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-05 Thread jesper . wilhelmsson
> On 5 Jun 2018, at 08:10, David Holmes wrote: > > Sorry to be late to this party ... > > On 5/06/2018 6:10 AM, Erik Joelsson wrote: >> New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ >> Renamed the new jvm variant to "hardened". > > As it is a hardened server build I'd prefer

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-04 Thread jesper . wilhelmsson
Looks good to me. /Jesper > On 4 Jun 2018, at 22:10, Erik Joelsson wrote: > > New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ > > Renamed the new jvm variant to "hardened". > > /Erik > > > On 2018-06-04 09:54, jesper.wilhelms...@oracle.com wrote: >>> On 4 Jun 2018, at

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

2018-06-04 Thread jesper . wilhelmsson
> On 4 Jun 2018, at 17:52, Erik Joelsson wrote: > > Hello, > > On 2018-06-01 14:00, Aleksey Shipilev wrote: >> On 06/01/2018 10:53 PM, Erik Joelsson wrote: >>> This patch defines flags for disabling speculative execution for GCC and >>> Visual Studio and applies >>> them to all binaries except

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread jesper . wilhelmsson
Looks good! /Jesper > On 14 Feb 2018, at 22:45, sangheon.kim wrote: > > Hi all, > > Could I have some reviews for CMM removal? > This is closed CR but some public codes also need small modifications. This > CR is for removing stuff related to an Oracle JDK

Re: RFR(xs): JDK-8190865 - Require jtreg 4.2 b10

2017-11-07 Thread jesper . wilhelmsson
Thanks! /Jesper > On 7 Nov 2017, at 18:05, Daniel D. Daugherty > wrote: > > Thumbs up! > > Dan > > > On 11/7/17 11:56 AM, jesper.wilhelms...@oracle.com wrote: >> Hi, >> >> Please review this minor change to use the latest jtreg version in HotSpot >> testing.

Re: RFR(xs): JDK-8190865 - Require jtreg 4.2 b10

2017-11-07 Thread jesper . wilhelmsson
Including build-dev. > On 7 Nov 2017, at 17:56, jesper.wilhelms...@oracle.com wrote: > > Hi, > > Please review this minor change to use the latest jtreg version in HotSpot > testing. > This should get rid of the SocketTimeoutExceptions that we currently see in > the HotSpot nightly. > > Bug:

Re: C/C++ IDE support for HotSpot

2017-03-22 Thread jesper . wilhelmsson
Hi, The project in common/nb_native/nbproject does not have a build configuration for Windows. The project itself should still be usable for browsing the code, but it might require some changes to make it build correctly. If you have a NetBeans / SolarisStudio installation on Windows and want

Re: C/C++ IDE support for HotSpot

2017-03-22 Thread jesper . wilhelmsson
Hi, I use the OpenJDK NetBeans project most of the time and am very happy with it. I still think Mikael's initiative is a very good one since I don't believe in forcing developers to use some specific tools, but rather think that we should make the OpenJDK code available to as many developers

Re: RFR: JDK-8028162 - Update Netbeans / Solaris Studio project files

2016-06-29 Thread Jesper Wilhelmsson
platform to it. I can then run the test and step through the JDK code, recompiling using an external make if I need to iterate. Very convenient. What does this Netbeans project file do that I won't get with my current approach? Brad On 6/23/2016 3:55 PM, Jesper Wilhelmsson wrote: Hi, Please

Re: RFR: JDK-8028162 - Update Netbeans / Solaris Studio project files

2016-06-27 Thread Jesper Wilhelmsson
will not affect the product or the build of it directly, I'm fine with this. Consider it reviewed from the build group. /Erik On 2016-06-24 00:55, Jesper Wilhelmsson wrote: Hi, Please review this patch to update the NetBeans project files for JDK 9. Several big changes in the code base (Jigsaw, GC

RFR: JDK-8028162 - Update Netbeans / Solaris Studio project files

2016-06-23 Thread Jesper Wilhelmsson
Hi, Please review this patch to update the NetBeans project files for JDK 9. Several big changes in the code base (Jigsaw, GC restructuring, etc) have made the old NBproject in need of an update. Vladimir Kvashin in the Studio IDE team has kindly helped us to update the project files on all

Re: RFR: 8159364: Gtest unit tests does not support PCH

2016-06-14 Thread Jesper Wilhelmsson
Looks good! /Jesper Den 14/6/16 kl. 11:50, skrev Erik Helin: Hi all, this patch adds support for pre-compiled headers (PCH) to the gtest unit tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8159364 Webrev: http://cr.openjdk.java.net/~ehelin/8159364/00/ Testing: - JPRT Thanks, Erik

Re: RFR: 8159340: Add extension to CompileGtest.gmk

2016-06-14 Thread Jesper Wilhelmsson
Looks good! /Jesper Den 14/6/16 kl. 11:27, skrev Erik Helin: Hi all, this small patch adds an extension to CompileGtest.gmk. Bug: https://bugs.openjdk.java.net/browse/JDK-8159340 Webrev: http://cr.openjdk.java.net/~ehelin/8159340/00/ Testing: - JPRT Thanks, Erik

Re: RFR: 8157325: gtest tests are not excluded for minimal builds

2016-05-19 Thread Jesper Wilhelmsson
Looks good! /Jesper Den 19/5/16 kl. 12:44, skrev Erik Helin: Hi all, this small patch ensures that the Makefiles correctly excludes gtest unit tests for a minimal build. Right now, if you add a test to e.g. hotspot/native/gc/g1, the test will be included in a minimal build, which will fail.

Re: RFR: 8149594 - Clean up Hotspot makefiles

2016-02-10 Thread Jesper Wilhelmsson
Sending again to include the build-dev list. /Jesper Den 10/2/16 kl. 21:31, skrev Jesper Wilhelmsson: Hi, Please review this cleanup of the Hotspot makefiles. Since I have been spending some time in the makefiles lately there were a few random cleanups that I couldn't stop myself from doing

Re: RFR: 8149594 - Clean up Hotspot makefiles

2016-02-10 Thread Jesper Wilhelmsson
David On 11/02/2016 8:10 AM, Jesper Wilhelmsson wrote: Sending again to include the build-dev list. /Jesper Den 10/2/16 kl. 21:31, skrev Jesper Wilhelmsson: Hi, Please review this cleanup of the Hotspot makefiles. Since I have been spending some time in the makefiles lately there were a few

Re: RFR: 8149594 - Clean up Hotspot makefiles

2016-02-10 Thread Jesper Wilhelmsson
Hi Kim, Thanks for looking at this! Den 10/2/16 kl. 23:34, skrev Kim Barrett: Den 10/2/16 kl. 21:31, skrev Jesper Wilhelmsson: https://bugs.openjdk.java.net/browse/JDK-8149594 http://cr.openjdk.java.net/~jwilhelm/8149594/webrev.00

Re: RFR: Forward port of 8055006 - Store original value of Min/MaxHeapFreeRatio

2014-09-21 Thread Jesper Wilhelmsson
For some reason my mail didn't make it to jdk-build-dev. I'm resending it and include build-dev this time, just in case. Sorry for the noise! /Jesper Jesper Wilhelmsson skrev 20/9/14 19:16: Hi all, I got approvals for the HotSpot changes and they have now been pushed to jdk9/hs-gc

Re: RFR(XS): 8056056 - Remove unnecessary inclusion of HS_ALT_MAKE from solaris Makefile

2014-09-05 Thread Jesper Wilhelmsson
I forgot to mention that this one is aiming for 8u40. Thanks, /Jesper Jesper Wilhelmsson skrev 5/9/14 00:47: Hi, Looking for reviews for this small fix that removes the unnecessary passing of HS_ALT_MAKE to buildtree.make from the Solaris Makefile. It was recently added but is not needed since

Re: RFR(XS): 8056056 - Remove unnecessary inclusion of HS_ALT_MAKE from solaris Makefile

2014-09-05 Thread Jesper Wilhelmsson
Thanks Erik! /Jesper Erik Joelsson skrev 5/9/14 11:47: Looks good to me. /Erik On 2014-09-05 08:37, Jesper Wilhelmsson wrote: I forgot to mention that this one is aiming for 8u40. Thanks, /Jesper Jesper Wilhelmsson skrev 5/9/14 00:47: Hi, Looking for reviews for this small fix

Re: RFR(XS): 8056056 - Remove unnecessary inclusion of HS_ALT_MAKE from solaris Makefile

2014-09-05 Thread Jesper Wilhelmsson
Thanks David! /Jesper David Holmes skrev 5/9/14 13:22: Looks good. Thanks, David On 5/09/2014 8:47 AM, Jesper Wilhelmsson wrote: Hi, Looking for reviews for this small fix that removes the unnecessary passing of HS_ALT_MAKE to buildtree.make from the Solaris Makefile. It was recently added

RFR(XS): 8056056 - Remove unnecessary inclusion of HS_ALT_MAKE from solaris Makefile

2014-09-04 Thread Jesper Wilhelmsson
Hi, Looking for reviews for this small fix that removes the unnecessary passing of HS_ALT_MAKE to buildtree.make from the Solaris Makefile. It was recently added but is not needed since buildtree.make explicitly includes defs.make where HS_ALT_MAKE is defined. Webrev:

Re: RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

2014-08-26 Thread Jesper Wilhelmsson
Hi David, The change was pushed on Friday so it included the change in the Makefile. I filed JDK-8056056 to remove it. Thanks! /Jesper David Holmes skrev 25/8/14 02:50: Sorry I'm late but had a long weekend and was off last Friday. On 22/08/2014 3:04 AM, Jesper Wilhelmsson wrote: Thank

Re: RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

2014-08-22 Thread Jesper Wilhelmsson
. A product build with the above changes shows this: $ cat solaris_amd64_compiler2/product/mapfile_ext # Extended set of symbols. JVM_SetVmMemoryPressure; Looks right to me. Dan On 8/21/14 11:04 AM, Jesper Wilhelmsson wrote: Thank you for the quick reply Dan

RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

2014-08-21 Thread Jesper Wilhelmsson
Hi, On Solaris the HS_ALT_MAKE variable was not passed to vm.make when creating the mapfiles which lead to mapfile-ext not being found and later a linker error due to symbols declared in the extra mapfile not being found. The hotspot makefiles are .. interesting .. yes. The proposed

Re: RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

2014-08-21 Thread Jesper Wilhelmsson
Thank you for the quick reply Dan! A new webrev with your suggested change is available here: http://cr.openjdk.java.net/~jwilhelm/8055744/webrev.02/ /Jesper Daniel D. Daugherty skrev 21/8/14 18:42: On 8/21/14 10:19 AM, Jesper Wilhelmsson wrote: Hi, On Solaris the HS_ALT_MAKE variable

Re: RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

2014-08-21 Thread Jesper Wilhelmsson
shows this: $ cat solaris_amd64_compiler2/product/mapfile_ext # Extended set of symbols. JVM_SetVmMemoryPressure; Looks right to me. Dan On 8/21/14 11:04 AM, Jesper Wilhelmsson wrote: Thank you for the quick reply Dan! A new webrev with your suggested change

Re: RFR: 8028162 - Update Netbeans / Solaris Studio project files on Mac

2013-11-14 Thread Jesper Wilhelmsson
since Solaris Studio generates the files, but if it could be done by the make files it would of course be even better. /Jesper /Magnus On 2013-11-12 13:56, Jesper Wilhelmsson wrote: Hi, Could I have a couple of reviews of the updated project files for NetBeans / Solaris Studio. This change

Re: RFR: Project files for Solaris Studio / NetBeans

2013-04-25 Thread Jesper Wilhelmsson
++ part of OpenJDK. Thanks for everyones comments! /Jesper Jesper Wilhelmsson skrev 27/3/13 5:04 PM: Hi, A new webrev is now available. The issues reported from the first review should be fixed and the project now contains configurations for both Linux_64 and Mac_64. To select configuration