Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]

2021-10-11 Thread Joseph D. Darcy
On 9/23/2021 11:00 PM, Alan Bateman wrote: On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote: Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's mention them in `testing.md`. Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has

Re: JDK 14 RFR of JDK-8214546: Start of release updates for JDK 14

2019-06-05 Thread Joseph D. Darcy
more time automating this will save any significant time. Cheers, Mikael On Jun 5, 2019, at 2:40 PM, Joseph D. Darcy wrote: Hello, Please have an early review the start-of-release builds updates for JDK 14 ahead of the upcoming fork: http://cr.openjdk.java.net/~darcy/jdk14-fork.2/ U

JDK 14 RFR of JDK-8214546: Start of release updates for JDK 14

2019-06-05 Thread Joseph D. Darcy
Hello, Please have an early review the start-of-release builds updates for JDK 14 ahead of the upcoming fork: http://cr.openjdk.java.net/~darcy/jdk14-fork.2/ Unlike previous start-of-release changesets, this one also includes the "symbol" data used by javac --release. After the next JD

Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

2019-02-19 Thread Joseph D. Darcy
Hi Igor, On 2/19/2019 5:54 PM, Igor Ignatyev wrote: Joe, allowSmartActionArgs is opt-in if requiredVersion < b14, and opt-out if requiredVersion >= b14, please see http://hg.openjdk.java.net/code-tools/jtreg/rev/36c592d2f544 . so you don't have to have allowSmartActionArgs=true in 8219254.

Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

2019-02-19 Thread Joseph D. Darcy
Hello, On 2/19/2019 5:06 PM, Igor Ignatyev wrote: Hi Erik, thanks for your review. we can't just bump the required version as it can introduce changes in tests' behavior. requiredVersion >= 4.2 b14 will enable allowSmartActionArgs[1], From what I understand from Jon, allowSmartActionArgs is

Re: test/hotspot/jtreg/runtime/CompressedOops/UseCompressedOops.java failing with -XX:+UseShenandoahGC on x86_64

2019-01-29 Thread Joseph D. Darcy
On 1/28/2019 8:16 AM, Roman Kennke wrote: Isn't anything pushed to 12 (kindof) automatically pushed to 13 too, eventually? Yes; Jesper regularly syncs changes from 12 into 13. At times this requires addressing merge conflicts, etc. HTH, -Joe

Re: RFR: JDK-8210283: Support git as an SCM alternative in the build

2018-09-04 Thread Joseph D. Darcy
I believe both hg and git currently use SHA-1 hashes. Should the syntax used in the release file be expanded to indicate which SCM the hash is from? Thanks, -Joe On 9/4/2018 3:00 PM, Erik Joelsson wrote: There are several instances of OpenJDK source being hosted in Git repositories instead

Re: RFR: 8173401: Update VERSION_FEATURE for JDK 11

2018-02-05 Thread Joseph D. Darcy
Ship it :-) -Joe On 2/5/2018 5:25 PM, David Holmes wrote: It's time to increment the actual version to 11 for JDK 11. Joe Darcy and I have worked through numerous test issues that delayed the update and I've been addressing a number of issues in hotspot related to obsolete/expired flag warni

Re: RFR: JDK-8193512: remove remnants of javah from jdk/jdk10 repo

2017-12-19 Thread Joseph D. Darcy
Looks fine. -Joe On 12/19/2017 1:52 PM, Jonathan Gibbons wrote: Please review these changes to remove the remnants of javah (and in a couple of tests, some remnants of apt and an earlier version of javap) from the repo, now that the tool itself has been removed. JBS: https://bugs.openjdk.jav

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017-12-18 Thread Joseph D. Darcy
together and with less changes required. Paul. On 18 Dec 2017, at 17:33, Joseph D. Darcy <mailto:joe.da...@oracle.com>> wrote: Hello, A follow-up on defining a final field RELEASE_CURRENT as an alias for the latest SourceVersion constant to allow easier updating of annotation

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017-12-18 Thread Joseph D. Darcy
Hello, A follow-up on defining a final field RELEASE_CURRENT as an alias for the latest SourceVersion constant to allow easier updating of annotations using SourceVersion constants. Somewht surprisingly, this is not legal Java code; an annotation must use an enum constant directly and not a

Re: JDK 10 build broken by "8028546: Add -source 10 and -target 10 to javac"

2017-01-31 Thread Joseph D. Darcy
Hi David, Just pushed the change; if you refresh your forest it will be there. Thanks, -Joe On 1/31/2017 5:41 PM, David Holmes wrote: Hi Joe, On 1/02/2017 11:32 AM, joe darcy wrote: Hi David, I can apply my fix for JDK-8173383: Update JDK build to use -source and -target 10. That's exact

JDK 10 RFR of JDK-8173383: Update JDK build to use -source and -target 10

2017-01-25 Thread Joseph D. Darcy
Hello, With the opening of the JDK 10 forests, the build should be updated to use the new source and target options (JDK-8028546: Add -source 10 and -target 10 to javac) Please review the changes for JDK-8173383: Update JDK build to use -source and -target 10 http://cr.openjdk.java.ne

JDK 9 RFR of JDK-8155872: Temporarily disable deprecation checking on the java.desktop module

2016-05-02 Thread Joseph D. Darcy
Hello, As part of deprecating Class.newInstance (JDK-6850612), the client team has requested to not @SuppressWarnings the uses of Class.newIntance in the java.desktop module, but rather to let the client team perform a fuller update to avoid the deprecated coding pattern (JDK-8155874). Since

Re: [urgent] RFR: JDK-8141574: recent change for 8141543 breaks all builds

2015-11-05 Thread Joseph D. Darcy
Looks fine; thanks, -Joe On 11/5/2015 2:11 PM, Erik Joelsson wrote: Hello, Please review this fix for the current build break in jdk9-dev. It seems initializing variables to the empty string in shell requires quotes. Bug: https://bugs.openjdk.java.net/browse/JDK-8141574 Patch: diff -r 4ba1

Re: RFR: JDK-8076583: move jdk.Exported from langtools to jdk

2015-04-02 Thread Joseph D. Darcy
Jon, The actual file move looks fine to me. Thanks, -Joe On 4/2/2015 4:52 PM, Jonathan Gibbons wrote: Sorry for the relatively wide distribution. JDK-8076583 is a conceptually simple cleanup, to move the source file for the jdk.Exported class from the langtools repo (where it is a singleto

Request for guidance on using possible future sets of javac options

2015-02-05 Thread Joseph D. Darcy
Hello, As a continuation of the warnings effort, I'd like to see doclint checking selectively enabled during the main build of the Java sources in the jdk repo by javac. As the name implies, the javac "-Xdoclint" argument enables structural checking of javadoc comments by javac. For the java

Question on how to change javac options when building corba, jaxp, and jaxws repos

2015-01-16 Thread Joseph D. Darcy
Hello build gurus, As a follow-up to clearing the jdk repo of warnings, I'd like to see how many warnings are left in other repos. To do this, I'd like to run the build of the other repos with -Xlint:all -Xmaxwarns 1 I've poked around the build system a bit, but haven't found an effe

Re: [PATCH FOR REVIEW]: Fix CORBA documentation warnings

2010-01-28 Thread Joseph D. Darcy
Andrew John Hughes wrote: 2010/1/16 Andrew John Hughes : 2010/1/16 Joseph D. Darcy : Andrew John Hughes wrote: 2010/1/15 Ken Cavanaugh : The fixes look good to me. Thanks, Ken. On Jan 15, 2010, at 1:59 PM, Joseph D. Darcy wrote: Andrew John Hughes

Re: [PATCH FOR REVIEW]: Fix CORBA documentation warnings

2010-01-15 Thread Joseph D. Darcy
Andrew John Hughes wrote: 2010/1/15 Ken Cavanaugh : The fixes look good to me. Thanks, Ken. On Jan 15, 2010, at 1:59 PM, Joseph D. Darcy wrote: Andrew John Hughes wrote: When building documentation, both OpenJDK6 and OpenJDK7 spit out a number of warnings when building

Re: [PATCH FOR REVIEW]: Fix CORBA documentation warnings

2010-01-15 Thread Joseph D. Darcy
Andrew John Hughes wrote: When building documentation, both OpenJDK6 and OpenJDK7 spit out a number of warnings when building documentation: /mnt/builder/jdk6/impsrc/javax/rmi/PortableRemoteObject.java:171: warning - Tag @link: reference not found: Stub#connect /mnt/builder/jdk6/impsrc/org/omg/C

Re: 6856630: Restructure jaxp/jaxws repository

2009-10-27 Thread Joseph D. Darcy
Andrew John Hughes wrote: 2009/10/23 Kelly O'Hair : Jonathan Gibbons wrote: Kelly O'Hair wrote: Jonathan Gibbons wrote: Kelly O'Hair wrote: [big snip] DOH! Sorry... Yes, these jaxp and jaxws forests can probably go away, we won't be using them. The cur

Re: Should GNU make 3.81 be required?

2009-09-15 Thread Joseph D. Darcy
Kelly O'Hair wrote: So I'm trying to work out some jdk7 Makefile performance improvements and everything is working out fine on Linux and OpenSolaris... Then I discover that the GNU make features I'm using are seriously broken in GNU make 3.80 and I need 3.81 to get around it. :^( Also it turns

Re: Can't build latest openjdk6

2009-08-13 Thread Joseph D. Darcy
I'll do some test builds myself on Friday. -Joe Jonathan Gibbons wrote: Martin, Comment noted. I'm now on vacation, so I'll look at this next week. -- Jon On Aug 13, 2009, at 6:10 PM, Martin Buchholz wrote: It appears that ant is being invoked with "-Djavac.target=5", but not with -Djava

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-13 Thread Joseph D. Darcy
Andrew John Hughes wrote: 2009/8/10 Tim Bell : No luck it seems... [echo] Downloading from https://jaxp.dev.java.net/files/documents/913/140275/jdk7-jaxp-m5.zip [get] Getting: https://jaxp.dev.java.net/files/documents/913/140275/jdk7-jaxp-m5.zip [get] To: /mnt/builder/openjdk.iced

Re: Command line acceptance of binary plugs license?

2009-08-01 Thread Joseph D. Darcy
Vinod Kutty wrote: Hi, I'm trying to build openjdk7-ea-b67, so I downloaded the self-extracting binary plugs and tried to extract it. You no longer need the binary plugs to perform an openjdk=true build. -Joe Unfortunately, it assumes a graphical environment for the license agreement an

Re: HotSpot 14

2009-05-18 Thread Joseph D. Darcy
Andrew John Hughes wrote: snip... Given how well this model works for IcedTea working with OpenJDK, I'm confident it can also work for the JDK's incorporation of corba, jaxp, and jaxws :-) Indeed, IcedTea already downloads a tarball of the HSX repository and deletes the OpenJDK6 version.

Re: HotSpot 14

2009-05-16 Thread Joseph D. Darcy
Jonathan Gibbons wrote: On May 15, 2009, at 9:58 PM, Joseph D. Darcy wrote: Hello. Erik Trimble wrote: Andrew John Hughes wrote: 2009/5/15 Erik Trimble : Andrew John Hughes wrote: Hi all (especially Joe), Now that the HotSpot Express repositories are available, what is the plan for

Re: New project: getting rid of IcedTea local patches

2009-04-16 Thread Joseph D. Darcy
Catching up on email, Andrew John Hughes wrote: 2009/4/9 Alan Bateman : Andrew Haley wrote: [snip] I'm not very familiar with IcedTea but I cloned the repository to see what these patches are about. Here are a few comments: icedtea-6728542-epoll.patch seems to be a change-set I push

Re: OpenJDK6: Bug in genlocales.gmk

2009-04-01 Thread Joseph D. Darcy
Kelly O'Hair wrote: I'll get it. Can someone in the OpenJDK commit list (http://db.openjdk.java.net/people) review this minor change for jdk6: Approved. -Joe diff --git a/make/java/java/genlocales.gmk b/make/java/java/genlocales.gmk --- a/make/java/java/genlocales.gmk +++ b/make/java/j

Re: New project: getting rid of IcedTea local patches

2009-04-01 Thread Joseph D. Darcy
Andrew Haley wrote: We at Red Hat have noticed that the list of IcedTea local patches has been getting large, with some local patches that should have been pushed upstream. Also, some IcedTea patches have been committed to OpenJDK 7 but not OpenJDK 6. So, we're going to have a serious attempt t

Re: OpenJDK 6 build 14 source posted

2008-12-04 Thread Joseph D. Darcy
John Coomes wrote: Andrew Haley ([EMAIL PROTECTED]) wrote: Martin Buchholz wrote: On Wed, Dec 3, 2008 at 11:38, Joe Darcy <[EMAIL PROTECTED]> wrote: The source bundle for OpenJDK 6 build 14 is available for download from: http://download.java.net/openjdk/jdk6/ The

Re: javax.script rhino (javascript) support added

2008-06-24 Thread Joseph D. Darcy
Andrew John Hughes wrote: 2008/6/23 Dalibor Topic <[EMAIL PROTECTED]>: Mark Wielaard wrote: Hi David, On Mon, 2008-06-23 at 11:43 -0700, David Herron wrote: Mark Wielaard wrote: In my JavaOne talk Sandeep and I had worked up a hack with the same purpose. He's been busy enough that he hadn't

Re: Runing findbugs

2008-05-13 Thread Joseph D. Darcy
I agree that having results of findbugs (and other checkers) as one of the results of the build would be a good idea. -Joe Max (Weijun) Wang wrote: Since it takes so long time, how about the release engineer running it once after every build and post the result to openjdk.java.net? Hope some