Re: RFR (XS) 8033946 - Hotspot build should ignore "ide" folder

2014-09-04 Thread Karen Kinnear
Gerard, I'm a bit confused - if you have an ide to build the entire jdk - what happens? I was a bit surprised to see a hotspot specific change? Also - can't you store your favorite IDE project outside of the repository? thanks, Karen On Sep 4, 2014, at 12:45 PM, Gerard Ziemski wrote: > hi all

Re: Code Review fix for 8005044 remove crufty '_g' support from HS runtime code

2012-12-19 Thread Karen Kinnear
Sounds like time to file a separate bug to track that issue down (particularly the bsd issue) and move on with this one. Thank you so much Dan for the history and details, Karen On Dec 19, 2012, at 11:30 AM, Daniel D. Daugherty wrote: > Adding the other aliases back in... > > Harold, > > This

Re: code review for JDK FDS gobjcopy work arounds (7170449)

2012-05-24 Thread Karen Kinnear
Looks good. Thank you. thanks, Karen On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a JDK code review request for a pair of Full Debug Symbols > gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 > corrupts the SUNW_* sections on objects. This

Re: code review for second hotspot FDS gobjcopy work around (7165598)

2012-05-24 Thread Karen Kinnear
Dan, Code looks good. Thank you for the work-around. So is this HDR_FLAGS workaround also needed in all the other jdk repositories? And I assume the windows/makefiles/defs.make change is because you determined that the failing tests actually pre-dated the zipped debuginfo. Did you find the ro

Re: code review request for FDS/aurora bug fix (7168520)

2012-05-17 Thread Karen Kinnear
Dan, Code looks good. Thank you for figuring out this work-around. thanks, Karen On May 17, 2012, at 10:14 AM, Daniel D. Daugherty wrote: > Greetings, > > This is a code review request for the following P1 bug: > >7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in >

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Karen Kinnear
Code change looks good. I assume you want to put this fix back to JDK8 as well. thank you for the quick fix! Karen On Jan 26, 2012, at 4:44 AM, Rickard Bäckman wrote: > Hi, > > We have a problem with some versions of jar reporting errors when trying to > run jar cf com/test com/test/foo > >

Re: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Karen Kinnear
Thanks Rickard. My guess is that if it works with all version of jar which you've tested, then it will be easier going forward to maintain the file consistently, and it causes no harm. thanks, Karen On Jan 26, 2012, at 7:03 AM, Rickard Bäckman wrote: > On 01/26/2012 12:53 PM, Karen