Integrated: 8282507: Add a separate license file for hsdis

2022-03-15 Thread Man Cao
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote: > Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man This pull request has now been integrated. Changeset: ac06bdb1 Author:Man Cao URL: https://git.openjdk.java

Re: RFR: 8282507: Add a separate license file for hsdis [v2]

2022-03-14 Thread Man Cao
On Mon, 14 Mar 2022 22:27:29 GMT, Man Cao wrote: >> Hi all, >> >> Could anyone help review the addition of LICENSE file to hsdis directory? >> >> -Man > > Man Cao has updated the pull request incrementally with one additional commit > since the last

Re: RFR: 8282507: Add LICENSE file for hsdis [v2]

2022-03-14 Thread Man Cao
> Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man Man Cao has updated the pull request incrementally with one additional commit since the last revision: Rename license file to hsdis-license.txt - Changes:

Re: RFR: 8282507: Add LICENSE file for hsdis

2022-03-10 Thread Man Cao
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote: > Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man Thank you for pointing out the difference between hsdis and other 3rd party code. > src/java.desktop/share/native/libsplashscr

Re: RFR: 8282507: Add LICENSE file for hsdis

2022-03-10 Thread Man Cao
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote: > Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man The consistency is to have the license information in its own file, like other 3rd party code in OpenJDK. There two ways: - Add a LI

Re: RFR: 8282507: Add LICENSE file for hsdis

2022-03-10 Thread Man Cao
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote: > Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man The context is that Google have an automated check for license compliance for all imported open-source software. We (Java platfor

Re: RFR: 8282507: Add LICENSE file for hsdis

2022-03-09 Thread Man Cao
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote: > Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man Any updates on whether this is acceptable? - PR: https://git.openjdk.java.net/jdk/pull/7649

Re: RFR: 8282507: Add LICENSE file for hsdis

2022-03-02 Thread Man Cao
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote: > Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man Thank you for reaching out for confirmation. This doc might help: https://docs.github.com/en/repositories/managing-your-repositor

RFR: 8282507: Add LICENSE file for hsdis

2022-03-01 Thread Man Cao
Hi all, Could anyone help review the addition of LICENSE file to hsdis directory? -Man - Commit messages: - Add LICENSE file for hsdis Changes: https://git.openjdk.java.net/jdk/pull/7649/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7649&range=00 Issue: https://bu