Copyright 2011, 2014 in gmk file.
Otherwise +1
/M
> On 25 Aug 2015, at 15:24, Sundararajan Athijegannathan
> wrote:
>
> Hi,
>
> Please review http://cr.openjdk.java.net/~sundar/8134260/ for
> https://bugs.openjdk.java.net/browse/JDK-8134260
>
> jdk.nashorn.tools.jjs and jdk.internal.le sho
+1
> On 11 May 2015, at 12:47, A. Sundararajan
> wrote:
>
> Please review fix for http://cr.openjdk.java.net/~sundar/8079900/webrev.00/
> for https://bugs.openjdk.java.net/browse/JDK-8079900#comment-13640520
>
> Note that jdk.nashorn.api.tree is part of nashorn API as specified by Nashorn
>
+1
> On 28 Nov 2014, at 12:50, A. Sundararajan
> wrote:
>
> Hi,
>
> Thanks for catching that!
>
> Please review updated http://cr.openjdk.java.net/~sundar/8066146/webrev.01/
>
> Thanks,
> -Sundar
>
> Erik Joelsson wrote:
>> Hello,
>>
>> Should:
>>
>> 1140 NASHORNAPI2COREAPI := ../../$(JD
Looks good!
/M
On 07 Oct 2014, at 10:33, Erik Joelsson wrote:
> Hello,
>
> Please review and approve this backport from jdk9 to jdk8u40. The patch does
> not apply cleanly, but with a slight reduction it works just as well.
>
> The Bug: https://bugs.openjdk.java.net/browse/JDK-8059135
> The
Oh - you already did. My bad. Thanks so much for the quick resolution.
/M
On 03 Oct 2014, at 10:42, Marcus Lagergren wrote:
> Thanks Erik,
>
> Are you pusing this forward to jdk9 as well?
>
> Regards
> Marcus
>
> On 02 Oct 2014, at 07:29, Tim Bell wrote:
>
Thanks Erik,
Are you pusing this forward to jdk9 as well?
Regards
Marcus
On 02 Oct 2014, at 07:29, Tim Bell wrote:
> Hi Erik:
>
>> Please review this small patch fixing the bootstrap problem of building
>> nasgen. To make sure no other nashorn is picked up, force the bootclasspath
>> to be
+1
On 02 Oct 2014, at 01:34, Erik Joelsson wrote:
> Hello,
>
> Please review this small patch fixing the bootstrap problem of building
> nasgen. To make sure no other nashorn is picked up, force the bootclasspath
> to be only the rt.jar of the boot jdk and the newly compiled nashorn classes.
