Re: RFR: 8287811: JFR: jfr configure error message should not print stack trace

2022-06-06 Thread Markus Grönlund
On Fri, 3 Jun 2022 15:54:47 GMT, Erik Gahlin wrote: > Could I have a review of PR that removes a printStackTrace() for the jfr > tool. > > Testing: jdk/jfr/tool > > Thanks > Erik Marked as reviewed by mgronlun (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/9018

Re: RFR: 8280844: Epoch shift synchronization point for Compiler threads is inadequate [v2]

2022-05-16 Thread Markus Grönlund
och race is avoided only by performing the transition to _thread_in_vm. > > Testing: jdk_jfr > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: delegate assertion - Changes: - all: htt

RFR: 8280844: Epoch shift synchronization point for Compiler threads is inadequate

2022-05-16 Thread Markus Grönlund
Greetings, [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to address artefact tagging for Compiler threads, letting threads run _thread_in_native to avoid the transition. Unfortunately, that attempt proved inadequate. The epoch race is avoided only by performing the

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v8]

2022-01-17 Thread Markus Grönlund
On Wed, 12 Jan 2022 15:18:46 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK 👋 >> >> ### Implementation notes and alternatives considered >> >> After mod

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v8]

2022-01-12 Thread Markus Grönlund
On Wed, 12 Jan 2022 15:18:46 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK 👋 >> >> ### Implementation notes and alternatives considered >> >> After mod

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default)

2020-12-09 Thread Markus Grönlund
On Mon, 7 Dec 2020 22:37:20 GMT, Mukilesh Sethu wrote: >> Greetings, >> >> please help review this enhancement to let JFR sample object allocations by >> default. >> >> A description is provided in the JIRA issue. >> >> Thanks >> Markus > > This is great! It would be awesome to have this cap

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default) [v4]

2020-12-09 Thread Markus Grönlund
On Tue, 8 Dec 2020 16:31:37 GMT, Erik Gahlin wrote: >> Markus Grönlund has updated the pull request incrementally with 12 >> additional commits since the last revision: >> >> - initialization check >> - thread locals and detach and reattach >> - Ti

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default) [v4]

2020-12-09 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to let JFR sample object allocations by > default. > > A description is provided in the JIRA issue. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with 12 additional comm

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default) [v3]

2020-12-06 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to let JFR sample object allocations by > default. > > A description is provided in the JIRA issue. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional com

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default) [v2]

2020-12-06 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to let JFR sample object allocations by > default. > > A description is provided in the JIRA issue. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional com

RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default)

2020-12-04 Thread Markus Grönlund
Greetings, please help review this enhancement to let JFR sample object allocations by default. A description is provided in the JIRA issue. Thanks Markus - Commit messages: - defensive initialization check - Whitespace errors - JFR Event Throttling Changes: https://git.openjd

RE: RFR: 8023492 jfr.jar gets loaded even though it's not used

2013-09-30 Thread Markus Grönlund
Looks good Staffan, thanks for fixing. /Markus -Original Message- From: Staffan Larsen Sent: den 30 september 2013 10:00 To: build-dev@openjdk.java.net build-dev; serviceability-...@openjdk.java.net serviceability-...@openjdk.java.net Subject: RFR: 8023492 jfr.jar gets loaded even thoug

RE: RFR(XS): 8019155 Update makefiles with correct jfr packages

2013-06-28 Thread Markus Grönlund
Looks good. /Markus -Original Message- From: Staffan Larsen Sent: den 28 juni 2013 15:16 To: build-dev@openjdk.java.net build-dev; serviceability-...@openjdk.java.net serviceability-...@openjdk.java.net Subject: RFR(XS): 8019155 Update makefiles with correct jfr packages Please review

RE: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Markus Grönlund
Looks good. /Markus -Original Message- From: Staffan Larsen Sent: den 26 juni 2013 09:42 To: build-dev@openjdk.java.net build-dev; serviceability-...@openjdk.java.net serviceability-...@openjdk.java.net Subject: RFR (XS): 8019155 Update makefiles with correct jfr packages Please review

RE: RFR: 7133124 Remove redundant packages from JAR command line

2012-01-26 Thread Markus Grönlund
Thanks Alan for quick response, much appreciated. Markus > -Original Message- > From: Alan Bateman > Sent: den 26 januari 2012 10:52 > To: Rickard Bäckman > Cc: serviceability-...@openjdk.java.net; build-dev@openjdk.java.net > Subject: Re: RFR: 7133124 Remove redundant packages from JAR c