Hi,
Please review the changes for JDK-8165804 which is a follow-up of
JDK-8076757. Some notes on the changes.
- Removed INCLUDES := $(TEXT_PKG_LD) from
make/gendata/GendataBreakIterator.gmk in order to avoid compiling
non-BreakIterator*.java for the build tool with boot JDK.
- Added sun.ut
The i18n changes look good to me.
Masayoshi
On 8/4/2015 7:10 AM, Naoto Sato wrote:
Hello,
Please review the changes for the following issues that are the
regressions for fixing 8008577:
8129881: 8008577 breaks Nashorn test
(https://bugs.openjdk.java.net/browse/JDK-8129881)
8130845: Change
Looks good to me.
Masayoshi
On 6/25/2015 1:15 AM, Naoto Sato wrote:
Thanks. Here is the diff from "webrev.01" to address your comment:
http://hg.openjdk.java.net/jdk9/sandbox/jdk/rev/b8faab65bb62
Naoto
On 6/24/15 2:16 AM, Masayoshi Okutsu wrote:
applyParentLocales() sets parent
d webrev:
http://cr.openjdk.java.net/~naoto/8008577/webrev.01/
As to the 3rd comment below, I did not modify it because that would
simply duplicate the same piece of code in each getCandidateLocales()
implementation (from the current location).
Naoto
On 6/19/15 1:53 AM, Masayoshi Okutsu wrote:
Sorry
Sorry for taking time. Here are my comments.
src/jdk.localedata/share/classes/sun/text/resources/*JavaTimeSupplementary*.java:
- The year range of the first line of the copyright header should be
"2015," for the new ones and "2013, 2015," for the updated ones.
- I wonder if JavaTimeSupplementa
On 10/23/2014 4:58 PM, Alan Bateman wrote:
jdk.localedata.XXX looks right. I wonder if we can find something
better than "jre" for the suffix of the first one. I ask because
linking that into a runtime that isn't the what we know today as the
JRE might be confusing.
Actually Naoto and I discu
+1
On 10/23/2014 4:52 AM, Naoto Sato wrote:
Hi Mandy,
As I wrote in a separate email, my preference is the following module
names:
jdk.localedata.jre
jdk.localedata.cldr
This way, they both come under "localedata" (btw, they don't provide
Locale, but the data for locale sensitive services
Do we need availableLocalesTests() of Bug8038436.java? I think it's
rather a burden to maintain the hard-coded tags in the test.
Otherwise, the fix looks good to me.
Thanks,
Masayoshi
On 8/30/2014 6:07 AM, Naoto Sato wrote:
I incorporated the suggestions from Mandy and Alan. Also one change
s
Here are my comments.
- Looks like this change removed the 8055088 fix for BreakIteratorInfo
optimization.
- The langtags field in each *Impl class should be volatile.
- DateFormatProviderImpl has static langtags to be shared by some other
*Impl. But JRE and CLDR have different sets of langu
it to the repo.
Naoto
On 2/12/14, 4:43 PM, Naoto Sato wrote:
On 2/12/14, 4:07 PM, Masayoshi Okutsu wrote:
The problem in the bug report is that the currency symbol is taken from
the HOST locale provider where it is expected to come from the JRE
locale provider. Hans/Hant of zh locales of JRE l
most
preferred adapter. However, on the JRE's adapter side, it still needs
to declare that Hans/Hant locales in the supported locales list. This
fix is to address this latter part.
Naoto
On 2/10/14, 12:23 AM, Masayoshi Okutsu wrote:
I wonder if we can utilize the locale matching mechanism r
I wonder if we can utilize the locale matching mechanism rather than
tweaking the makefile. zh-CN and zh-Hans-CN can be treated as
equivalents for looking up the JRE locales.
Masayoshi
On 2/5/2014 11:54 AM, Naoto Sato wrote:
Hello,
Please review this fix:
http://cr.openjdk.java.net/~naoto/8
Looks good to me.
Masayoshi
On 1/12/2013 6:18 AM, Naoto Sato wrote:
Hello,
(To build-dev folks, I am sending this to you as the change includes
one modification in make directory. It is just simply adding a new
Java file, so I think it won't affect the new build-infra structure)
Please rev
affect the new build, so it's
ok with the build group.
/Erik
On 2012-12-06 06:06, Masayoshi Okutsu wrote:
Resending in order to include build-dev@openjdk.java.net and
build-in...@openjdk.dev.java.net.
Hi,
This is a review request for two RFEs.
http://bugs.sun.com/bugdatabase/vie
nericTimeZoneNamesTest.sh and NarrowNamesTest.sh were
fixed to detect failures correctly. No other changes.
Updated webrev:
http://cr.openjdk.java.net/~okutsu/8/8000983.8003267/webrev.01/
Thanks,
Masayoshi
Naoto
On 12/5/12 9:06 PM, Masayoshi Okutsu wrote:
Resending in order to include build-dev@
Resending in order to include build-dev@openjdk.java.net and
build-in...@openjdk.dev.java.net.
Hi,
This is a review request for two RFEs.
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
http://cr.openjdk.java.net/~okutsu/8/
16 matches
Mail list logo
