On Wed, 20 Oct 2021 18:46:14 GMT, Mikhailo Seledtsov
wrote:
> Please review this trivial change that adds "linux-aarch64" to test make
> profile.
This pull request has now been integrated.
Changeset: af146501
Author:Mikhailo Seledtsov
URL:
https://git.openjdk.jav
On Wed, 20 Oct 2021 18:46:14 GMT, Mikhailo Seledtsov
wrote:
> Please review this trivial change that adds "linux-aarch64" to test make
> profile.
Magnus, thank you for review. The test make build passes on linux-aarch64.
-
PR: https://git.openjdk.java.net/jdk/pull/6051
Please review this trivial change that adds "linux-aarch64" to test make
profile.
-
Commit messages:
- Add linux-aarch64 to test make profile
Changes: https://git.openjdk.java.net/jdk/pull/6051/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6051&range=00
Issue: http
On Tue, 19 Oct 2021 23:22:06 GMT, Mikhailo Seledtsov
wrote:
> Please review this small change that adds the linux-aarch64 zero build
> profile.
Thanks for review. I have removed the extra brackets and re-tested.
-
PR: https://git.openjdk.java.net/jdk/pull/6024
On Tue, 19 Oct 2021 23:22:06 GMT, Mikhailo Seledtsov
wrote:
> Please review this small change that adds the linux-aarch64 zero build
> profile.
This pull request has now been integrated.
Changeset: 0021a2f4
Author:Mikhailo Seledtsov
URL:
https://git.openjdk.java.net/jdk/
> Please review this small change that adds the linux-aarch64 zero build
> profile.
Mikhailo Seledtsov has updated the pull request incrementally with one
additional commit since the last revision:
Removing extra brackets per review feedback
-
Changes:
- all:
On Tue, 19 Oct 2021 23:22:06 GMT, Mikhailo Seledtsov
wrote:
> Please review this small change that adds the linux-aarch64 zero build
> profile.
Testing:
- linux-aarch64 zero build - PASS
- major platform builds: linux-x64, linux-aarch64, windows-x64, macosx-x64,
macosx-aarch64
Please review this small change that adds the linux-aarch64 zero build profile.
-
Commit messages:
- Add linux-aarch64-zero to jib build profiles
- Add aarch64 as target CPU for libffi lookup
Changes: https://git.openjdk.java.net/jdk/pull/6024/files
Webrev: https://webrevs.openjdk
On Thu, 30 Sep 2021 22:01:51 GMT, Mikhailo Seledtsov
wrote:
> Please review this simple/trivial change that add linux-aarch64 platform to
> bootcycle build profiles.
Thank you Erik.
-
PR: https://git.openjdk.java.net/jdk/pull/5783
On Thu, 30 Sep 2021 22:01:51 GMT, Mikhailo Seledtsov
wrote:
> Please review this simple/trivial change that add linux-aarch64 platform to
> bootcycle build profiles.
This pull request has now been integrated.
Changeset: 9914e5c4
Author:Mikhailo Seledtsov
URL:
Please review this simple/trivial change that add linux-aarch64 platform to
bootcycle build profiles.
-
Commit messages:
- Add linux-aarch64 to bootcycle build profiles
Changes: https://git.openjdk.java.net/jdk/pull/5783/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=
On Thu, 23 Sep 2021 22:02:07 GMT, Mikhailo Seledtsov
wrote:
> Please review this small change that adds hook for custom makefiles to
> augment parameters for jtreg test execution.
Thank you Erik !
-
PR: https://git.openjdk.java.net/jdk/pull/5666
On Thu, 23 Sep 2021 22:02:07 GMT, Mikhailo Seledtsov
wrote:
> Please review this small change that adds hook for custom makefiles to
> augment parameters for jtreg test execution.
This pull request has now been integrated.
Changeset: 14100d55
Author:Mikhailo Seledtsov
URL:
Please review this small change that adds hook for custom makefiles to augment
parameters for jtreg test execution.
-
Commit messages:
- Initial change
Changes: https://git.openjdk.java.net/jdk/pull/5666/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5666&range=00
I
On Thu, 23 Sep 2021 22:02:07 GMT, Mikhailo Seledtsov
wrote:
> Please review this small change that adds hook for custom makefiles to
> augment parameters for jtreg test execution.
Testing:
- tested with custom make file to make sure the feature works
- ran a variety of test fra
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request increm
On Tue, 3 Aug 2021 20:18:11 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that enables
> `runtime/jsig/Testjsig.java` test and compilation of its native library on
> all platforms but windows?
> from JBS:
>> `runtime/jsig/Testjsig.java` test currently `@requi
On Sun, 20 Jun 2021 11:08:21 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that enables
> `runtime/jsig/Testjsig.java` test and compilation of its native library on
> all platforms but windows?
> from JBS:
>> `runtime/jsig/Testjsig.java` test currently `@requ
Runtime test changes look good to me,
Misha
On 4/10/20 11:44 AM, Igor Ignatyev wrote:
Hi Roger,
removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming
.html was generated from .md) look good to me.
adding hotspot-runtime alias to bring attention of runtime team. I'm n
Hi Erik,
Looks good to me. Thanks for fixing this.
Misha
On 4/9/20 8:15 AM, Erik Joelsson wrote:
The test
open/test/hotspot/jtreg/testlibrary_tests/process/TestNativeProcessBuilder.java
fails when building the JDK with VS2019. More specifically, it fails
if the JDK under test is built wit
+1
On 7/17/19 9:43 PM, David Holmes wrote:
Hi Igor,
This seems fine to me.
Thanks,
David
On 17/07/2019 7:35 am, Igor Ignatyev wrote:
can I get a review for this patch?
http://cr.openjdk.java.net/~iignatyev//8226910/webrev.01/index.html
Thanks,
-- Igor
On Jul 6, 2019, at 11:50 AM, Igor Ign
Please review this change that will open source VM Testbase Runtime
tests. This group includes tests covering a variety of runtime
functional areas: arraycopy, barrier, jni, threads, vtable and contented.
These tests have been used internally for a while, and are now being
open sourced. Since
Please review this change that will open source VM default method tests.
These tests have been used internally for a while, and are now being
open sourced. Since this is not an creation of new tests, we would like
to keep the changes during this review to a minimum required for open
sourcing th
Looks good to me,
Misha
On 5/8/18, 2:23 PM, Leonid Mesnik wrote:
Hi
Please review this change open sourcing vm testbase stress tests. These tests
have been developed a long time ago for internal test harness and don't looks
very nice now.
They are open sourced with minimal changes only. The
While testing I discovered build errors on Mac and Solaris. The
following statement " BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exesigtest :=
-ljvm" was added to a Linux-only block. I have updated the make file to
add this for any platform w/o conditions; the " exesigtest.c" is
excluded from Windows
at 7:26 AM, Mikhailo Seledtsov
wrote:
Hi Igor,
Thank you for review. This is what I see from the test execution logs on
Windows:
// At archive creation time:
-XX:SharedArchiveFile=T:/testoutput/jtreg/cds_archive.jsa -Xshare:dump
// At archive use time:
-vm
Hi Magnus,
Thank you for review and feedback. I will update my change based on
your recommendation, the retest. If tests pass, I am planning to push.
Thank you,
Misha
On 2/14/18, 12:04 PM, Magnus Ihse Bursie wrote:
On 2018-02-14 16:26, Mikhailo Seledtsov wrote:
Hi Igor,
Thank you for
RCHIVE_FILE)")
otherwise, tests won't be able to find cds archive during test execution.
-- Igor
On Feb 13, 2018, at 8:17 PM, Mikhailo Seledtsov
wrote:
Please review this small change that enables execution of any jtreg test(s) in
CDS mode
via make. Please see bug description for details
28 matches
Mail list logo
