Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-31 Thread Pete Brunet
Erik, I need your +1 again because the make files have changed since you last looked. I'll also be running JPRT before I push. Pete > > -phil. > > On 10/31/2016 07:36 AM, Pete Brunet wrote: >> >> On 10/28/16 8:14 PM, Mandy Chung wrote: >>>> On Oct 28, 2016, at

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-31 Thread Pete Brunet
This works for me. Updated: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.09/ > > Mandy > >> -phil. >> >> On 10/28/16, 12:42 PM, Mandy Chung wrote: >>>> On Oct 28, 2016, at 11:32 AM, Pete Brunet wrote: >>>> >>>> Hi Mandy, That simplifi

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-28 Thread Pete Brunet
https://bugs.openjdk.java.net/browse/JDK-8168018 Pete On 10/28/16 2:42 PM, Mandy Chung wrote: >> On Oct 28, 2016, at 11:32 AM, Pete Brunet wrote: >> >> Hi Mandy, That simplifies things. The new patch is at: >> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.08/ > Looks better.

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-28 Thread Pete Brunet
Hi Mandy, That simplifies things. The new patch is at: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.08/ Pete On 10/27/16 6:51 PM, Mandy Chung wrote: >> On Oct 27, 2016, at 4:31 PM, Pete Brunet wrote: >> >> I moved the source to >> src/jdk.accessibility/w

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Pete Brunet
On 10/27/16 6:31 PM, Pete Brunet wrote: > On 10/27/16 1:30 PM, Mandy Chung wrote: >>> On Oct 27, 2016, at 10:44 AM, Phil Race wrote: >>> >>> No, we are definitely shipping those. >>> Unless of course you think we should stop shipping JNI headers too … &g

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Pete Brunet
On 10/27/16 1:30 PM, Mandy Chung wrote: >> On Oct 27, 2016, at 10:44 AM, Phil Race wrote: >> >> No, we are definitely shipping those. >> Unless of course you think we should stop shipping JNI headers too … >> > No. I tried to understand what is external interface. I took it that these > header

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Pete Brunet
On 10/27/16 1:47 PM, Pete Brunet wrote: > > On 10/27/16 1:34 PM, Phil Race wrote: >> In which case be careful it is not built by the JDK build .. > Build team, Is there anything I need to handle here to make sure it isn't? Actually, let me give it a try. I should be able t

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Pete Brunet
On 10/27/16 1:34 PM, Phil Race wrote: > In which case be careful it is not built by the JDK build .. Build team, Is there anything I need to handle here to make sure it isn't? > unless that is actually required .. which I didn't think it was. > > -phil. > > On 10/27/2016 11:30 AM, Mandy Chung wro

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Pete Brunet
On 10/27/16 1:34 PM, Phil Race wrote: > In which case be careful it is not built by the JDK build .. > unless that is actually required .. which I didn't think it was. It isn't. > > -phil. > > On 10/27/2016 11:30 AM, Mandy Chung wrote: >> Please move AccessBridgeCalls.c to >> src/jdk.accessibili

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Pete Brunet
dge/AccessBridgeCalls.c >> <http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c> >> >> Regards, >> Anirvan Sarkar >> >> On Thursday 27 October 2016, Pete Brunet > > wrote: >> >

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Pete Brunet
The .h files are unlicensed in the bundle/install so no need? On 10/26/16 11:52 PM, Mandy Chung wrote: > Should the same change be applied to the .h files as well? > > Mandy > >> On Oct 26, 2016, at 7:24 PM, Pete Brunet wrote: >> >> Please revie

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Pete Brunet
njdk.java.net/jdk9/client/jdk/file/tip/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c > <http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c> > > Regards, > Anirvan Sarkar &

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Pete Brunet
I found a comment from Mandy in the bug. That hex number can be replaced with "tip". I uploaded http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.04/ Pete On 10/26/16 11:05 PM, Pete Brunet wrote: > > > On 10/26/16 10:44 PM, Philip Race wrote: >> >

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Pete Brunet
aware of a "latest" link. Maybe some other reader will know. > > But I am not sure about that either .. it may need to be split between the > main URL and the location in the repo. > > -phil > > > On 10/26/16, 7:24 PM, Pete Brunet wrote: >> Please revie

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Pete Brunet
/25/16 6:48 AM, Alexandr Scherbatiy wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 10/24/2016 1:18 PM, Erik Joelsson wrote: >> The last change looks good and simple to me. >> >> /Erik >> >> >> On 2016-10-21 06:55, Pet

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-20 Thread Pete Brunet
h the current API and related calls into WindowsAccessBridge*.dll. Pete On 10/18/16 12:28 PM, Pete Brunet wrote: > I've updated the webrev. Please see > http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/ > > Rather than removing the files needed by Assistive Technology d

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-18 Thread Pete Brunet
clude directory to a new javaaccessbridge directory. On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote: > On 2016-10-14 17:51, Pete Brunet wrote: >> Please review the following. >> >> The .h files and .c file provided to allow Assistive Technology to >> interface to the

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-14 Thread Pete Brunet
l not be in an Oracle JDK which strips the GPL > > So if you are going to do this then these files first need to be > dual-licensed > because otherwise people can't link their commercial products with these. > > -phil. > > On 10/14/2016 08:51 AM, Pete Brunet wrote: >>

RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-14 Thread Pete Brunet
Please review the following. The .h files and .c file provided to allow Assistive Technology to interface to the Java Access Bridge API are being removed from the built JRE/JDK images. They are not used much and they can be obtained online via the OpenJDK web site. The pubs will be updated to m

Re: build failing on Mac

2016-06-27 Thread Pete Brunet
tools, did you run "sudo xcode-select -switch > /path/to/Xcode.app"? > > -DrD- > >> On Jun 22, 2016, at 10:09 PM, Pete Brunet wrote: >> >> Installed 6.3.2. Refreshed source. Ran configure. make clean. make >> images. Build failed with >

Re: build failing on Mac

2016-06-22 Thread Pete Brunet
, Daniel Fuchs wrote: > Hi Pete, > > I had the same problem recently - and solved it by installing > Xcode 6.3 - which I was told is the officially supported version. > > best regards, > > -- daniel > > On 18/06/16 01:20, Pete Brunet wrote: >> I haven't done

Re: build failing on Mac

2016-06-20 Thread Pete Brunet
Thanks Daniel! Bookmarked. On 6/20/16 8:18 AM, Daniel Fuchs wrote: > Hi Pete, > > On 20/06/16 13:24, Pete Brunet wrote: >> Thanks Daniel, I will give it a try. I've not been having luck recently >> finding old versions of xcode. Any thoughts on the best place to >&

Re: build failing on Mac

2016-06-20 Thread Pete Brunet
6.3 - which I was told is the officially supported version. > > best regards, > > -- daniel > > On 18/06/16 01:20, Pete Brunet wrote: >> I haven't done a full build in around a month, but just pulled (tpull >> -u) / cleaned / reconfigured and got this on my Ma

Re: build failing on Mac

2016-06-19 Thread Pete Brunet
On 6/19/16 10:52 PM, David Holmes wrote: > On 18/06/2016 10:20 AM, Pete Brunet wrote: >> I haven't done a full build in around a month, but just pulled (tpull >> -u) / cleaned / reconfigured and got this on my Mac: > > Did you update Xcode in that month? Hi Davi

Re: build failing on Mac

2016-06-17 Thread Pete Brunet
An using configure switch --disable-warnings-as-errors for now. On 6/17/16 7:20 PM, Pete Brunet wrote: > I haven't done a full build in around a month, but just pulled (tpull > -u) / cleaned / reconfigured and got this on my Mac: > > ... > Creating gtestLauncher from 1 file

build failing on Mac

2016-06-17 Thread Pete Brunet
I haven't done a full build in around a month, but just pulled (tpull -u) / cleaned / reconfigured and got this on my Mac: ... Creating gtestLauncher from 1 file(s) error: unknown warning option '-Wno-tautological-undefined-compare'; did you mean '-Wno-tautological-compare'? [-Werror,-Wunknown-war

Re: Mac build failing

2016-05-09 Thread Pete Brunet
Installing the xcode command line tools resolved that issue. xcode-select --install On 5/9/16 5:26 PM, Pete Brunet wrote: > Back on 6.2 but now getting > > Creating jjs from 1 file(s) > strip: error: unable to find utility "strip", not a developer tool or in > PATH

Re: Mac build failing

2016-05-09 Thread Pete Brunet
5/9/16 4:03 PM, Pete Brunet wrote: > Going back to 6.2. Hopefully 7.3.1 won't force install itself this time. > > On 5/9/16 3:30 PM, Pete Brunet wrote: >> Further along I got this (after using --disable-warnings-as-errors): >> >> ... >> Compiling 15 files

Re: Mac build failing

2016-05-09 Thread Pete Brunet
Going back to 6.2. Hopefully 7.3.1 won't force install itself this time. On 5/9/16 3:30 PM, Pete Brunet wrote: > Further along I got this (after using --disable-warnings-as-errors): > > ... > Compiling 15 files for jdk.naming.dns > ld: warning: object file > (/Users/pete

Re: Mac build failing

2016-05-09 Thread Pete Brunet
with exit code 1 (use -v to see invocation) make[3]: *** [/Users/petebrunet/JDK9/JDK-8145207/client/build/macosx-x86_64-normal-server-release/support/modules_libs/java.base/libosxsecurity.dylib] Error 1 Pete On 5/9/16 3:17 PM, Pete Brunet wrote: > Thanks. That worked. > > On 5/9/16

Re: Mac build failing

2016-05-09 Thread Pete Brunet
Thanks. That worked. On 5/9/16 3:07 PM, Phil Race wrote: > The usual one --disable-warnings-as-errors when running configure. > > -phil. > > On 05/09/2016 01:11 PM, Pete Brunet wrote: >> Thanks Phil, I asked in the bug but will ask here too - is there a >> workaround

Re: Mac build failing

2016-05-09 Thread Pete Brunet
Thanks Phil, I asked in the bug but will ask here too - is there a workaround until the issue is resolved? In my case I have 6.2 and 7.3.1. Pete On 5/9/16 2:29 PM, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8152856 > > -phil. > > On 05/09/2016 12:20 PM, Pete Brun

Mac build failing

2016-05-09 Thread Pete Brunet
Am running into a build problem on Mac. Creating libjvm.dylib from 771 file(s) In file included from /Users/petebrunet/JDK9/JDK-8145207/client/hotspot/src/share/vm/precompiled/precompiled.hpp:30: In file included from /Users/petebrunet/JDK9/JDK-8145207/client/hotspot/src/share/vm/asm/assembler.inl

Re: small changes, long build time

2016-05-03 Thread Pete Brunet
What is exploded vs not exploded? On 5/3/16 4:55 AM, Erik Joelsson wrote: > > > On 2016-05-03 07:46, Alan Bateman wrote: >> >> >> On 03/05/2016 02:48, David Holmes wrote: >>> >>> So what build target will ensure the exploded image is created and >>> up to date? >> `make` without any target, that h

Re: small changes, long build time

2016-05-02 Thread Pete Brunet
On 4/30/16 2:32 AM, David Holmes wrote: > On 30/04/2016 4:18 PM, Alan Bateman wrote: >> On 30/04/2016 00:46, Pete Brunet wrote: >>> Even small edits to code in the jdk source tree result in very long >>> time >>> build times now that jigsaw is merged in.

small changes, long build time

2016-04-29 Thread Pete Brunet
Even small edits to code in the jdk source tree result in very long time build times now that jigsaw is merged in. Is anyone working on trying to improve that? Is there a workaround? Thanks, Pete

Re: 32 bit build failed

2016-04-26 Thread Pete Brunet
Hi Erik, The boot jdk was 64 bit 8u60 b25. I'll send you a log shortly. -Pete On 4/26/16 4:29 AM, Erik Joelsson wrote: > What do you use as boot jdk? I would recommend using a 64bit JDK 8. > Could you rerun with LOG=debug and send me the build.log? > > /Erik > > On 2016-0

Re: Mac build failing: error: sending 'id' to parameter of incompatible type 'id'

2016-04-26 Thread Pete Brunet
> -phil. > > On 04/01/2016 02:16 PM, Pete Brunet wrote: >> My Mac build is failing today. Maybe something changed with respect to >> the required SDK? >> >> I refreshed my source and rebuilt and this is the output. >> >> Building target 'images&

32 bit build failed

2016-04-25 Thread Pete Brunet
I did a 64 bit build OK but my 32 bit build is failing: Building configuration 'windows-x86-normal-server-release' (matching CONF=windows-x86-normal-server-release) Building target 'images' in configuration 'windows-x86-normal-server-release' Building JVM variant 'server' with features 'all-gcs cd

Mac build failing: error: sending 'id' to parameter of incompatible type 'id'

2016-04-01 Thread Pete Brunet
My Mac build is failing today. Maybe something changed with respect to the required SDK? I refreshed my source and rebuilt and this is the output. Building target 'images' in configuration 'macosx-x86_64-normal-server-release' Compiling 776 files for jdk.xml.bind Compiling 1227 files for java.xm

latest version of XCode?

2016-02-02 Thread Pete Brunet
What is the latest version of XCode we can use to build? I need to reinstall and am currently at 6.2.

Re: RFR: JDK-8143895: Fix LDFLAGS issues after JDK-8056925

2015-11-24 Thread Pete Brunet
Looks good Erik. On 11/24/15 7:00 AM, Erik Joelsson wrote: > Please review this minor build fix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8143895 > Patch: > diff -r 314ce60cae98 make/launcher/Launcher-jdk.accessibility.gmk > --- a/make/launcher/Launcher-jdk.accessibility.gmk Mon Nov

Re: RfR JDK-8056925 Add jaccessinspector and jaccesswalker to the bin directory

2015-11-20 Thread Pete Brunet
http://cr.openjdk.java.net/~ptbrunet/JDK-8056925/webrev.00/ On 11/20/15 10:09 AM, Pete Brunet wrote: > I need to move that to a website that all will have access too. Will be > back with that soon. > > On 11/20/15 10:07 AM, Pete Brunet wrote: >> Please review http://jav

Re: RfR JDK-8056925 Add jaccessinspector and jaccesswalker to the bin directory

2015-11-20 Thread Pete Brunet
I need to move that to a website that all will have access too. Will be back with that soon. On 11/20/15 10:07 AM, Pete Brunet wrote: > Please review http://javaweb.us.oracle.com/~pbrunet/JDK-8056925/webrev.05/

RfR JDK-8056925 Add jaccessinspector and jaccesswalker to the bin directory

2015-11-20 Thread Pete Brunet
Please review http://javaweb.us.oracle.com/~pbrunet/JDK-8056925/webrev.05/

unknown source

2015-10-23 Thread Pete Brunet
What do I need to do so the dumps know where the source is? -Pete Exception in thread "Thread-2" java.lang.RuntimeException: java.lang.NullPointer Exception at com.sun.java.accessibility.AccessBridge$InvocationUtils.invokeAndWait(AccessBridge.java:7202) at com.sun.java.accessibili

Re: RfR JDK-8134453, JAWS crashes in WindowsAccessBridge.DLL on 32 bit 8u60 running on 32 bit Win 7

2015-09-02 Thread Pete Brunet
e headers. I would like that you also change > legacy->LEGACY in CompileJavaClasses.gmk where the headers are generated. > > /Erik > > On 2015-09-02 04:02, Pete Brunet wrote: >> Hi I need two reviewers for >> http://cr.openjdk.java.net/~ptbrunet/JDK-8134453/webrev.00/ >

RfR JDK-8134453,JAWS crashes in WindowsAccessBridge.DLL on 32 bit 8u60 running on 32 bit Win 7

2015-09-01 Thread Pete Brunet
Hi I need two reviewers for http://cr.openjdk.java.net/~ptbrunet/JDK-8134453/webrev.00/ This problem started in 8u60 b20 and is due to JDK-8078649 which is a backport of JDK-8043160. In this fix the text "LEGACY" in file jdk/make/lib/PlatformLibraries.gmk was changed to "legacy". The lower case le

How to make install images

2015-09-01 Thread Pete Brunet
Hi, How do I make an install image (not just the binary trees I see with make images)? I need to do a 32 bit build on 64 bit W7 and then install on a 32 bit W7 VM. In my case the 32 bit install meant for 64 bit W7 isn't suitable for install on a 32 bit W7. Pete

Re: RfR JDK-8055160

2015-06-12 Thread Pete Brunet
Thanks Mandy, The new patch is at http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.04 On 6/10/15 6:29 PM, Mandy Chung wrote: >> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: >> >> Due to some other priorities it's been over 2 months since the last webrev. >&g

Re: RfR JDK-8055160

2015-06-12 Thread Pete Brunet
Thanks Mandy. I need one more review from the awt-dev team. Pete On 6/10/15 6:29 PM, Mandy Chung wrote: >> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: >> >> Due to some other priorities it's been over 2 months since the last webrev. >> An update is here:

Re: RfR JDK-8055160

2015-06-10 Thread Pete Brunet
inked in windows image at the > moment. It is a bug. Are you going to fix that in this changeset? I think > you have to verify this change in windows as well as other platforms. > > Mandy > > >> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: >> >> Due to s

Re: RfR JDK-8055160

2015-06-10 Thread Pete Brunet
Note that I need to remove the import of java.io.PrintWriter in java.awt.Toolkit.java On 6/10/15 5:33 PM, Pete Brunet wrote: > Due to some other priorities it's been over 2 months since the last > webrev. An update is here: > http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/web

Re: RfR JDK-8055160

2015-06-10 Thread Pete Brunet
vider. Instead a file is created when Toolkit.getDefaultToolkit activates providers and tested for existence when the test runs. 2) The copyright header in the new jdk.accessibility files were fixed. Pete On 4/3/15 3:59 PM, Pete Brunet wrote: > Due to the recent push of JDK-8076182 (Open source Jav

RfR JDK-8078335

2015-06-10 Thread Pete Brunet
Please review this simple patch which causes jdk.accessibility to be built for all platforms, not just for Windows. I tested it on Win and Mac. http://cr.openjdk.java.net/~ptbrunet/JDK-8078335/webrev.00/ Pete

Re: need to build a DLL for an openjdk test

2015-06-03 Thread Pete Brunet
On 6/3/15 8:43 PM, Pete Brunet wrote: > Cross posting to build-dev for possible insight regarding Jon's last > paragraph below. > > On 6/3/15 8:13 PM, Jonathan Gibbons wrote: >> On 06/03/2015 04:27 PM, Pete Brunet wrote: >>> Hi, As part of my test I need to bui

need to build a DLL for an openjdk test

2015-06-03 Thread Pete Brunet
Cross posting to build-dev for possible insight regarding Jon's last paragraph below. On 6/3/15 8:13 PM, Jonathan Gibbons wrote: > > On 06/03/2015 04:27 PM, Pete Brunet wrote: >> Hi, As part of my test I need to build a simple DLL and then load it >> from my test class.

RfR JDK-8077296 RE build fails on non-Win builds when attempting to build Win only javadoc

2015-05-20 Thread Pete Brunet
Please review the following change for 8u: http://cr.openjdk.java.net/~ptbrunet/JDK-8077296/webrev.00/ Background: - As part of the open sourcing of the JAB and Java Accessibility Utilities (JAU) the JAU Javadoc was setup to be added to the build. - Due to a 8u build issue (it uses source bundles

Re: MacOSX, jdk8u-dev build break, getting Xcode 4.6.3 set up for Maveriks 10.9.5

2015-05-06 Thread Pete Brunet
p.s. make images ran with no problems. On 5/6/15 3:09 PM, Pete Brunet wrote: > After installing XQuartz, thanks to the text at Problem #1 at > http://mail.openjdk.java.net/pipermail/build-dev/2014-October.txt > using these options worked > --with-freetype-include=/usr/X11/inclu

Re: MacOSX, jdk8u-dev build break, getting Xcode 4.6.3 set up for Maveriks 10.9.5

2015-05-06 Thread Pete Brunet
After installing XQuartz, thanks to the text at Problem #1 at http://mail.openjdk.java.net/pipermail/build-dev/2014-October.txt using these options worked --with-freetype-include=/usr/X11/include/freetype2 --with-freetype-lib=/usr/X11/lib Pete On 5/6/15 2:49 PM, Pete Brunet wrote: > Thanks Da

Re: MacOSX, jdk8u-dev build break, getting Xcode 4.6.3 set up for Maveriks 10.9.5

2015-05-06 Thread Pete Brunet
t;> On 5/6/15 7:51 AM, Vadim Pakhnushev wrote: >>> Hi Pete, >>> >>> How is that? >>> I haven't tried this lately, but I just pulled 8u-dev sources and the >>> option is there: >>> >>> $ sh configure --help >>> >>

Re: MacOSX, jdk8u-dev build break, getting Xcode 4.6.3 set up for Maveriks 10.9.5

2015-05-06 Thread Pete Brunet
10.9 and later) > > Thanks, > Vadim > > On 06.05.2015 15:39, Pete Brunet wrote: >> Hi Vadim, I had to defer from this for a while but am back at it. >> >> Apparently --with-xcode-path isn't currently a valid option. >> >> Pet

Re: MacOSX, jdk8u-dev build break, getting Xcode 4.6.3 set up for Maveriks 10.9.5

2015-05-06 Thread Pete Brunet
> > Thanks, > Vadim > > On 07.04.2015 15:56, Pete Brunet wrote: >> Hi, I need some help so I can build on MacOSX to fix a build break. >> >> First since I had Xcode 6.1.1 and configure complained that I didn't >> have v4 I installed v4.6.3. After instal

Re: build failure after switching to vs2013

2015-04-23 Thread Pete Brunet
he bug David linked, but since the removal of > that code hasn't happened yet, I think we should propose your patch as > a fix for that bug. > > /Erik > > On 2015-04-22 18:00, David Holmes wrote: >> On 23/04/2015 10:57 AM, Pete Brunet wrote: >>> On 4/22/

Re: 9 b58 fails on Win 8 when screen reader running

2015-04-22 Thread Pete Brunet
Hi Erik, It's https://bugs.openjdk.java.net/browse/INTJDK-7615864. On 4/22/15 8:20 PM, Erik Joelsson wrote: > That's an interesting find. I suppose we need to add that linker flag > then. Do you have a bug opened for this issue? > > /Erik > > On 2015-04-22 17:56, Pete

Re: build failure after switching to vs2013

2015-04-22 Thread Pete Brunet
On 4/22/15 6:48 PM, David Holmes wrote: > Peter, > > See > > https://bugs.openjdk.java.net/browse/JDK-8077422 > > update 4 is not supported yet. Hi David, Do I need to uninstall Update 4 and install Update 3? -Pete > > David > > On 23/04/2015 8:02 AM, Pete Brune

Re: 9 b58 fails on Win 8 when screen reader running

2015-04-22 Thread Pete Brunet
elves when this flag is set. Pete On 4/21/15 3:19 PM, Pete Brunet wrote: > Hi Phil, > > On 4/21/15 2:42 PM, Phil Race wrote: >> Perhaps JAWS is not well behaved w.r.t multiple DLL versions ? > Tell me more. >> Does it happen only on win 8 ? If you boot the same system into wi

Re: build failure after switching to vs2013

2015-04-22 Thread Pete Brunet
On 4/22/15 4:52 PM, David Holmes wrote: > On 23/04/2015 7:06 AM, Pete Brunet wrote: >> I was able to build 9 OK then I switched from VS2010 to VS2013 and now >> get the following. I tried hg tpull -u but that didn't help. >> >> Is there something I need to do bes

Re: build failure after switching to vs2013

2015-04-22 Thread Pete Brunet
:= -DHPROF_LOGGING, \ MAPFILE := $(JDK_TOPDIR)/make/mapfiles/libhprof/mapfile-vers, \ Pete On 4/22/15 4:12 PM, Pete Brunet wrote: > p.s. I also had done a make reconfigure and make clean. I'll try make > clean and reconfigure from bash. > > On 4/22/15 4:06 PM, Pete Brunet wro

Re: build failure after switching to vs2013

2015-04-22 Thread Pete Brunet
p.s. I also had done a make reconfigure and make clean. I'll try make clean and reconfigure from bash. On 4/22/15 4:06 PM, Pete Brunet wrote: > I was able to build 9 OK then I switched from VS2010 to VS2013 and now > get the following. I tried hg tpull -u but that didn't hel

build failure after switching to vs2013

2015-04-22 Thread Pete Brunet
I was able to build 9 OK then I switched from VS2010 to VS2013 and now get the following. I tried hg tpull -u but that didn't help. Is there something I need to do besides installing VS Pro 2013 with Update 4? $ make images 2>&1 | tee make-64.log Building target 'images' in configuration 'windo

Re: 9 b58 fails on Win 8 when screen reader running

2015-04-21 Thread Pete Brunet
th VS2013 > > Does it happen if you use javaw instead of java ? Same behavior: splash screen, then back to the prompt. > > -phil. > > On 04/21/2015 11:53 AM, Pete Brunet wrote: >> Starting with b58 with JAWS (screen reader) running on Win 8, when >> starting SwingSet2 th

9 b58 fails on Win 8 when screen reader running

2015-04-21 Thread Pete Brunet
Starting with b58 with JAWS (screen reader) running on Win 8, when starting SwingSet2 the splash screen appears but the application doesn't start. There are no messages in the console. I see b58 only had one fix: 8076531 infrastructure Switch default compiler on Windows to VS2013 What might be

Re: RfR JDK-8076552 nightly build break fix

2015-04-08 Thread Pete Brunet
I added 9-na. > > Rule 4. Approval requests should be carried out on jdk8u-dev mailing > list. I did the RfA on jdk8u-dev (but am pending the start/run/success of the 7 JPRT builds). > > regards, > Sean. > > On 08/04/2015 19:14, Pete Brunet wrote: >> resending - too man

Re: RfR JDK-8076552 nightly build break fix

2015-04-08 Thread Pete Brunet
> > Do you have a forest on nfs? (from where I can pull/clone your fixes)? > > - Lana > > > On 04/08/2015 11:08 AM, Pete Brunet wrote: >> I confirmed the javadoc is gone, and make docs did not fail. >> >> I have yet to submit the JPRT job. >> >&g

Re: RfR JDK-8076552 nightly build break fix

2015-04-08 Thread Pete Brunet
: > That looks good to me. > > -phil. > > On 4/8/2015 10:55 AM, Pete Brunet wrote: >> How's this? >> http://cr.openjdk.java.net/~ptbrunet/JDK-8076552/webrev.03 >> >> On 4/8/15 12:47 PM, Mandy Chung wrote: >>> I agree with Phil's suggesti

Re: RfR JDK-8076552 nightly build break fix

2015-04-08 Thread Pete Brunet
resending - too many on To:/Cc: On 4/8/15 1:08 PM, Pete Brunet wrote: > I confirmed the javadoc is gone, and make docs did not fail. > > I have yet to submit the JPRT job. > > Sean/Winston do you want to wait for the 7 JPRT jobs to finish before > you approve the push? > &

Re: RfR JDK-8076552 nightly build break fix

2015-04-08 Thread Pete Brunet
enerated for this package on windows build. > > Mandy > > On 4/8/2015 10:29 AM, Phil Race wrote: >> Isn't it sufficient to comment out this one line ? >> >> 1215 ALL_OTHER_TARGETS += jaccessdocs >> >> .. and add a comment as to why ? >> >&g

Re: RfR JDK-8076552 nightly build break fix

2015-04-08 Thread Pete Brunet
t will work I'll redo the patch. Let me know. > > -phil. > > > On 04/08/2015 10:25 AM, Pete Brunet wrote: >> Here is an updated patch. >> http://cr.openjdk.java.net/~ptbrunet/JDK-8076552/webrev.02/ >> >> It simply removes the com.sun.java.accessibility.

Re: RfR JDK-8076552 nightly build break fix

2015-04-08 Thread Pete Brunet
approval. I have started a local Win build and will start JPRT builds on Linux, Windows, Solaris, and Mac shortly. Thanks, Pete On 4/8/15 12:51 AM, Pete Brunet wrote: > Please review/approve the following patch. > > http://cr.openjdk.java.net/~ptbrunet/JDK-8076552/webrev.01/ > > The

Re: RfR JDK-8076552 nightly build break fix

2015-04-08 Thread Pete Brunet
David, Considering that the source should be in jdk/src/share/classes does that change things? -Pete > > David > > On 8/04/2015 3:51 PM, Pete Brunet wrote: >> Please review/approve the following patch. >> >> http://cr.openjdk.java.net/~ptbrunet/JDK-8076552/webrev.01/

Re: RfR JDK-8076552 nightly build break fix

2015-04-08 Thread Pete Brunet
ndy > > On 4/7/2015 10:51 PM, Pete Brunet wrote: >> Please review/approve the following patch. >> >> http://cr.openjdk.java.net/~ptbrunet/JDK-8076552/webrev.01/ >> >> The recent push for JDK-8076182 caused a build break, i.e. a problem for >> the creation

RfR JDK-8076552 nightly build break fix

2015-04-07 Thread Pete Brunet
Please review/approve the following patch. http://cr.openjdk.java.net/~ptbrunet/JDK-8076552/webrev.01/ The recent push for JDK-8076182 caused a build break, i.e. a problem for the creation of the Javadoc in the environment used by the nightly build. This was because a newly opened package com.su

MacOSX, jdk8u-dev build break, getting Xcode 4.6.3 set up for Maveriks 10.9.5

2015-04-07 Thread Pete Brunet
Hi, I need some help so I can build on MacOSX to fix a build break. First since I had Xcode 6.1.1 and configure complained that I didn't have v4 I installed v4.6.3. After installing 4.6.3 and doing sudo xcode-select -s /Applications/Xcode\ 4.6.3.app/ I got past that. Then for some reason my comp

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
that its safe > to remove that copy for closed builds anyway > > I think the safe thing to do is undo that change in Copy-java.gmk > and leave the closed file in place and discuss off-line with the > security team why the files differ .. I'll start a discussion on this. >

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
Hi Sergey, Which methods are you referring to? -Pete On 3/25/15 10:16 AM, Sergey Bylokhov wrote: > The fix looks fine. > But it is interesting, do we have an option to remove all deprecated > methods during this opening? or can we do it later? or we cannot? > > 25.03.15 17:44, Pe

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
ild so no > reason to remove them. Thanks Erik, My build and tests ran OK so apparently they are no longer needed. To all: My hope is to push this patch into 9 tomorrow (Thursday) so please let me know if there are any additional issues as soon as you can. Pete > > /Erik > > On

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
On 3/24/15 3:23 PM, Pete Brunet wrote: > Hi Sergey, That's pretty much the case. I just went through the code > and found these differences: > - merged in JDK-8055173 (merge jawt.dll into javaaccessbridge.dll) which > was recently pushed. That should have been jawtaccessbridge.

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Pete Brunet
t and Monkey test tools which will be the subject of a later patch - removed the DEF files; although they were used in the build, there are no build or runtime problems after their removal On 3/24/15 8:08 AM, Magnus Ihse Bursie wrote: > On 2015-03-23 18:31, Pete Brunet wrote: >> Hi Erik,

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Pete Brunet
understand correctly that the code itself were not changed except > files location? > > 21.03.15 7:33, Pete Brunet wrote: >> Please review the following patch which will add the code of the Java >> Access Bridge (JAB) and related Java Accessibility Utilities to OpenJDK. >

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-23 Thread Pete Brunet
ridge.DEF is pretty empty. I'll see if the build will work without it. WinAccessBridge.DEF seems like it might be needed. What do you think? Pete > > /Erik > > On 2015-03-21 05:33, Pete Brunet wrote: >> Please review the following patch which will add the code of the

RfR JDK-8055831 Open Source Java Access Bridge

2015-03-20 Thread Pete Brunet
Please review the following patch which will add the code of the Java Access Bridge (JAB) and related Java Accessibility Utilities to OpenJDK. This code is used by Assistive Technology such as screen readers and screen magnifiers used by those who are blind or have low vision. AT use the JAB nati

Re: [8u40]: RFR 8059136: Reverse removal of applet demos

2014-09-29 Thread Pete Brunet
Hi Daniil, I reviewed the two webrevs original change: http://cr.openjdk.java.net/~dtitov/8015376/webrev.00 backout: http://cr.openjdk.java.net/~dtitov/8059136/webrev.00/ and saw no problems with the backout of the original change. Pete On 9/26/14, 3:48 PM, Daniil Titov wrote: > Hi, > > Please

Request for review of make changes for JDK-8041507, Java Access Bridge version strings need to be fixed

2014-04-23 Thread Pete Brunet
Please review the open part of the change for this fix: JDK-8041507 Java Access Bridge version strings need to be fixed https://bugs.openjdk.java.net/browse/JDK-8041507 Change: Some variables needed to be set for use by the RC phase of the build of jabswitch.exe. The closed part of the fix is a

Re: jdk7u full build fails on Win - unable to load zip.dll

2014-04-22 Thread Pete Brunet
e/jdk7/jdk/make' make[1]: *** [jdk-build] Error 2 make[1]: Leaving directory `/cygdrive/c/Users/Pete/JDK7u/jdk7-clone/jdk7' make: *** [build_product_image] Error 2 I noticed my 4G was maxed out so I rebooted and that issues was resolved. BTW, I prefer a local build because I have a bunch of

Re: building 7u on macosx

2014-04-21 Thread Pete Brunet
On 4/21/14 9:30 PM, David Holmes wrote: > On 19/04/2014 5:25 AM, Pete Brunet wrote: >> Success. I found this post from Arun Gupta: >> https://blogs.oracle.com/arungupta/entry/build_open_jdk_7_on >> >> which specifies this >> >> make ALLOW

Re: jdk7u full build fails on Win - unable to load zip.dll

2014-04-18 Thread Pete Brunet
p.s. The ALT_BOOTDIR specifies 6u45. On 4/18/14 4:53 PM, Pete Brunet wrote: > A full 7u build currently fails like this: > > make[6]: Entering directory > `/cygdrive/c/Users/Pete/JDK7u/jdk7-clone/jdk7/jdk/make/com/sun/jmx' > /usr/bin/mkdir -p > C:/Users/Pete/JDK7u/jdk7-c

jdk7u full build fails on Win - unable to load zip.dll

2014-04-18 Thread Pete Brunet
A full 7u build currently fails like this: make[6]: Entering directory `/cygdrive/c/Users/Pete/JDK7u/jdk7-clone/jdk7/jdk/make/com/sun/jmx' /usr/bin/mkdir -p C:/Users/Pete/JDK7u/jdk7-clone/jdk7/build/windows-i586/../windows-i586-fastdebug/classes/javax/management/remote/rmi rm -f C:/Users/Pete/JDK7

Re: building 7u on macosx

2014-04-18 Thread Pete Brunet
t; LANG=C - Add this: SA_APPLE_BOOT_JAVA=true ALWAYS_PASS_TEST_GAMMA=true I didn't yet investigate if there is a subset of the changes that would be successful. Pete On 4/18/14 1:43 PM, Pete Brunet wrote: > I see Mac downloads for 7u55 so I should be able to build 7u. But t

Re: building 7u on macosx

2014-04-18 Thread Pete Brunet
x. Pete On 4/18/14 11:59 AM, Pete Brunet wrote: > Maybe 7 is not supported? The reason I am trying to build it is to back > port two bugs from 9, but maybe that's not needed. > > On 4/18/14 11:39 AM, Pete Brunet wrote: >> Hi, It's been a long time since I bui

  1   2   3   >