Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v4]

2021-05-25 Thread Remi Forax
- Mail original - > De: "Evgeny Mandrikov" > À: "build-dev" , "compiler-dev" > , "core-libs-dev" > , "javadoc-dev" > Envoyé: Mardi 25 Mai 2021 11:32:03 > Objet: Re: RFR: 8262891: Compiler implementation for Pattern Matching for > switch (Preview) [v4] > On Mon, 17 May 2021 19:01:01 GMT

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

2020-11-17 Thread Remi Forax
An honest question, why do we need so many interfaces for the different categories of RandomGenerator ? My fear is that we are encoding the state of our knowledge of the different kinds of random generators now so it will not be pretty in the future when new categories of random generator are d

Re: RFR: JDK-8241310 Fix warnings in jdk buildtools

2020-03-19 Thread Remi Forax
Hi Magnus, please try not to use @SuppressWarnings("unchecked") on methods, but on local variable instead to reduce the scope, you can introduce a local variable for that. In Bundle, your patch declare @SuppressWarnings("unchecked") on the method while you already have a local variable with a @

Re: RFR : JDK-8202387: javac --release 11 not supported

2018-05-04 Thread Remi Forax
Hi Jan, there is several occurences of Arrays.asList() that can be replaced by List.of() to make them really immutable. in CreateSymbols.java in dumpCurrentClasses, while ((read = in.read()) != (-1)) { baos.write(read); } should be replaced by in.transferTo(baos); in T