Apologies, I missed this request. (errant email filters)
Approved retroactively.
Please do follow the approval request template for future requests
however. [1]
Review thread:
http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-September/007802.html
Bug: https://bugs.openjdk.java.net/browse/J
t; Thanks,
> Severin
>
> On Tue, 2018-05-08 at 14:09 +0100, Rob McKenna wrote:
> > Ahem: http://openjdk.java.net/census#jdk-updates
> >
> > -Rob
> >
> > On 08/05/18 14:08, Rob McKenna wrote:
> > > (also, according to http://db.openjdk.java.net/peo
g custom file, if present.
> $(eval $(call IncludeCustomExtension, jdk, lib/CoreLibraries.gmk))
>
> /Erik
>
>
> On 2017-06-06 19:01, Rob McKenna wrote:
> >Hi folks,
> >
> >We've found it useful to be able to override LIBJAVA_SRC_DIRS /
> >LIBJAVA_MAPFILE
Hi folks,
We've found it useful to be able to override LIBJAVA_SRC_DIRS /
LIBJAVA_MAPFILE in libjava. This change in 10 allows the former and
backports the latter to 8:
http://cr.openjdk.java.net/~robm/8173654/
Thanks,
-Rob
Hi Christian,
I'm cc'ing build-dev (and bcc'ing jdk8u-dev) as that may be a more appropriate
venue for this discussion.
-Rob
On 03/03/17 10:19, Christian Thalinger wrote:
> At Twitter we are using the custom extension mechanism to separate our
> additional code from upstream in order to min
Approved. (not sure why I didn't explicitly state that in the last mail)
-Rob
On 08/01/16 13:56, Andrew Hughes wrote:
- Original Message -
Looks good.
/Erik
Thanks Erik. Pushed:
http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/92c6a16b6dac
On 2016-01-06 20:12
cc'ing build-dev for a review and updating the subject.
-Rob
On 06/01/16 19:10, Andrew Hughes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8146566
Webrev: http://cr.openjdk.java.net/~andrew/8u/8146566/webrev.01/
If additional LDFLAGS containing commas are passed to the build e.
Approved.
-Rob
On 30/09/15 14:30, Magnus Ihse Bursie wrote:
On 2015-09-30 14:43, Erik Joelsson wrote:
Hello,
Please approve and review this fix for 8u.
My last fix for this issue, JDK-8136691, was not enough. I made a
mistake while verifying the fix and the problem is still there.
T
Approved. Please add a suitable noreg keyword.
-Rob
On 06/03/15 14:41, Magnus Ihse Bursie wrote:
Requesting approval to backport this JDK9 fix to jdk8u-dev.
Bug: https://bugs.openjdk.java.net/browse/JDK-8074554
Original JDK9 changeset:
http://hg.openjdk.java.net/jdk9/client/rev/8b9bd5ba44
() ?
---
+r = sscanf (argv[argc-1], "%d:%d", &fdin, &fdout);
How about checking for argc == 2 ?
Martin
On Wed, Dec 19, 2012 at 6:28 PM, Rob McKenna <mailto:rob.mcke...@oracle.com>> wrote:
Hi folks,
Thanks for the feedback so far. I've uploaded a new w
t/pipermail/core-libs-dev/2009-June/001747.html
-Rob
On 30/11/12 03:48, Rob McKenna wrote:
Hi David,
On 30/11/12 02:31, David Holmes wrote:
Hi Rob,
This is only a superficial scan.
The changes in java/java/makefile look pretty horrible. What are all
those -R entries?
Library search
11 matches
Mail list logo
