RFR 8243576: Remove residual reference to nashorn modules in make/CompileJavaModules.gmk

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8243576 Webrev: http://cr.openjdk.java.net/~sundar/8243576/webrev.00/ Thanks, -Sundar

Re: RFR 8241749: Remove the Nashorn JavaScript Engine

Thanks Mandy. I'll add bug id next to @ignore before push. Thanks, -Sundar On 16/04/20 2:50 am, Mandy Chung wrote: This looks okay to me. Can you add the bug ID next to @ignore that will make it easier to find the JBS issue?   These test bugs are filed with P4 but I think they should be

Re: RFR 8241749: Remove the Nashorn JavaScript Engine

Thanks for spotting this Magnus! I'll fix this before push. Thanks. -Sundar On 15/04/20 10:44 pm, Magnus Ihse Bursie wrote: On 2020-04-15 17:56, sundararajan.athijegannat...@oracle.com wrote: Please review. Nashorn script engine modules (jdk.scripting.nashorn, jdk.scripting.nashorn.shell)

RFR 8241749: Remove the Nashorn JavaScript Engine

Please review. Nashorn script engine modules (jdk.scripting.nashorn, jdk.scripting.nashorn.shell) and jjs tool are removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8241749 JEP: https://openjdk.java.net/jeps/372 CSR: https://bugs.openjdk.java.net/browse/JDK-8241751 Webrev:

Re: gnu make 4.3 breaks the build

CC: build-dev On 27/01/20 4:55 am, Michael Zucchi wrote: I'm sure if it hasn't it'll come up on the other openjdk lists, but this is the only one i'm on so i'll post it here. slackware-current updated gnu make to 4.3 a few days ago and it breaks the build.  Make just fails immediately with

Mac OS (Mojave / Xcode 10.3) build issue..

Hi, After recent OS and Xcode upgrade (Mojave 10.14.6 and Xcode 10.3), I'm seeing JDK build failures on my machine. Bboth "jdk-dev" and "panama-dev" foreign branch. It is a fresh configure & clean build. "nm" is selected from /usr/local/bin/nm and that is from bintools 2.32 (homebrew

Re: RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

, then -Xlint:all,-deprecation should be enough to add. The current argument for jdk.scripting.nashorn is -Xlint:all (if I'm not mistaken). /Erik On 2018-06-27 08:59, Sundararajan Athijegannathan wrote: Hi Erik, Yes, nashorn is warning free afaik. Besides nashorn is being deprecated. No further

Re: RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

PM, Erik Joelsson wrote: Hello Sundar, Adding $(DISABLE_WARNINGS) disables a lot of warnings. Isn't jdk.scripting.nashorn pretty much warning frree now? What warnings do you really need to disable? /Erik On 2018-06-26 21:19, Sundararajan Athijegannathan wrote: Forgot to CC build-dev

Re: RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

Forgot to CC build-dev for makefile changes. -Sundar On 27/06/18, 9:46 AM, Sundararajan Athijegannathan wrote: Please review. Bug https://bugs.openjdk.java.net/browse/JDK-8204492 Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01 Related: JEP http://openjdk.java.net/jeps/335 CSR

Re: RFR: JDK-8199682 Clean up building the saproc library

-dev from the cc list... 16 mars 2018 kl. 06:14 skrev Sundararajan Athijegannathan <sundararajan.athijegannat...@oracle.com>: Renaming sawindbg as saproc sounds odd. For Linux, Solaris/Unix, we either use /proc & libproc, so calling saproc for those makes sense. But Windows? We have

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

We run nasgen tool on the generated nashorn .class files to post-process. nasgen used to run on boot JDK in the past (if I recall right). I'm fine with current change is okay - so long as nasgen works fine & nashorn tests run fine. Please note that nashorn tests are run with "ant". cd

RFR 8171316: Add IMPLEMENTOR property to the release file

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8171316 top level webrev: http://cr.openjdk.java.net/~sundar/8171316/top/webrev.00/ jdk webrev: http://cr.openjdk.java.net/~sundar/8171316/jdk/webrev.00/ Thanks, -Sundar

Re: RFR 8163320: JAVA_VERSION in release file should come from java.base module

ood. > > Is there an existing test to check the content of `release` file? It would > be good to have a test to sanity test a few properties and its quoted value. > > Mandy > >> On Sep 9, 2016, at 6:02 AM, Sundararajan Athijegannathan >> <sundararajan.athijegannat...@or

RFR 8163320: JAVA_VERSION in release file should come from java.base module

Please review fix for https://bugs.openjdk.java.net/browse/JDK-8163320 jdk repo: http://cr.openjdk.java.net/~sundar/8163320/jdk/ * JAVA_VERSION is derived from module-info of java.base * adding quotes around all 'release' properties top repo:

Re: RFR 8165595: Main class should be set for nashorn modules

7 14:38, Alan Bateman wrote: >> On 07/09/2016 13:27, Sundararajan Athijegannathan wrote: >> >>> jjs does not yet support module related options. So, user modules can >>> not be scripted directly with jjs as of now. Only way is to use to >>> launcher with -mp alo

Re: RFR 8165595: Main class should be set for nashorn modules

- but couldn't. I'm open to suggestions on how to do that in the current scheme. -Sundar On 9/7/2016 5:48 PM, Alan Bateman wrote: > On 07/09/2016 13:10, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8165595/webrev.01/ for >> https://bugs.openjdk.j

RFR 8165595: Main class should be set for nashorn modules

Please review http://cr.openjdk.java.net/~sundar/8165595/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8165595 Thanks -Sundar

Re: RFR: 8160505, Automated test runs fail in nashorn because TEST_IMAGE_DIR is set by jib

Looks good Yes, nashorn will not get any native tests. -Sundar On 6/29/2016 4:25 PM, Erik Joelsson wrote: > Looks ok to me. > > It's unlikely that nashorn will ever get native tests so just removing > this functionality is a good solution. If we expected nashorn to need > native tests anytime

Re: RFR 8156847: jdk.dynalink package is shown under "Other Packages" section

ote: > As a makefile change this looks fine, but I have no clue as to what > that line actually means for javadoc. > > /Erik > > On 2016-05-16 17:08, Sundararajan Athijegannathan wrote: >> Please review http://cr.openjdk.java.net/~sundar/8156847/webrev.00/ for >> https://bug

RFR 8156847: jdk.dynalink package is shown under "Other Packages" section

Please review http://cr.openjdk.java.net/~sundar/8156847/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8156847 Thanks, -Sundar

RFR 8152268: jjs tool makefile should use --addmods ALL-SYSTEM

Hi, Please review http://cr.openjdk.java.net/~sundar/8152268/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8152268 Thanks, -Sundar

RFR 8148617: top level make docs target does not generate javadocs for dynalink API

Please review http://cr.openjdk.java.net/~sundar/8148617/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8148617 Dynalink API is specified by JEP-276 (http://openjdk.java.net/jeps/276). The current change is just to add the missing makefile instructions to generate javadoc. Thanks,

Re: RFR 8148617: top level make docs target does not generate javadocs for dynalink API

Added newline before line 1270 in Javadoc.gmk. Updated webrev: http://cr.openjdk.java.net/~sundar/8148617/webrev.01/ -Sundar On 1/29/2016 9:53 PM, Hannes Wallnoefer wrote: Looks good. Hannes Am 2016-01-29 um 17:13 schrieb Sundararajan Athijegannathan: Please review http

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

+1 Nashorn changes and modules.xml changes look good to me. -Sundar On 9/16/2015 7:35 PM, Attila Szegedi wrote: On Sep 16, 2015, at 2:51 PM, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please

RFR 8134260: jjs in jre directory fails with Could not find or load main class jdk.nashorn.tools.jjs.Main

Hi, Please review http://cr.openjdk.java.net/~sundar/8134260/ for https://bugs.openjdk.java.net/browse/JDK-8134260 jdk.nashorn.tools.jjs and jdk.internal.le should exist in jre's appmodules.jimage with this change and so jjs would work in JRE. Also, jjs launcher tool was created from wrong

Re: RFR 8133347: Add makefiles support and basic session, persistence history navigation with jline

, Sundararajan Athijegannathan wrote: Hi, Please review changes for the bug: https://bugs.openjdk.java.net/browse/JDK-8133347 This is a subtask of jjs should use jline https://bugs.openjdk.java.net/browse/JDK-8080678 This subtask addresses infrastructure changes (module.xml, makefiles

Re: RFR 8133347: Add makefiles support and basic session, persistence history navigation with jline

Updated only the top webrev: http://cr.openjdk.java.net/~sundar/8133347/top/webrev.01/ Thanks, -Sundar On 8/13/2015 12:47 PM, Sundararajan Athijegannathan wrote: Hi, Thanks. I'll fix it. -Sundar On 8/13/2015 12:43 PM, Erik Joelsson wrote: Hello Sundar, Build changes look ok. I would

Re: RFR 8133347: Add makefiles support and basic session, persistence history navigation with jline

(although I am not an expert on the build system changes, etc.) Jan On 12.8.2015 19:03, Sundararajan Athijegannathan wrote: Hi, Please review changes for the bug: https://bugs.openjdk.java.net/browse/JDK-8133347 This is a subtask of jjs should use jline https://bugs.openjdk.java.net/browse/JDK

RFR 8133347: Add makefiles support and basic session, persistence history navigation with jline

Hi, Please review changes for the bug: https://bugs.openjdk.java.net/browse/JDK-8133347 This is a subtask of jjs should use jline https://bugs.openjdk.java.net/browse/JDK-8080678 This subtask addresses infrastructure changes (module.xml, makefiles, security policy) and basic jjs use of