Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v5]

2022-03-11 Thread Thomas Schatzl
On Mon, 28 Feb 2022 16:22:25 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v4]

2022-02-22 Thread Thomas Schatzl
On Tue, 8 Feb 2022 08:17:17 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x

Re: RFR: 8278885: Remove Windows ARM64 int8_t workaround in G1

2022-01-13 Thread Thomas Schatzl
On Thu, 16 Dec 2021 23:44:55 GMT, aamarsh wrote: > Please review this small change to revert a previous workaround that avoided > an MSVC issue. > > This issue has now been fixed in VS 16.8 and higher. > > I also updated some documentation to reflect this change. GC changes look good.

Re: RFR: 8272113: Build compare script fails with differences in classlist

2021-08-09 Thread Thomas Schatzl
On Sat, 7 Aug 2021 07:25:01 GMT, Ioi Lam wrote: > The CDS classlist is generated with the `-XX:DumpLoadedClassList` option, > which writes the name of the classes as they are being loaded. Since class > loading order is affected by thread switching, the classes may appear in a > non-determinis

Re: RFR : 8211213: fix aix build after 8196341: Add JFR events for parallel phases of G1

2018-09-28 Thread Thomas Schatzl
Hi, On Fri, 2018-09-28 at 12:51 +0200, Aleksey Shipilev wrote: > On 09/28/2018 12:47 PM, Thomas Schatzl wrote: > > Btw, I closed out a few bugs created in JIRA as apparent duplicate > > of > > this one. If there is something wrong with that, please reopen with > > a >

Re: RFR : 8211213: fix aix build after 8196341: Add JFR events for parallel phases of G1

2018-09-28 Thread Thomas Schatzl
Hi, On Fri, 2018-09-28 at 06:53 +, Baesken, Matthias wrote: > Hi Aleksey, sounds great - thanks for looking into this JFR > generating stuff and figuring out what to do where 😊 ! > > So I guess we do not need my AIX-related patch any more , > after your change is in ( and the co

Re: RFR : 8211213: fix aix build after 8196341: Add JFR events for parallel phases of G1

2018-09-28 Thread Thomas Schatzl
Hi, On Thu, 2018-09-27 at 20:03 +0200, Aleksey Shipilev wrote: > On 09/27/2018 04:39 PM, Baesken, Matthias wrote: > > Hi Thomas, do you know some fast and helpful person who can bring > > the INCLUDE_JFR and ! INCLUDE_JFR cases in sync ? > > (or maybe there was a reason to have these difference

Re: RFR : 8211213: fix aix build after 8196341: Add JFR events for parallel phases of G1

2018-09-27 Thread Thomas Schatzl
Hi, On Thu, 2018-09-27 at 14:16 +, Baesken, Matthias wrote: > Small update - while my change fixes the build issues on > AIX (and maybe also the issues on zero) , > My comment that the AIX compiler xlc12 is guilty was most likely > wrong . > > What happens, is that INCLUDE_JFR is

Re: RFR (XXS): 8208672: Enable -Wreorder in make files

2018-08-07 Thread Thomas Schatzl
Hi David, On Tue, 2018-08-07 at 07:17 +1000, David Holmes wrote: > Hi Thomas, > > On 6/08/2018 10:38 PM, Thomas Schatzl wrote: > > Hi David, > > > > On Fri, 2018-08-03 at 10:20 +1000, David Holmes wrote: > > > Hi Thomas, > > > > > > On 2

Re: RFR (XXS): 8208672: Enable -Wreorder in make files

2018-08-06 Thread Thomas Schatzl
Hi David, On Fri, 2018-08-03 at 10:20 +1000, David Holmes wrote: > Hi Thomas, > > On 2/08/2018 7:14 PM, Thomas Schatzl wrote: > > Hi all, > > > >there have been several suggestions to try to fix the Hotspot > > code to allow us to enable -Wreorder in the

Re: RFR (XXS): 8208672: Enable -Wreorder in make files

2018-08-02 Thread Thomas Schatzl
Hi, note: I have only been able to build Oracle platforms (x64-linux, osx, sparc-solaris, win64) with this enabled. It would be nice to get confirmation that other platforms will not break. Thanks, Thomas On Thu, 2018-08-02 at 11:14 +0200, Thomas Schatzl wrote: > Hi all, > > t

RFR (XXS): 8208672: Enable -Wreorder in make files

2018-08-02 Thread Thomas Schatzl
Hi all, there have been several suggestions to try to fix the Hotspot code to allow us to enable -Wreorder in the Hotspot sources. This should make problems due to use-before-initialization much more obvious. This change enables -Wreorder for gcc and clang. Of course it needs all previous RFRs

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-15 Thread Thomas Schatzl
Hi, On Wed, 2018-02-14 at 13:45 -0800, sangheon.kim wrote: > Hi all, > > Could I have some reviews for CMM removal? > This is closed CR but some public codes also need small > modifications. > This CR is for removing stuff related to an Oracle JDK > module/package. > Changes are just removing CM

Re: RFR: 8166790: Add stress test GCBasher

2016-10-07 Thread Thomas Schatzl
Hi, On Thu, 2016-10-06 at 16:38 +0200, Erik Helin wrote: > David, Dmitry, > > below you will find new patches: > - incremental: http://cr.openjdk.java.net/~ehelin/8166790/hotspot/02- > 03/ > - full: http://cr.openjdk.java.net/~ehelin/8166790/hotspot/03/ > > I've fixed the indentation of the comm

Re: RFR: 8166790: Add stress test GCBasher

2016-09-29 Thread Thomas Schatzl
Hi, On Wed, 2016-09-28 at 17:01 +0200, Erik Helin wrote: > Hi all, > > this patch adds a new GC stress test called GCBasher. GCBasher builds > up > large (well, for some definiton of large) object graphs by figuring > out > the relations between classes in the JDK. The test usually stresses > the

Re: RFR(XS): JDK-8114853 variable tracking size limit exceeded in vmStructs.cpp

2015-12-03 Thread Thomas Schatzl
Hi, On Thu, 2015-12-03 at 16:53 +0300, Dmitry Samersoff wrote: > Everybody, > > I'd followed common opinion and turn off tracking of variable assignment > for vmStructs file only. > > Updated webrev is here: > > http://cr.openjdk.java.net/~dsamersoff/JDK-8114853/webrev.02/ looks good. Thanks

Re: RFR (XS): 8141134: Remove unnecessary pragma warning(disable:4355) from GC code

2015-11-04 Thread Thomas Schatzl
Hi, On Wed, 2015-11-04 at 12:12 +0100, Volker Simonis wrote: > Hi Erik, > > thanks a lot for your understanding :) > > Your suggestion is perfectly fine for me and we can live with both > versions of the fix. I went for the change in the globalDefinitions* file. New webrevs: http://cr.openj