Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v9]

2021-05-19 Thread Vladimir Ivanov
On Wed, 19 May 2021 03:37:11 GMT, Sandhya Viswanathan wrote: >> This PR contains Short Vector Math Library support related changes for >> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), >> in preparation for when targeted. >> >> Intel Short Vector Math Library (SVM

Re: RFR: 8264188: Improve handling of assembly files in the JDK [v2]

2021-04-14 Thread Vladimir Ivanov
On Mon, 29 Mar 2021 10:48:55 GMT, Magnus Ihse Bursie wrote: >> We have a handful of assembly files in the JDK. They have long been left >> aside, with a "if it ain't broken, don't fix it" attitude. >> >> In the current panama-vector, there is a lot more assembly files incoming, >> including f

Re: RFR: 8256414: add optimized build to submit workflow

2020-11-17 Thread Vladimir Ivanov
ized configuration built there. Best regards, Vladimir Ivanov On 2020-11-16 19:33, Igor Ignatyev wrote: Hi all, Could you please review this small and trivial patch which adds `linux-x64-optimized` build to submit workflow so breakages of this build flavor would be easier to spot? Thanks,

Re: RFR: 8256430: add linux-x64-optimized to tier1

2020-11-17 Thread Vladimir Ivanov
On Tue, 17 Nov 2020 00:31:24 GMT, Igor Ignatyev wrote: > Hi all, > > > [8256414](https://bugs.openjdk.java.net/browse/JDK-8256414) / #1233 added > similar profile to submit workflow, this patch defines `linux-x64-optimized` > profile in jib-profile so it can be used by mach5 and added to tie

Re: RFR: 8256414: add optimized build to submit workflow

2020-11-16 Thread Vladimir Ivanov
On Mon, 16 Nov 2020 18:26:18 GMT, Igor Ignatyev wrote: > Hi all, > > Could you please review this small and trivial patch which adds > `linux-x64-optimized` build to submit workflow so breakages of this build > flavor would be easier to spot? > > Thanks, > -- Igor Thanks a lot, Igor! Looks g

Re: RFR: 8255616: Disable AOT and Graal in Oracle OpenJDK

2020-11-01 Thread Vladimir Ivanov
On Fri, 30 Oct 2020 17:40:51 GMT, Vladimir Kozlov wrote: > We shipped Ahead-of-Time compilation (the jaotc tool) in JDK 9, as an > experimental feature. We shipped Graal as an experimental JIT compiler in JDK > 10. We haven't seen much use of these features, and the effort required to > suppor

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-21 Thread Vladimir Ivanov
Vladimir, if you're okay with it I'd like to propose this as a patch to the problem instead: http://cr.openjdk.java.net/~ihse/JDK-8217404-fix-multiple-disabled-jvm-features/webrev.01 Looks good! I verified that it fixes the bug. Best regards, Vladimir Ivanov On Jan 18, 2019,

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Vladimir Ivanov
Updated webrev: http://cr.openjdk.java.net/~vlivanov/8217404/webrev.01 Verified that it works as expected on Linux, Windows, MacOS, and Solaris. Best regards, Vladimir Ivanov On 18/01/2019 16:39, Vladimir Ivanov wrote: Thanks, Igor. overall your fix looks reasonable, but w/ it we can get

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Vladimir Ivanov
this case you will need to revert your changes in 'if test ...' lines I'm in favor of using "-w" and I see different grep flags being used already, but would like somebody from Build team confirm they are OK with such solution. Best regards, Vladimir Iva

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Vladimir Ivanov
nternal.vm.ci should be built... yes checking if graal module jdk.internal.vm.compiler should be built... yes checking if aot should be enabled... yes Best regards, Vladimir Ivanov On 1/18/19 3:33 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8217404/webrev.00/ https://bugs.ope

[13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Vladimir Ivanov
aal module jdk.internal.vm.compiler should be built... no, forced checking if aot should be enabled... no, forced ... (The fix doesn't address the case when one feature has a name which is a proper substring of another feature, but there are no such cases at the moment.) Best regards, Vladimir Ivanov

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

2018-08-28 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~iignatyev//8209611/webrev.02/index.html Reviewed. Best regards, Vladimir Ivanov On Aug 20, 2018, at 11:07 PM, Igor Ignatyev wrote: It has been discussed (not widely enough and I accept that) in 8209547 and the related email thread b/w JC(cc'ed) and m

Re: How to disable JVM features?

2017-12-04 Thread Vladimir Ivanov
Thanks, Magnus! That works for me. Best regards, Vladimir Ivanov On 12/1/17 11:33 PM, Magnus Ihse Bursie wrote: You cannot disable features. However, you can create your own complete set of features. Use --with-jvm-variants=custom. The custom variant starts out with a comletely empty set of

How to disable JVM features?

2017-11-30 Thread Vladimir Ivanov
Hi, I'm curious is there a way to disable JVM features from the default list. Configure mentions --with-jvm-features [1], but it doesn't allow to remove features which are enabled by default (tried to override the list, but it didn't work). Thanks! Best regards, Vladimir Iva

Re: RFR(XS): 8185567: fix hsdis cpu to architecture mapping on various Linux platforms

2017-08-03 Thread Vladimir Ivanov
Looks good! Best regards, Vladimir Ivanov On 8/1/17 5:32 AM, David Buck wrote: Hi! It was suggested that I also loop in build-dev to the review of this proposed change. Cheers, -Buck On 2017/07/31 22:06, David Buck wrote: Hi! Would you please review this small set of very simple build

Re: RFR (L) JEP 280: Indify String Concatenation (integration)

2016-01-27 Thread Vladimir Ivanov
JDK changes looks good! Best regards, Vladimir Ivanov On 1/27/16 4:55 PM, Aleksey Shipilev wrote: Hi again, This is a formal pre-integration review thread for JEP 280 ("Indify String Concatenation") integration: http://openjdk.java.net/jeps/280 The JEP is Targeted, the CCC i

Re: RFR: JDK-8141051: Build test libs -source/-target 9

2015-10-30 Thread Vladimir Ivanov
Looks good. Thanks for fixing it! Best regards, Vladimir Ivanov On 10/30/15 3:51 PM, Erik Joelsson wrote: Hello, Here is a new patch for this where I did some more cleanup. Webrev: http://cr.openjdk.java.net/~erikj/8141051/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8141051

JDK9: Build wb.jar which depends on JDK9 API

2015-10-29 Thread Vladimir Ivanov
x27;t found how to enumerate only JDK modules: Thanks! Best regards, Vladimir Ivanov [1] diff --git a/make/Main.gmk b/make/Main.gmk --- a/make/Main.gmk +++ b/make/Main.gmk @@ -452,6 +452,8 @@ test-make: clean-test-make + build-test-lib: $(JAVA_TARGETS) + build-test-hotspot-jtreg-n