On Thu, 28 Oct 2021 01:02:27 GMT, Yoshiki Sato wrote:
> Please review the integration of tzdata2021e (including tzdata2021d) to the
> JDK.
> The fix has passed all relevant JTREG regression tests and JCK tests.
>
> 8275754: (tz) Update Timezone Data to 2021d
> 8275849: Te
On Thu, 28 Oct 2021 01:02:27 GMT, Yoshiki Sato wrote:
> Please review the integration of tzdata2021e (including tzdata2021d) to the
> JDK.
> The fix has passed all relevant JTREG regression tests and JCK tests.
>
> 8275754: (tz) Update Timezone Data to 2021d
> 8275849: Te
Please review the integration of tzdata2021e (including tzdata2021d) to the JDK.
The fix has passed all relevant JTREG regression tests and JCK tests.
8275754: (tz) Update Timezone Data to 2021d
8275849: TestZoneInfo310.java fails with tzdata2021e
-
Commit messages:
- 8275754:
On Wed, 28 Oct 2020 03:26:16 GMT, Yoshiki Sato wrote:
> HTML4 is no longer supported in javadoc.
>
> doclint needs to drop HTML4 support as well.
> The changes consist of:
> * Removing -Xhtmlversion option from doclint and --doclint-format from java
; * Updating makefile not to use removed option.
> * Sorting out supported tags and attributes in HTML5 (including fix incorrect
> permission of valign in TH, TR, TD, THEAD and TBODY)
> * Fixing incorrect value checks for the id attribute.
> * Modifying test code and expected outputs to
permission of valign in TH, TR, TD, THEAD and TBODY)
> * Modifying test code and expected outputs to be checked in HTML5
Yoshiki Sato has updated the pull request incrementally with one additional
commit since the last revision:
7th: Some fixes and additional changes for 8247957
---
On Wed, 23 Dec 2020 15:53:00 GMT, Jonathan Gibbons wrote:
> \s was introduced as a valid escape character in JDK 15 as part of the
> support for Text Blocks.
> https://docs.oracle.com/javase/specs/jls/se15/html/jls-3.html#jls-EscapeSequence
>
>
On Wed, 23 Dec 2020 06:42:21 GMT, Yoshiki Sato wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line
>> 710:
>>
>>> 708:
>>> 709:
>>> 710: private boolean checkAnchor(String name) {
>>
>&
On Wed, 23 Dec 2020 05:38:36 GMT, Yoshiki Sato wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line
>> 736:
>>
>>> 734:
>>> 735: // https://html.spec.whatwg.org/#the-id-attribute
>>> 736: private static
On Wed, 23 Dec 2020 05:08:04 GMT, Jonathan Gibbons wrote:
>> Yoshiki Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 5th: 8258460: Remove --doclint-format option from javac
>
> src/jdk.javadoc/shar
On Wed, 23 Dec 2020 05:01:44 GMT, Jonathan Gibbons wrote:
>> Yoshiki Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 5th: 8258460: Remove --doclint-format option from javac
>
> src/jdk.javadoc/shar
On Wed, 23 Dec 2020 01:27:30 GMT, Jonathan Gibbons wrote:
>> Yoshiki Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 5th: 8257204 and 8256313
>> 8257204: Remove usage of -Xhtmlversion
On Wed, 23 Dec 2020 01:32:29 GMT, Jonathan Gibbons wrote:
>> Yoshiki Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 5th: 8258460: Remove --doclint-format option from javac
>
> Looks good.
>
On Thu, 17 Dec 2020 04:58:21 GMT, Jonathan Gibbons wrote:
>> Yoshiki Sato has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request co
permission of valign in TH, TR, TD, THEAD and TBODY)
> * Modifying test code and expected outputs to be checked in HTML5
Yoshiki Sato has updated the pull request incrementally with one additional
commit since the last revision:
5th: 8258460: Remove --doclint-format option from javac
---
permission of valign in TH, TR, TD, THEAD and TBODY)
> * Modifying test code and expected outputs to be checked in HTML5
Yoshiki Sato has updated the pull request incrementally with one additional
commit since the last revision:
5th: 8257204 and 8256313
8257204: Remove usage of -Xhtmlv
On Thu, 17 Dec 2020 04:48:44 GMT, Jonathan Gibbons wrote:
>> OK: valid
>> OBSOLETE: obsolete, deprecated, but still supported (valid)
>> UNSUPPORTED: ever supported but no longer supported (invalid)
>> INVALID: the rest of others (invalid)
>>
>> UNSUPPORTED can be used if we would like to
On Thu, 17 Dec 2020 04:52:48 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint.properties
>> line 36:
>>
>>> 34: dc.attr.img.border.not.number = attribute "border" for img is not a
>>> number
>>> 35: dc.attr.table.border.not.valid =
permission of valign in TH, TR, TD, THEAD and TBODY)
> * Modifying test code and expected outputs to be checked in HTML5
Yoshiki Sato has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous con
On Tue, 15 Dec 2020 09:20:44 GMT, Magnus Ihse Bursie wrote:
>> Yoshiki Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8257204 and 8256313
>> 8257204: Remove usage of -Xhtmlversion
On Fri, 11 Dec 2020 06:44:57 GMT, Yoshiki Sato wrote:
>> Please make the review non-draft as well
>
> Thanks for reviewing @jonathan-gibbons
> This request should have got changed to "non-draft".
>
> FYI. all tests in jdk-tier1 are still green with the
permission of valign in TH, TR, TD, THEAD and TBODY)
> * Modifying test code and expected outputs to be checked in HTML5
Yoshiki Sato has updated the pull request incrementally with one additional
commit since the last revision:
8257204 and 8256313
8257204: Remove usage of -Xhtmlversion opt
22 matches
Mail list logo
