Re: Need reviewer: No fastdebug builds by default

2011-02-02 Thread David Katleman (Oracle)
Looks fine Kelly. Dave Kelly O'Hair wrote: Need reviewer: No fastdebug builds by default One word change. Default builds from the root will be faster due to not building the fastdebug images. This change is in the open repository but will only impact our closed jdk builds.

Re: Need reviewer: NONFCS_BUILD_INFO to add to the non-fcs version string

2010-11-24 Thread David Katleman
Hi Kelly, Logic looks fine, just a nit Unless $(NONFCS_BUILD_INFO) really needs that leading -, I'd remove it and add a - in line 110 and 297 below. Makes it a bit more readable Dave hotspot/make/defs.make 109 else 110

<    5   6   7   8   9   10