Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Thank you, Magnus! Dmitry > On 4 Nov 2019, at 10:24, Magnus Ihse Bursie > wrote: > > > > On 2019-11-03 16:38, Dmitry Markov wrote: >> Alexey and Sergey, thank you for the approval! >> I wonder whether it is enough or I need one more “+1” from build-folk. > Y

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

The changes look good to me. >> On 01/11/2019 13:09, Dmitry Markov wrote: >>> Hi Alexey, >>> >>> I have updated the fix. Please find the new version here: >>> http://cr.openjdk.java.net/~dmarkov/8232880/webrev.03/ >>> >>> Thanks, >>&g

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

gt; > I'd recommend adding quotes around the option to look for: > 448 in the right-side pane look for "Turn off Windows key hotkeys" and double > click on it; > > Consider adding an empty line before this line > 450 Note: restart is required to make the settings

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

, i.e. no backticks. > > (For my understanding, "Turn keyboard access on or off" turns off only one > specific shortcut, i.e. Ctrl+F1?) Yes, that’s right. I have added clarification to the doc. > > > Regards, > Alexey > > On 28/10/2019 17:23, Dmit

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

an provide CTRL+F1 which is used > > > On 10/25/19 3:27 am, Dmitry Markov wrote: >> Hello, >> Could you review the fix for jdk14, please? >> bug: https://bugs.openjdk.java.net/browse/JDK-8232880 >> <https://bugs.openjdk.java.net/browse/JDK-8232880>

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Thank you for the review, Erik! I will update the fix as you suggested before push if you do not mind. Thanks, Dmitry > On 25 Oct 2019, at 14:00, Erik Joelsson wrote: > > Looks good. I would put in a "the" before "operating system". > > /Erik > >

RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Hello, Could you review the fix for jdk14, please? bug: https://bugs.openjdk.java.net/browse/JDK-8232880 webrev: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.00/ So

[7u] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

Hello, Could you review a back-port of 7129133 to JDK 7u, please? The back-port and the main fix integrated into jdk8 are slightly different. bug: http://bugs.sun.com/view_bug.do?bug_id=7129133 webrev for jdk7u: http://cr.openjdk.java.net/~dmarkov/7129133/webrev.00/ jdk8 changeset: http://hg.o