On Tue, 5 Oct 2021 07:38:28 GMT, Richard Reingruber wrote:
>> The following sentence in the JDWP Specification describing the Dispose
>> command confuses resume with suspend [1]:
>>
>> All threads suspended by the thread-level **resume** command or the
>> VM-level
>> **resume** command are
On Thu, 19 Nov 2020 00:39:52 GMT, Kim Barrett wrote:
>> Hi Coleen,
>> It looks good to me.
>> Just a couple of nits below.
>>
>> src/hotspot/share/prims/jvmtiTagMap.cpp:
>>
>> There is a double-check for _needs_cleaning, so the one at line 136 can be
>> removed:
>> 136 if (_needs_cleaning &
On Mon, 16 Nov 2020 23:30:25 GMT, Coleen Phillimore wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>> t
On Wed, 4 Nov 2020 12:21:12 GMT, Coleen Phillimore wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>> ta
On Wed, 4 Nov 2020 02:15:52 GMT, Serguei Spitsyn wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code review comments from Kim and Albert.
>
> Hi Coleen,
>
> Wow, there a
On Wed, 4 Nov 2020 00:08:10 GMT, Coleen Phillimore wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>> ta
On Tue, 3 Nov 2020 21:41:55 GMT, Coleen Phillimore wrote:
> > @coleenp - please make sure you hear from someone on the Serviceability team
> > for this PR...
>
> I've asked @sspitsyn to review this.
Yes, I'm reviewing this. Still need another pass.
-
PR: https://git.openjdk.java.n
On 5/3/19 2:00 PM, Erik Joelsson wrote:
I posted the diff for jdwp-protocol.html below too (but I forgot the
dot in the filename). That file currently does not have any copyright
visible in html, but the new footer looks the same (except for having
a different relative path in the link to co
Thank you, Erik.
Is it the same with the jdwp-protocol.html?
If so then I'm Okay with the fix.
Thanks,
Serguei
On 5/3/19 11:50 AM, Erik Joelsson wrote:
The new footer looks exactly like on the api docs today.
jvmti.html:
36481,36484c36481
<
< Copyright (c) 2002, 2018, Oracle and
+1 (if you still need it)
Thanks,
Serguei
On 9/26/18 4:41 AM, David Holmes wrote:
That all seems fine to me.
Thanks for fixing.
David
On 26/09/2018 5:48 AM, Langer, Christoph wrote:
Hi Matthias,
looks good (and trivial). Ccing serviceability-dev because of change
in libjdwp.
Best regard
10 matches
Mail list logo
