Hi Magnus,
This looks pretty good to me.
I hope, Joe gave some insight for Comparable's.
Thanks,
Serguei
On 4/16/20 05:47, Magnus Ihse Bursie wrote:
This is the final part of removing all warnings from the build of
jdk.hotspot.agent. This patch includes a number of non-trivial fixes
for the
Hi Magnus,
It looks good to me.
Thanks,
Serguei
On 4/15/20 06:00, Magnus Ihse Bursie wrote:
Here is an updated version, that avoids the SuppressWarnings for
modelToView:
http://cr.openjdk.java.net/~ihse/JDK-8242808-fix-all-SA-deprecation/webrev.02
(Only change is in SourceCodePanel.java
Hi Magnus,
This looks okay to me unless there is a better solution.
Thanks,
Serguei
On 4/14/20 04:04, Magnus Ihse Bursie wrote:
As a first step towards fixing deprecation warnings in SA, all the
references (200+) to the deprecated java.util.Observer and Observable
needs to be fixed, otherwise
Hi Erik,
Could you, please, show a simple diff for jvmti.html and jdwp-protocol.html?
Thanks,
Serguei
On 5/3/19 09:37, Erik Joelsson wrote:
The (optional) specs and man pages should have the same copyright
footer as the generated API docs. This patch adds the logic to add
such footers. It al
Igor,
It looks good.
Thank you a lot for taking care about this!
Thanks,
Serguei
On 5/23/18 12:44, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev/8199380/webrev.00/
2370 lines changed: 2370 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources AOD tes
Hi Igor,
It looks good to me.
Thanks,
Serguei
On 5/22/18 16:35, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8199383/webrev.00/index.html
308253 lines changed: 308253 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources JVMTI tests from VM
testba
Hi Leonid,
Looks good to me too.
Thanks,
Serguei
On 5/14/18 14:04, Leonid Mesnik wrote:
Misha
Thank you for review. I still need one more review from 'R'eviewer.
Leonid
On May 11, 2018, at 9:10 AM, Mikhailo Seledtsov
wrote:
Looks good to me,
Misha
On 5/8/18, 2:23 PM, Leonid Mesnik wr
Hi Igor,
It looks good.
Thanks,
Serguei
On 5/1/18 19:10, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
41276 lines changed: 41274 ins; 1 del; 1 mod;
Hi all,
could you please review the patch which open sources monitoring tests from vm
testbase?
Hi Gary,
It looks reasonable.
I'm not very familiar with the concrete SolStudio versions.
Thanks,
Serguei
On 4/4/18 11:18, Gary Adams wrote:
Getting the sources ready for the next Solaris developer studio
toolchain.
Issue: https://bugs.openjdk.java.net/browse/JDK-8199782
Webrev: http://
Chris,
This looks good to me too.
Thanks,
Serguei
On 2/23/18 00:48, Langer, Christoph wrote:
Looks good, Chris.
-Original Message-
From: build-dev [mailto:build-dev-boun...@openjdk.java.net] On Behalf Of
Chris Plummer
Sent: Freitag, 23. Februar 2018 02:04
To: build-dev@openjdk.java.
Hi Magnus,
The fix looks good to me.
Thank you for doing this cleanup.
Thanks,
Serguei
On 10/18/17 01:04, Magnus Ihse Bursie wrote:
The file jvmticmlr.h is stored twice in the repo, both in hotspot and
in java.base. They are both identical, and only the java.base version
is included in the f
On 6/1/17 18:50, Mandy Chung wrote:
On Jun 1, 2017, at 5:46 AM, Magnus Ihse Bursie
wrote:
The JNI spec will move to a new place in the "specs" directory in the docs
image, and links to it needs to be updated.
Bug: https://bugs.openjdk.java.net/browse/JDK-8180322
WebRev: http://cr.openjdk.jav
Magnus,
I've included the serviceability mailing list.
Thank you for catching these links!
But these two files are not the only fixes for this sub-task, right?
Should this webrev include your new markdown files as well?
Thanks,
Serguei
On 6/2/17 06:03, Magnus Ihse Bursie wrote:
The JDWP spec
Hi Erik
+1 to what Tim said.
Thank you a lot for fixing this issue!
Thanks,
Serguei
On 11/1/16 14:38, Tim Bell wrote:
Erik:
New webrev: http://cr.openjdk.java.net/~erikj/8063154/webrev.02/
I had not managed to revert all changes from another patch.
/Erik
On 2016-11-01 17:22, Erik Joelss
Ok.
Thanks, Staffan!
Serguei
On 8/7/15 2:27 AM, Staffan Larsen wrote:
On 7 aug 2015, at 11:24, serguei.spit...@oracle.com
<mailto:serguei.spit...@oracle.com> wrote:
Hi Staffan,
Looks good.
Thanks!
I'm re-posting the same question in this review:
Q1: Should the folder j
,
Serguei
-Dmitry
On 2015-08-07 12:24, serguei.spit...@oracle.com wrote:
Hi Staffan,
Looks good.
I'm re-posting the same question in this review:
Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be
removed?
Thanks,
Serguei
On 8/6/15 11:57 PM, Staffan Larsen
Hi Staffan,
Looks good.
I'm re-posting the same question in this review:
Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be
removed?
Thanks,
Serguei
On 8/6/15 11:57 PM, Staffan Larsen wrote:
Please review the following changes to remove the hprof JVMTI agent.
There are
Looks good.
Thanks,
Serguei
On 5/6/15 11:51 AM, Staffan Larsen wrote:
This is another library that needs to be compiled with
-DPSAPI_VERSION=1 due to the recent Windows compiler upgrade.
I have also fixed a better error message that prints the underlaying
exception if something like this hap
This looks good.
It is better with the moved comment.
Thanks,
Serguei
On 5/6/15 4:29 AM, Staffan Larsen wrote:
On 6 maj 2015, at 11:46, Magnus Ihse Bursie
wrote:
On 2015-05-06 11:39, Erik Joelsson wrote:
This one looks better. Sorry for not spotting the problem in the previous
review.
/Er
On 4/23/15 2:50 PM, Erik Joelsson wrote:
No, that file is old legacy and not used anymore. It will hopefully
soon go away.
Ok then.
Thanks, Erik!
Serguei
/Erik
On 2015-04-23 12:52, serguei.spit...@oracle.com wrote:
It looks good.
A question:
Do we want to get rid of the jhat in the
It looks good.
A question:
Do we want to get rid of the jhat in the
jdk/closed/old-build/common/Release.gmk ?
jhat.1 \
com/sun/tools/hat \
jhat$(EXE_SUFFIX)
Thanks,
Serguei
On 4/23/15 5:06 AM, Staffan Larsen wrote:
Please review this change to remove the jhat
Dan,
The fix looks good.
Nice cleanup from workarounds: Good Thing (TM)! :)
Thanks,
Serguei
On 11/10/14 4:00 PM, Daniel D. Daugherty wrote:
Greetings,
I have a Solaris Full Debug Symbols (FDS) fix ready for review.
Yes, it is a small fix, but it is in Makefiles so feel free to
run screaming f
The fix looks good.
The Copyright comment of the WindowsVirtualMachine.c**can be updated
with 2013.
Thanks,
Serguei
On 8/16/13 9:51 AM, Staffan Larsen wrote:
This failure happens when compiling with the VS 2012 compiler. The attach code
relies on the order of two methods in the compiled bina
Dan,
It is nice fix and simplified many places.
Just one minor comment:
make/bsd/makefiles/dtrace.make
41 #LIBJVM_DB = libjvm_db.dylib
42 LIBJVM_DB = libjvm_db.dylib
45 #LIBJVM_DTRACE = libjvm_dtrace.dylib
46 LIBJVM_DTRACE = libjvm_dtrace.dylib
The lines #41 and #45 can be removed
I do not see any issues with that webrev.
Looks good.
Thanks,
Serguei
On 5/23/12 12:59 PM, Daniel D. Daugherty wrote:
Greetings,
This is a hotspot code review request for the second of a pair of
Full Debug Symbols gobjcopy work arounds on Solaris. The first
hotspot FDS gobjcopy work around was
Dan,
I've reviewed the fixes as did not notice any problems.
Looks good.
Thanks,
Serguei
On 5/23/12 12:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
corrupts
Looks good.
Thanks,
Serguei
On 4/12/12 2:03 PM, Daniel D. Daugherty wrote:
The wonderful T&L nightly testing caught an error in my changes
that were reviewed on this thread. On Linux and Solaris, I installed
the .debuginfo files for programs in $JAVA_HOME/bin. I made a
mistake in the way I inte
On 2012-04-11 01:17, Daniel D. Daugherty wrote:
Thanks Serguei!
Dan
On 4/10/12 2:51 PM, serguei.spit...@oracle.com wrote:
Dan,
It is good.
Thanks,
Serguei
On 4/9/12 1:51 PM, Daniel D. Daugherty wrote:
Greetings,
Coming soon to a JDK repo near you! Full Debug Symbols!
OK, to just a subs
Dan,
It is good.
Thanks,
Serguei
On 4/9/12 1:51 PM, Daniel D. Daugherty wrote:
Greetings,
Coming soon to a JDK repo near you! Full Debug Symbols!
OK, to just a subset of libraries and programs... on Linux and Solaris...
If you're a Windows fan, the JDK repo has had Full Debug Symbols support
Dan,
I've reviewed all 3 webrevs.
They look fine.
Thanks,
Serguei
On 3/30/12 10:32 AM, Daniel D. Daugherty wrote:
Greetings,
In my recent Full Debug Symbols changes, I added the new
ENABLE_FULL_DEBUG_SYMBOLS build flag. I originally implemented
this flag to disable debug info for all build
Ok, thanks!
Thumb up.
Thanks,
Serguei
On 3/17/12 6:29 PM, Daniel D. Daugherty wrote:
Thanks for the review. Replies embedded below...
Dan,
I've reviewed this:
http://cr.openjdk.java.net/~dcubed/fds_revamp/7102323-webrev/1-hotspot-full/
Wow, you fixed two existing bugs in the make file:
Dan,
I've reviewed this:
http://cr.openjdk.java.net/~dcubed/fds_revamp/7102323-webrev/1-hotspot-full/
Wow, you fixed two existing bugs in the make file:
*make/solaris/makefiles/dtrace.make
*
-[ -f $(XLIBJVM_DB_G_DEBUGINFO) ] || { ln -s $(LIBJVM_DB_DEBUGINFO)
$(XLIBJVM_DB_G_DEB
32 matches
Mail list logo
