RE: [11] RFR for JDK-8202544: Hide unused exports in libzip

2018-05-11 Thread Langer, Christoph
Magnus Ihse Bursie > > Subject: Re: [11] RFR for JDK-8202544: Hide unused exports in libzip > > Hi Christoph, > > Thank you for your review. > > I was checking the changeset before pushing and noticed I had forgotten > to remove JNIEXPORT modifier from ZIP_GetEntry

Re: [11] RFR for JDK-8202544: Hide unused exports in libzip

2018-05-11 Thread Alexey Ivanov
se). Best regards Christoph -Original Message- From: build-dev [mailto:build-dev-boun...@openjdk.java.net] On Behalf Of Alexey Ivanov Sent: Mittwoch, 9. Mai 2018 16:35 To: core-libs ; hotspot-dev Cc: build-dev Subject: Re: [11] RFR for JDK-8202544: Hide unused exports in libzip Any

RE: [11] RFR for JDK-8202544: Hide unused exports in libzip

2018-05-10 Thread Langer, Christoph
core-libs ; hotspot-dev d...@openjdk.java.net> > Cc: build-dev > Subject: Re: [11] RFR for JDK-8202544: Hide unused exports in libzip > > Any volunteers from core-libs and/or hotspot? > > Thank you, > Alexey > > On 02/05/2018 13:02, Magnus Ihse Bursie wrote: >

Re: [11] RFR for JDK-8202544: Hide unused exports in libzip

2018-05-09 Thread Alexey Ivanov
Any volunteers from core-libs and/or hotspot? Thank you, Alexey On 02/05/2018 13:02, Magnus Ihse Bursie wrote: Looks good to me, FWIW. /Magnus 2 maj 2018 kl. 13:52 skrev Alexey Ivanov : Hi, Could you please review the following fix for jdk11? bug: https://bugs.openjdk.java.net/browse/JDK-

Re: [11] RFR for JDK-8202544: Hide unused exports in libzip

2018-05-02 Thread Magnus Ihse Bursie
Looks good to me, FWIW. /Magnus > 2 maj 2018 kl. 13:52 skrev Alexey Ivanov : > > Hi, > > Could you please review the following fix for jdk11? > > bug: https://bugs.openjdk.java.net/browse/JDK-8202544 > webrev: http://cr.openjdk.java.net/~aivanov/8202544/jdk11/webrev.0/ > > The following expo

[11] RFR for JDK-8202544: Hide unused exports in libzip

2018-05-02 Thread Alexey Ivanov
Hi, Could you please review the following fix for jdk11? bug: https://bugs.openjdk.java.net/browse/JDK-8202544 webrev: http://cr.openjdk.java.net/~aivanov/8202544/jdk11/webrev.0/ The following exported functions in libzip are not used: ZIP_GetEntry, ZIP_FreeEntry, ZIP_Lock, ZIP_Unlock, ZIP_Read