Re: [11] Review Request: 8200198 javah man pages were not removed by JDK-8191054

2018-03-26 Thread Erik Joelsson
Looks good to me. I doubt these will ever get regenerated from the same sources again. /Erik On 2018-03-26 00:45, Alan Bateman wrote: On 26/03/2018 00:44, Sergey Bylokhov wrote: On 24/03/2018 00:32, Alan Bateman wrote: This looks okay. Are we sure we've got everything now? (as this will b

Re: [11] Review Request: 8200198 javah man pages were not removed by JDK-8191054

2018-03-26 Thread Alan Bateman
On 26/03/2018 00:44, Sergey Bylokhov wrote: On 24/03/2018 00:32, Alan Bateman wrote: This looks okay. Are we sure we've got everything now? (as this will be the fourth change to remove pieces of javah). Fix updated, there were some links to javah from other man pages: http://cr.openjdk.java.

Re: [11] Review Request: 8200198 javah man pages were not removed by JDK-8191054

2018-03-25 Thread Sergey Bylokhov
On 24/03/2018 00:32, Alan Bateman wrote: This looks okay. Are we sure we've got everything now? (as this will be the fourth change to remove pieces of javah). Fix updated, there were some links to javah from other man pages: http://cr.openjdk.java.net/~serb/8200198/webrev.01 Also it looks like

Re: [11] Review Request: 8200198 javah man pages were not removed by JDK-8191054

2018-03-24 Thread Alan Bateman
On 24/03/2018 06:03, Sergey Bylokhov wrote: Hello. Please review fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8200198 Webrev can be found at: http://cr.openjdk.java.net/~serb/8200198/webrev.00 This looks okay. Are we sure we've got everything now? (as this will be the fourth

[11] Review Request: 8200198 javah man pages were not removed by JDK-8191054

2018-03-23 Thread Sergey Bylokhov
Hello. Please review fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8200198 Webrev can be found at: http://cr.openjdk.java.net/~serb/8200198/webrev.00 The man pages related to javah tool were removed from the ws in the same way as it was done for policytool and for tools related t