Re: [12] RFR(XS) 8208463: jdk.internal.vm.compiler's module-info.java.extra contains duplicated provides of the same service interface

2018-08-13 Thread Vladimir Kozlov
Thank you, Mandy Vladimir On 8/13/18 8:00 PM, mandy chung wrote: Hi Vladimir, This looks good.  I verified with my patch that enforces non-duplicate provides check and it builds successfully.  Thanks for fixing it. thanks Mandy On 8/13/18 5:06 PM, Vladimir Kozlov wrote: https://bugs.openjdk

Re: [12] RFR(XS) 8208463: jdk.internal.vm.compiler's module-info.java.extra contains duplicated provides of the same service interface

2018-08-13 Thread mandy chung
Hi Vladimir, This looks good. I verified with my patch that enforces non-duplicate provides check and it builds successfully. Thanks for fixing it. thanks Mandy On 8/13/18 5:06 PM, Vladimir Kozlov wrote: https://bugs.openjdk.java.net/browse/JDK-8208463 Before we did not care how module-info

[12] RFR(XS) 8208463: jdk.internal.vm.compiler's module-info.java.extra contains duplicated provides of the same service interface

2018-08-13 Thread Vladimir Kozlov
https://bugs.openjdk.java.net/browse/JDK-8208463 Before we did not care how module-info.java.extra is generated. The code in Gensrc-jdk.internal.vm.compiler.gmk make file simple ordered 'providers' files (which are packages names) by name and then use their contents to generate 'provides' inst