Re: [12] RFR for JDK-8215123: Crash in runtime image built with jlink --compress=2

2018-12-10 Thread Alan Bateman
On 10/12/2018 13:01, Magnus Ihse Bursie wrote: Hi Alexey, On 2018-12-10 13:32, Alexey Ivanov wrote: Hi, Could you please review the following fix for jdk12? bug: https://bugs.openjdk.java.net/browse/JDK-8215123 webrev: http://cr.openjdk.java.net/~aivanov/8215123/webrev.00/ The fix looks g

Re: [12] RFR for JDK-8215123: Crash in runtime image built with jlink --compress=2

2018-12-10 Thread Magnus Ihse Bursie
Hi Alexey, On 2018-12-10 13:32, Alexey Ivanov wrote: Hi, Could you please review the following fix for jdk12? bug: https://bugs.openjdk.java.net/browse/JDK-8215123 webrev: http://cr.openjdk.java.net/~aivanov/8215123/webrev.00/ The fix looks good to me. /Magnus The problem is that calling

[12] RFR for JDK-8215123: Crash in runtime image built with jlink --compress=2

2018-12-10 Thread Alexey Ivanov
Hi, Could you please review the following fix for jdk12? bug: https://bugs.openjdk.java.net/browse/JDK-8215123 webrev: http://cr.openjdk.java.net/~aivanov/8215123/webrev.00/ The problem is that calling convention was changed on ZIP_InflateFully function in zip.dll. Yet it hasn't been updated