http://cr.openjdk.java.net/~vlivanov/8217404/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8217404
--with-jvm-features doesn't work properly when multiple features are
explicitly disabled:
$ bash configure --with-jvm-features="-aot -jvmci -graal"
...
checking if jvmci module jdk.internal
I usually used --with-jvm-features=-aot,-jvmci,-graal
Did not work in this case too?
Anyway your fix is good.
Thanks,
Vladimir
On 1/18/19 3:33 PM, Vladimir Ivanov wrote:
http://cr.openjdk.java.net/~vlivanov/8217404/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8217404
--with-jvm-featur
Hi Vladimir,
overall your fix looks reasonable, but w/ it we can get unintentionally
disabled features (b/c grep doesn't do full word match). although this problem
wasn't really introduced by your fix, I think it's be better to fix it as a
part of your patch. I see two possible solutions:
- a
Thanks, Vladimir.
I usually used --with-jvm-features=-aot,-jvmci,-graal
Did not work in this case too?
I didn't know it supports comma-separated list, but it doesn't work as
well:
$ bash configure --with-jvm-features="-aot,-jvmci,-graal"
checking if jvmci module jdk.internal.vm.ci should
Thanks, Igor.
overall your fix looks reasonable, but w/ it we can get unintentionally
disabled features (b/c grep doesn't do full word match). although this problem
wasn't really introduced by your fix, I think it's be better to fix it as a
part of your patch. I see two possible solutions:
Updated webrev:
http://cr.openjdk.java.net/~vlivanov/8217404/webrev.01
Verified that it works as expected on Linux, Windows, MacOS, and Solaris.
Best regards,
Vladimir Ivanov
On 18/01/2019 16:39, Vladimir Ivanov wrote:
Thanks, Igor.
overall your fix looks reasonable, but w/ it we can get
u
Still looks good to me.
— Igor
> On Jan 18, 2019, at 5:26 PM, Vladimir Ivanov
> wrote:
>
> Updated webrev:
> http://cr.openjdk.java.net/~vlivanov/8217404/webrev.01
>
> Verified that it works as expected on Linux, Windows, MacOS, and Solaris.
>
> Best regards,
> Vladimir Ivanov
>
>> On 18/
+1
Thanks
Vladimir
> On Jan 18, 2019, at 5:29 PM, Igor Ignatev wrote:
>
> Still looks good to me.
>
> — Igor
>
>> On Jan 18, 2019, at 5:26 PM, Vladimir Ivanov
>> wrote:
>>
>> Updated webrev:
>> http://cr.openjdk.java.net/~vlivanov/8217404/webrev.01
>>
>> Verified that it works as expec
> On Jan 18, 2019, at 7:31 PM, Vladimir Ivanov
> wrote:
>
> Thanks, Vladimir.
>
>> I usually used --with-jvm-features=-aot,-jvmci,-graal
>> Did not work in this case too?
>
> I didn't know it supports comma-separated list, but it doesn't work as well:
>
> $ bash configure --with-jvm-features=
On 2019-01-20 09:45, Kim Barrett wrote:
On Jan 18, 2019, at 7:31 PM, Vladimir Ivanov
wrote:
Thanks, Vladimir.
I usually used --with-jvm-features=-aot,-jvmci,-graal
Did not work in this case too?
I didn't know it supports comma-separated list, but it doesn't work as well:
$ bash configure -
On 2019-01-19 01:39, Vladimir Ivanov wrote:
Thanks, Igor.
overall your fix looks reasonable, but w/ it we can get
unintentionally disabled features (b/c grep doesn't do full word
match). although this problem wasn't really introduced by your fix, I
think it's be better to fix it as a part of
Vladimir, if you're okay with it I'd like to propose this as a patch to
the problem instead:
http://cr.openjdk.java.net/~ihse/JDK-8217404-fix-multiple-disabled-jvm-features/webrev.01
Looks good! I verified that it fixes the bug.
Best regards,
Vladimir Ivanov
On Jan 18, 2019, at 3:33 PM, V
> On Jan 21, 2019, at 5:06 AM, Magnus Ihse Bursie
> wrote:
> Vladimir, if you're okay with it I'd like to propose this as a patch to the
> problem instead:
>
> http://cr.openjdk.java.net/~ihse/JDK-8217404-fix-multiple-disabled-jvm-features/webrev.01
Looks good!
13 matches
Mail list logo