[13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8217404/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8217404 --with-jvm-features doesn't work properly when multiple features are explicitly disabled: $ bash configure --with-jvm-features="-aot -jvmci -graal" ... checking if jvmci module jdk.internal

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Vladimir Kozlov
I usually used --with-jvm-features=-aot,-jvmci,-graal Did not work in this case too? Anyway your fix is good. Thanks, Vladimir On 1/18/19 3:33 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8217404/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8217404 --with-jvm-featur

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Igor Ignatyev
Hi Vladimir, overall your fix looks reasonable, but w/ it we can get unintentionally disabled features (b/c grep doesn't do full word match). although this problem wasn't really introduced by your fix, I think it's be better to fix it as a part of your patch. I see two possible solutions: - a

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Vladimir Ivanov
Thanks, Vladimir. I usually used --with-jvm-features=-aot,-jvmci,-graal Did not work in this case too? I didn't know it supports comma-separated list, but it doesn't work as well: $ bash configure --with-jvm-features="-aot,-jvmci,-graal" checking if jvmci module jdk.internal.vm.ci should

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Vladimir Ivanov
Thanks, Igor. overall your fix looks reasonable, but w/ it we can get unintentionally disabled features (b/c grep doesn't do full word match). although this problem wasn't really introduced by your fix, I think it's be better to fix it as a part of your patch. I see two possible solutions:

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Vladimir Ivanov
Updated webrev: http://cr.openjdk.java.net/~vlivanov/8217404/webrev.01 Verified that it works as expected on Linux, Windows, MacOS, and Solaris. Best regards, Vladimir Ivanov On 18/01/2019 16:39, Vladimir Ivanov wrote: Thanks, Igor. overall your fix looks reasonable, but w/ it we can get u

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Igor Ignatev
Still looks good to me. — Igor > On Jan 18, 2019, at 5:26 PM, Vladimir Ivanov > wrote: > > Updated webrev: > http://cr.openjdk.java.net/~vlivanov/8217404/webrev.01 > > Verified that it works as expected on Linux, Windows, MacOS, and Solaris. > > Best regards, > Vladimir Ivanov > >> On 18/

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-18 Thread Vladimir Kozlov
+1 Thanks Vladimir > On Jan 18, 2019, at 5:29 PM, Igor Ignatev wrote: > > Still looks good to me. > > — Igor > >> On Jan 18, 2019, at 5:26 PM, Vladimir Ivanov >> wrote: >> >> Updated webrev: >> http://cr.openjdk.java.net/~vlivanov/8217404/webrev.01 >> >> Verified that it works as expec

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-20 Thread Kim Barrett
> On Jan 18, 2019, at 7:31 PM, Vladimir Ivanov > wrote: > > Thanks, Vladimir. > >> I usually used --with-jvm-features=-aot,-jvmci,-graal >> Did not work in this case too? > > I didn't know it supports comma-separated list, but it doesn't work as well: > > $ bash configure --with-jvm-features=

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-21 Thread Magnus Ihse Bursie
On 2019-01-20 09:45, Kim Barrett wrote: On Jan 18, 2019, at 7:31 PM, Vladimir Ivanov wrote: Thanks, Vladimir. I usually used --with-jvm-features=-aot,-jvmci,-graal Did not work in this case too? I didn't know it supports comma-separated list, but it doesn't work as well: $ bash configure -

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-21 Thread Magnus Ihse Bursie
On 2019-01-19 01:39, Vladimir Ivanov wrote: Thanks, Igor. overall your fix looks reasonable, but w/ it we can get unintentionally disabled features (b/c grep doesn't do full word match). although this problem wasn't really introduced by your fix, I think it's be better to fix it as a part of

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-21 Thread Vladimir Ivanov
Vladimir, if you're okay with it I'd like to propose this as a patch to the problem instead: http://cr.openjdk.java.net/~ihse/JDK-8217404-fix-multiple-disabled-jvm-features/webrev.01 Looks good! I verified that it fixes the bug. Best regards, Vladimir Ivanov On Jan 18, 2019, at 3:33 PM, V

Re: [13] RFR (S): 8217404: --with-jvm-features doesn't work when multiple features are explicitly disabled

2019-01-21 Thread Kim Barrett
> On Jan 21, 2019, at 5:06 AM, Magnus Ihse Bursie > wrote: > Vladimir, if you're okay with it I'd like to propose this as a patch to the > problem instead: > > http://cr.openjdk.java.net/~ihse/JDK-8217404-fix-multiple-disabled-jvm-features/webrev.01 Looks good!