Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Tim Bell
On 10/29/12 12:06, Anthony Petrov wrote: That's correct. Currently we don't have any plans to change compilers for JDK 8. It will be discussed with the release team when need arises. OK, thanks. Sorry if I sounded a bit fussy, but I want to avoid last minute surprises if we can, and it is bet

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Anthony Petrov
Tim, Kelly: thanks for your review. I'll push the fix via the awt forest tomorrow. On 10/29/2012 8:29 PM, Tim Bell wrote: We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in order to set up the build environment, so I think the propos

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Kelly O'Hair
On Oct 29, 2012, at 12:06 PM, Anthony Petrov wrote: > Tim, Kelly: thanks for your review. I'll push the fix via the awt forest > tomorrow. Great. Thanks for making the change. -kto > > On 10/29/2012 8:29 PM, Tim Bell wrote: >>> We're not yet switching JDK builds to VS2012. However, the vsvar

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Tim Bell
Anthony: Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ These changes look fine. We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in o

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Kelly O'Hair
Looks good to me. -kto On Oct 29, 2012, at 8:37 AM, Anthony Petrov wrote: > Hello, > > Please review a fix for > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: > > http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ > > We're not yet switching JDK builds to VS2012. Howeve

[8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Anthony Petrov
Hello, Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in order to set up the build env