Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Hi, It looks good to me. Thanks, -- Yuka (12/08/21 2:14), Naoto Sato wrote: I have updated the changeset by removing the copyright headers from all of the CLDR files, and added a LICENSE file at the top of CLDR source directory (src/share/classes/sun/util/cldr/resources/21_0_1). No other cha

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Looks good to me. I'm ok with this. /Erik On 2012-08-20 19:14, Naoto Sato wrote: I have updated the changeset by removing the copyright headers from all of the CLDR files, and added a LICENSE file at the top of CLDR source directory (src/share/classes/sun/util/cldr/resources/21_0_1). No other

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

I have updated the changeset by removing the copyright headers from all of the CLDR files, and added a LICENSE file at the top of CLDR source directory (src/share/classes/sun/util/cldr/resources/21_0_1). No other changes have been made this time. http://cr.openjdk.java.net/~naoto/6336885/webre

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Thanks, Erik! I incorporated your build-infra changes into the main changeset, and created a new combined webrev as follows: http://cr.openjdk.java.net/~naoto/6336885/webrev.02/ Naoto On 8/13/12 11:40 PM, Erik Joelsson wrote: I finished making the changes yesterday, but didn't manage to get

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Hi David, We are planning to push the changes through T/L repos. Although I think it's unlikely that our changes and JSR 292 ones would interfere, it would be good to push them in a later promotion build. I will shoot for the next one after the "flag day." Naoto On 8/13/12 11:57 PM, David H

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

- Original Message - > Hello, > > Please review the JDK8 changes for JEP 127: Improve Locale Data > Packaging and Adopt Unicode CLDR Data > (http://openjdk.java.net/jeps/127). The webrev is located at: > > http://cr.openjdk.java.net/~naoto/6336885/webrev.00/ > > The main bug id for this

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

On 2012-08-14 09:24, Erik Joelsson wrote: And I'm done. http://cr.openjdk.java.net/~erikj/6336885/webrev.build-infra.00/ This is a patch on top of your latest webrev that I have verified to produce the same result on linux.

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

And I'm done. http://cr.openjdk.java.net/~erikj/6336885/webrev.build-infra.00/ This is a patch on top of your latest webrev that I have verified to produce the same result on linux. This part will need some more eyes from b

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Ni Naoto, Where will this be pushed to initially? It is a big set of changes, albeit localized (no pun intended :) ), so it would be good to see this get some bake time before propagating up. Further we're just about to have a "flag day" between hotspot and JDK due to JSR292 changes, so it wo

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

I finished making the changes yesterday, but didn't manage to get the patch completed before I had to run. (webrev and mercurial wouldn't cooperate). I will get it done asap today. /Erik On 2012-08-13 23:43, Naoto Sato wrote: Since I haven't heard any more comments from Erik/Kelly, I would lik

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Since I haven't heard any more comments from Erik/Kelly, I would like to push the changeset without the new build infra patch. Erik/Kelly, can you please give us an official "GO" in terms of the build related changes? Aside from build changes, I have updated the changeset based on an internal

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

On 8/7/12 2:57 AM, Erik Joelsson wrote: See inline On 2012-07-13 22:20, Kelly O'Hair wrote: Something seems strange here: http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html It's like someone was avoiding overall quotes, but using them to add spaces someh

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

See inline On 2012-07-13 22:20, Kelly O'Hair wrote: Something seems strange here: http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html It's like someone was avoiding overall quotes, but using them to add spaces somehow... I sure would like to get rid o

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Hi Kelly, The shell script in question is pretty likely to be removed, or at least rewritten when we make modifications for Jigsaw packaging of the locale data. Right now the script creates the pre-baked locale list based on the existing resource bundle source files in the repository, but that

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Something seems strange here: http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html It's like someone was avoiding overall quotes, but using them to add spaces somehow... I sure would like to get rid of this shell logic, seems like there are lots repeated

[8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Hello, Please review the JDK8 changes for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data (http://openjdk.java.net/jeps/127). The webrev is located at: http://cr.openjdk.java.net/~naoto/6336885/webrev.00/ The main bug id for this enhancement is: 6336885: RFE: Locale Data