Re: [9] RFR: JDK-8074826,,Resolve disabled warnings for liblcms

2016-04-01 Thread Phil Race
Sorry, no we don't want this patch. We are not fixing warnings in upstream libraries. -phil. On 04/01/2016 03:57 AM, prasanta sadhukhan wrote: Hi All, Please review a fix to remove the disabled warnings from lcms library Bug: https://bugs.openjdk.java.net/browse/JDK-8074826 webrev: http://cr.o

Re: [9] RFR: JDK-8074826,,Resolve disabled warnings for liblcms

2016-04-01 Thread Erik Joelsson
Thanks for fixing this! The build change looks fine. Someone else should look at the code changes. /Erik On 2016-04-01 12:57, prasanta sadhukhan wrote: Hi All, Please review a fix to remove the disabled warnings from lcms library Bug: https://bugs.openjdk.java.net/browse/JDK-8074826 webrev: h

[9] RFR: JDK-8074826,,Resolve disabled warnings for liblcms

2016-04-01 Thread prasanta sadhukhan
Hi All, Please review a fix to remove the disabled warnings from lcms library Bug: https://bugs.openjdk.java.net/browse/JDK-8074826 webrev: http://cr.openjdk.java.net/~psadhukhan/8074826/webrev.00/ One issue was snprintf/sprintf was using arguments it8 ->DoubleFormatter instead of string forma