Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread John Paul Adrian Glaubitz
On 09/27/2017 09:57 PM, John Paul Adrian Glaubitz wrote:> On 09/27/2017 08:51 PM, Kim Barrett wrote: Looks good. Please update the copyright in oopMap.cpp. Done [1]. Just a second, please. I just ran into build errors. Please don't merge as is. Adrian -- .''`. John Paul Adrian Glaubitz

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread John Paul Adrian Glaubitz
Hi Kim! On 09/27/2017 08:51 PM, Kim Barrett wrote: Looks good. Please update the copyright in oopMap.cpp. Done [1]. Adrian [1] http://cr.openjdk.java.net/~glaubitz/8186578/webrev.03/ -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Univers

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread Magnus Ihse Bursie
Build change looks good. /Magnus On 2017-09-27 18:40, John Paul Adrian Glaubitz wrote: Hello! Zero currently fails to build on linux-sparc since there are two instances where SPARC-specific defines conflict with the Zero code. One instance is src/hotspot/share/compiler/oopMap.cpp where a he

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread Kim Barrett
> On Sep 27, 2017, at 12:40 PM, John Paul Adrian Glaubitz > wrote: > > Hello! > > Zero currently fails to build on linux-sparc since there are two instances > where > SPARC-specific defines conflict with the Zero code. > > […] > The webrev to fix the Zero build on SPARC includes both changes

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread Andrew Haley
On 27/09/17 17:47, John Paul Adrian Glaubitz wrote: > On 09/27/2017 06:46 PM, Andrew Haley wrote: >> On 27/09/17 17:40, John Paul Adrian Glaubitz wrote: >>> The webrev to fix the Zero build on SPARC includes both changes and can be >>> found >>> in [1]. >> >> That looks right, but I think the rele

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread John Paul Adrian Glaubitz
On 09/27/2017 06:46 PM, Andrew Haley wrote: On 27/09/17 17:40, John Paul Adrian Glaubitz wrote: The webrev to fix the Zero build on SPARC includes both changes and can be found in [1]. That looks right, but I think the release JDK 9 is done. We'll have to stage the fix for the JDK 9 updates p

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread Andrew Haley
On 27/09/17 17:40, John Paul Adrian Glaubitz wrote: > The webrev to fix the Zero build on SPARC includes both changes and can be > found > in [1]. That looks right, but I think the release JDK 9 is done. We'll have to stage the fix for the JDK 9 updates project. -- Andrew Haley Java Platform L

[RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread John Paul Adrian Glaubitz
Hello! Zero currently fails to build on linux-sparc since there are two instances where SPARC-specific defines conflict with the Zero code. One instance is src/hotspot/share/compiler/oopMap.cpp where a header is uncondtionally included for SPARC which is not available for Zero. It turns out tha