Re: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-29 Thread Andrew John Hughes
.net' > d...@openjdk.java.net>; build-dev@openjdk.java.net >> Subject: Re: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, >> BUNDLE_VENDOR, VENDOR, but no configure flag >> >> >> >> On 28/03/2019 09:30, Langer, Christoph wrote: >>> Hi, >>>

RE: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-29 Thread Langer, Christoph
RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, > BUNDLE_VENDOR, VENDOR, but no configure flag > > > > On 28/03/2019 09:30, Langer, Christoph wrote: > > Hi, > > > >>> Revised HotSpot webrev: > >>> > >>> https://cr.openjdk.java.net/~andrew/op

Re: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-28 Thread Andrew John Hughes
On 28/03/2019 09:30, Langer, Christoph wrote: > Hi, > >>> Revised HotSpot webrev: >>> >>> https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot.02 >> >> +++ new/src/share/vm/runtime/vm_version.cpp 2019-03-28 >> 03:52:51.384737947 + >> @@ -140,7 +140,7 @@ >> >> const char* Abstract_

Re: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-28 Thread Andrew John Hughes
On 28/03/2019 08:51, Severin Gehwolf wrote: > On Thu, 2019-03-28 at 03:56 +, Andrew John Hughes wrote: >> On 26/03/2019 21:57, Langer, Christoph wrote: >>> Hi Andrew, >>> >>> thanks for doing this backport. I agree, Severin's finding needs to be >>> added to hotspot's Unix/Posix vm.make fil

RE: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-28 Thread Langer, Christoph
Hi, > > Revised HotSpot webrev: > > > > https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot.02 > > +++ new/src/share/vm/runtime/vm_version.cpp 2019-03-28 > 03:52:51.384737947 + > @@ -140,7 +140,7 @@ > > const char* Abstract_VM_Version::vm_vendor() { > #ifdef VENDOR > - return X

Re: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-28 Thread Severin Gehwolf
On Thu, 2019-03-28 at 03:56 +, Andrew John Hughes wrote: > On 26/03/2019 21:57, Langer, Christoph wrote: > > Hi Andrew, > > > > thanks for doing this backport. I agree, Severin's finding needs to be > > added to hotspot's Unix/Posix vm.make files. > > Yes, it was missed because it's already

Re: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-27 Thread Andrew John Hughes
On 26/03/2019 21:57, Langer, Christoph wrote: > Hi Andrew, > > thanks for doing this backport. I agree, Severin's finding needs to be added > to hotspot's Unix/Posix vm.make files. Yes, it was missed because it's already there prior to this patch in the 9 and up HotSpot build which is quite diff

RE: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-26 Thread Langer, Christoph
u- > d...@openjdk.java.net' ; build- > d...@openjdk.java.net > Subject: Re: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, > BUNDLE_VENDOR, VENDOR, but no configure flag > > Hi Andrew, > > On Tue, 2019-03-26 at 01:59 +, Andrew John Hughes wrote: > > Bug

Re: [RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-26 Thread Severin Gehwolf
Hi Andrew, On Tue, 2019-03-26 at 01:59 +, Andrew John Hughes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8189761 > Webrev(s): > https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot/ 105 CXXFLAGS/vm_version.o += ${JRE_VERSION} 106 CXXFLAGS/arguments.o += ${VERSION_CFLAGS}

[RFR] [8u] 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2019-03-25 Thread Andrew John Hughes
Bug: https://bugs.openjdk.java.net/browse/JDK-8189761 Webrev(s): https://cr.openjdk.java.net/~andrew/openjdk8/8189761/hotspot/ https://cr.openjdk.java.net/~andrew/openjdk8/8189761/jdk/ https://cr.openjdk.java.net/~andrew/openjdk8/8189761/root/ This backport is largely clean, bar fuzzing, for the J