Thank you, Okutsu-san. It looks good to me now.
Naoto
On 12/7/12 8:05 AM, Masayoshi Okutsu wrote:
Thank you for your review comments.
On 12/7/2012 5:49 AM, Naoto Sato wrote:
Here are my comments:
- Bundle.java
Line 277,297: Do we need two separate iteration loops here? Two
iteration loops l
Thank you for your review. I thought so too, but I followed the rule for
make/* changes.
Masayoshi
On 12/6/2012 8:36 PM, Erik Joelsson wrote:
(resending to all recepients)
I don't see any changes to the build except for java classes in the
cldrconverter build tool. This shouldn't affect the
Thank you for your review comments.
On 12/7/2012 5:49 AM, Naoto Sato wrote:
Here are my comments:
- Bundle.java
Line 277,297: Do we need two separate iteration loops here? Two
iteration loops look like the same.
These loops need to be separated to make inheritance work correctly.
Line 303
Here are my comments:
- Bundle.java
Line 277,297: Do we need two separate iteration loops here? Two
iteration loops look like the same.
Line 303: typo "paris"
Line 606: typo "Someting"
Line 728: Could use foreach here.
- CLDRConverter.java
Line 388: The FormatData bundle is now "OPEN", wh
(resending to all recepients)
I don't see any changes to the build except for java classes in the
cldrconverter build tool. This shouldn't affect the new build, so it's
ok with the build group.
/Erik
On 2012-12-06 06:06, Masayoshi Okutsu wrote:
Resending in order to include build-dev@openjdk
I don't see any changes to the build except for java classes in the
cldrconverter build tool. This shouldn't affect the new build, so it's
ok with the build group.
/Erik
On 2012-12-06 06:06, Masayoshi Okutsu wrote:
Resending in order to include build-dev@openjdk.java.net and
build-in...@openj
Resending in order to include build-dev@openjdk.java.net and
build-in...@openjdk.dev.java.net.
Hi,
This is a review request for two RFEs.
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000983
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003267
http://cr.openjdk.java.net/~okutsu/8/
