* Andrew Hughes [2014-05-22 16:10]:
> - Original Message -
> > On 2014-05-22 02:49, Omair Majid wrote:
> > > Would you mind if I did this as a separate patch? I will need to fix
> > > other libraries too (libzip, and libgif).
> > >
>
> Ok, I thought the other ones were already in this for
I think that it would be useful to have a bug id prior to sending a
review request, so that a review thread for the bug can be easily found
in the mailing archive. In the future, please do file a bug first and
put its id in the subject line of your review requests.
--
best regards,
Anthony
On
* Phil Race [2014-05-22 16:02]:
> BTW .. I just realised I haven't seen a bug ID in this thread.
> Does one already exist ?
No. I was going to create one before I push.
Thanks,
Omair
--
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
- Original Message -
>
> On 2014-05-22 02:49, Omair Majid wrote:
> > * Andrew Hughes [2014-05-21 20:23]:
> >> - Original Message -
> >>> * Andrew Hughes [2014-05-21 12:22]:
> I'm not keen on the hardcoding of '-ljpeg'
>
> + LIBJPEG_LIBS := -ljpeg
> >>> There's n
BTW .. I just realised I haven't seen a bug ID in this thread.
Does one already exist ?
-phil.
On 5/21/14 5:49 PM, Omair Majid wrote:
* Andrew Hughes [2014-05-21 20:23]:
- Original Message -
* Andrew Hughes [2014-05-21 12:22]:
I'm not keen on the hardcoding of '-ljpeg'
+ LIBJPEG_
On 2014-05-22 02:49, Omair Majid wrote:
* Andrew Hughes [2014-05-21 20:23]:
- Original Message -
* Andrew Hughes [2014-05-21 12:22]:
I'm not keen on the hardcoding of '-ljpeg'
+ LIBJPEG_LIBS := -ljpeg
There's no pkg-config files for it. Any suggestions on how to get
something gen
* Andrew Hughes [2014-05-21 20:23]:
> - Original Message -
> > * Andrew Hughes [2014-05-21 12:22]:
> > > I'm not keen on the hardcoding of '-ljpeg'
> > >
> > > + LIBJPEG_LIBS := -ljpeg
> >
> > There's no pkg-config files for it. Any suggestions on how to get
> > something generic?
> >
- Original Message -
> * Andrew Hughes [2014-05-21 12:22]:
> > I'm not keen on the hardcoding of '-ljpeg'
> >
> > + LIBJPEG_LIBS := -ljpeg
>
> There's no pkg-config files for it. Any suggestions on how to get
> something generic?
>
I know there isn't at present. I still think it's bet
* Andrew Hughes [2014-05-21 12:22]:
> I'm not keen on the hardcoding of '-ljpeg'
>
> + LIBJPEG_LIBS := -ljpeg
There's no pkg-config files for it. Any suggestions on how to get
something generic?
> Could this not at least be conditionally assigned? (?=)
It can still be overridden on the make c
On 05/21/2014 08:06 AM, Omair Majid wrote:
I will need to push that closed generated-configure.sh afterwards however
so that closed builds don't break.
Anything I need to do to ensure the pushes are co-ordinated correctly?
Just make sure I notice the push and I'll fix ASAP ..
-phil.
- Original Message -
> Hi,
>
> Updated webrevs:
> http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01/
> http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01.jdk/
>
> * Anthony Petrov [2014-05-19 14:42]:
> > make/lib/Awt2dLibraries.gmk
> > >1236 LIBJPEG_CFLAGS :=
> >
Hi,
* Phil Race [2014-05-20 18:34]:
> I only tried the default (not specifying the system libjpeg) but my builds
> all succeeded and SwingSet & Java2D demo ran fine on Mac & Windows
> with the closed builds (after generating a closed generated-configure.sh)
> so this all looks good to push.
Than
I only tried the default (not specifying the system libjpeg) but my builds
all succeeded and SwingSet & Java2D demo ran fine on Mac & Windows
with the closed builds (after generating a closed generated-configure.sh)
so this all looks good to push.
I will need to push that closed generated-configu
I'm going to apply the patch and run it through open + closed builds
cross-platforms ..
-phil..
On 5/20/2014 10:15 AM, Anthony Petrov wrote:
Thanks for the update, Omair. The fix looks good to me now.
--
best regards,
Anthony
On 5/20/2014 9:11 PM, Omair Majid wrote:
Hi,
Updated webrevs:
ht
Thanks for the update, Omair. The fix looks good to me now.
--
best regards,
Anthony
On 5/20/2014 9:11 PM, Omair Majid wrote:
Hi,
Updated webrevs:
http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01/
http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01.jdk/
* Anthony Petrov
Hi,
Updated webrevs:
http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01/
http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01.jdk/
* Anthony Petrov [2014-05-19 14:42]:
> make/lib/Awt2dLibraries.gmk
> >1236 LIBJPEG_CFLAGS := $(JDK_TOPDIR)/src/share/native/sun/awt/image/jpeg
Hi Omair,
common/autoconf/libraries.m4
624 [use libjpeg from build system or OpenJDK source (system, bundled)
@<:bundled@:>@])])
"@<:bundled@:>@" should read "@<:@bundled@:>@" - note the missing @.
make/lib/Awt2dLibraries.gmk
1236 LIBJPEG_CFLAGS := $(JDK_TOPDIR)/src/share/native
[not a review]
On May 16 2014, at 17:45 , Omair Majid wrote:
> Hi,
>
> Webrevs are at:
> http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/00
> http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/00.jdk
>
> This patch modifies OpenJDK to allow building and running using the
> sys
Hi,
Webrevs are at:
http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/00
http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/00.jdk
This patch modifies OpenJDK to allow building and running using the
system copy of libjpeg. This follows my previous changes for lcms
and a lot of the
19 matches
Mail list logo
