Re: RfR JDK-8055160

2015-06-12 Thread Mandy Chung
> On Jun 12, 2015, at 1:07 PM, Pete Brunet wrote: > > Thanks Mandy, The new patch is at > http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.04 > Looks good. Thanks. > On 6/10/15 6:29 PM, Mandy Chung wrote: >>> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: >>> >>> Due to some other

Re: RfR JDK-8055160

2015-06-12 Thread Pete Brunet
Thanks Mandy, The new patch is at http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.04 On 6/10/15 6:29 PM, Mandy Chung wrote: >> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: >> >> Due to some other priorities it's been over 2 months since the last webrev. >> An update is here: >> http:

Re: RfR JDK-8055160

2015-06-12 Thread Sergey Bylokhov
Looks fine. On 12.06.2015 17:36, Pete Brunet wrote: Thanks Mandy. I need one more review from the awt-dev team. Pete On 6/10/15 6:29 PM, Mandy Chung wrote: On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: Due to some other priorities it's been over 2 months since the last webrev. An updat

Re: RfR JDK-8055160

2015-06-12 Thread Pete Brunet
Thanks Mandy. I need one more review from the awt-dev team. Pete On 6/10/15 6:29 PM, Mandy Chung wrote: >> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: >> >> Due to some other priorities it's been over 2 months since the last webrev. >> An update is here: >> http://cr.openjdk.java.net/~ptb

Re: RfR JDK-8055160

2015-06-12 Thread Magnus Ihse Bursie
On 2015-06-11 00:33, Pete Brunet wrote: Due to some other priorities it's been over 2 months since the last webrev. An update is here: http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.03 Build changes look good. /Magnus The changes from webrev.02 are: 1) The test was changed to not

Re: RfR JDK-8055160

2015-06-10 Thread Mandy Chung
> On Jun 10, 2015, at 4:54 PM, Pete Brunet wrote: > > Hi Mandy, That's fixed in the JDK-8078335 patch I submitted earlier in > the day to build-dev as a RfR. I tested that on Win and Mac. > > http://cr.openjdk.java.net/~ptbrunet/JDK-8078335/webrev.00/ Looks good to me. Mandy > > Pete > >

Re: RfR JDK-8055160

2015-06-10 Thread Pete Brunet
Hi Mandy, That's fixed in the JDK-8078335 patch I submitted earlier in the day to build-dev as a RfR. I tested that on Win and Mac. http://cr.openjdk.java.net/~ptbrunet/JDK-8078335/webrev.00/ Pete On 6/10/15 6:08 PM, Mandy Chung wrote: > Just a quick check, jdk.accessibility is only linked in w

Re: RfR JDK-8055160

2015-06-10 Thread Mandy Chung
> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: > > Due to some other priorities it's been over 2 months since the last webrev. > An update is here: > http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.03 BarProvider.java You can use try-with-resource try (PrintWriter writer = n

Re: RfR JDK-8055160

2015-06-10 Thread Mandy Chung
Just a quick check, jdk.accessibility is only linked in windows image at the moment. It is a bug. Are you going to fix that in this changeset? I think you have to verify this change in windows as well as other platforms. Mandy > On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: > > Due to s

Re: RfR JDK-8055160

2015-06-10 Thread Pete Brunet
Note that I need to remove the import of java.io.PrintWriter in java.awt.Toolkit.java On 6/10/15 5:33 PM, Pete Brunet wrote: > Due to some other priorities it's been over 2 months since the last > webrev. An update is here: > http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.03 > > The chan

Re: RfR JDK-8055160

2015-06-10 Thread Pete Brunet
Due to some other priorities it's been over 2 months since the last webrev. An update is here: http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.03 The changes from webrev.02 are: 1) The test was changed to not use the service provider to test the activation of the service provider. Inste