Re: .hgignore missing webrevs?

2014-09-11 Thread John Rose
On Sep 11, 2014, at 11:40 AM, Bradford Wetmore wrote: > Thanks, John, I agree. The pattern I will check in will be: > >^webrev > > Thanks, > > Brad > > P.S. Following the OpenJDK codereview directory layout suggestion [1], I > thought about also putting in: > >^[0-9][0-9][0-9][0-

Re: .hgignore missing webrevs?

2014-09-11 Thread Bradford Wetmore
Thanks, John, I agree. The pattern I will check in will be: ^webrev Thanks, Brad P.S. Following the OpenJDK codereview directory layout suggestion [1], I thought about also putting in: ^[0-9][0-9][0-9][0-9][0-9][0-9][0-9] 800/ webrev.00 webrev.01 but many

Re: .hgignore missing webrevs?

2014-09-10 Thread John Rose
On Sep 10, 2014, at 4:22 PM, Bradford Wetmore wrote: > My original thought was the former. But I note both are currently being > used, so some people may prefer the latter. I would prefer the more general pattern, to give the user more latitude, and also to make a simpler rule. — John

Re: .hgignore missing webrevs?

2014-09-10 Thread Bradford Wetmore
One question, would folks rather have: ^webrev/ ^webrev.zip or webrev which will pick up webrev variants. webrev.zip webrev- webrev.01 etc. My original thought was the former. But I note both are currently being used, so some people may prefer the latter.

Re: .hgignore missing webrevs?

2014-09-10 Thread Jonathan Gibbons
The langtools/ change is OK by me. -- Jon On 09/10/2014 04:11 PM, Bradford Wetmore wrote: I created: https://bugs.openjdk.java.net/browse/JDK-8058180 The code review is: http://cr.openjdk.java.net/~wetmore/8058180/open/ Brad On 9/10/2014 12:00 PM, Bradford Wetmore wrote: I've

Re: .hgignore missing webrevs?

2014-09-10 Thread David Katleman
Change looks correct. Find its interesting that there were partial attempts in some of the repos Approved. Thanks Dave On 9/10/2014 4:11 PM, Bradford Wetmore wrote: I created: https://bugs.openjdk.java.net/browse/JDK-8058180 The code review is: http://cr.openjdk.java.

Re: .hgignore missing webrevs?

2014-09-10 Thread Bradford Wetmore
I created: https://bugs.openjdk.java.net/browse/JDK-8058180 The code review is: http://cr.openjdk.java.net/~wetmore/8058180/open/ Brad On 9/10/2014 12:00 PM, Bradford Wetmore wrote: I've noticed in various repos that the .hgignore files include variations on webrev, ^webrev/, or l

.hgignore missing webrevs?

2014-09-10 Thread Bradford Wetmore
I've noticed in various repos that the .hgignore files include variations on webrev, ^webrev/, or leave it out completely. In other words, it's inconsistent. Mark offered: http://mail.openjdk.java.net/pipermail/build-dev/2008-February/000742.html which add your own personal .hgignore file