Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

2017-12-19 Thread mark . reinhold
2017/12/18 20:40:19 -0800, Martin Buchholz : > On Mon, Dec 18, 2017 at 3:50 PM, mark.reinh...@oracle.com wrote: >> I didn't know you'd requested this -- is there an existing issue? > > https://bugs.openjdk.java.net/browse/JDK-8189761 Thanks. I cross-linked that with

Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

2017-12-18 Thread Erik Joelsson
Looks good. /Erik On 2017-12-18 23:41, mark.reinh...@oracle.com wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 Webrev: http://cr.openjdk.java.net/~mr/rev/8193764/ You can set COMPANY_NAME in make/autoconf/version-numbers, but you can't set it when configuring a build, so it's

Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

2017-12-18 Thread Martin Buchholz
On Mon, Dec 18, 2017 at 3:50 PM, wrote: > 2017/12/18 15:36:03 -0800, Martin Buchholz : > > Mark, thanks for implementing my little feature request. Looks good to > me. > > I didn't know you'd requested this -- is there an existing issue? >

Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

2017-12-18 Thread mark . reinhold
2017/12/18 15:36:03 -0800, Martin Buchholz : > Mark, thanks for implementing my little feature request. Looks good to me. I didn't know you'd requested this -- is there an existing issue? - Mark

Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

2017-12-18 Thread Tim Bell
Mark: Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 Webrev: http://cr.openjdk.java.net/~mr/rev/8193764/ Looks good. Tim

Re: 10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

2017-12-18 Thread Martin Buchholz
Mark, thanks for implementing my little feature request. Looks good to me. Aside: we only support running configure under bash, but as a result the configure script is now a strange mixture of bashisms and 1980-isms. On Mon, Dec 18, 2017 at 2:41 PM, wrote: > Bug:

10 RFR (XS) 8193764: Cannot set COMPANY_NAME when configuring a build

2017-12-18 Thread mark . reinhold
Bug: https://bugs.openjdk.java.net/browse/JDK-8193764 Webrev: http://cr.openjdk.java.net/~mr/rev/8193764/ You can set COMPANY_NAME in make/autoconf/version-numbers, but you can't set it when configuring a build, so it's impossible to change the value of IMPLEMENTOR in the $JAVA_HOME/release file