Re: Request for approval of JDK-8032443: , Java Access Bridge version strings need to be fixed

2014-02-27 Thread Erik Joelsson
Looks good to me /Erik On 2014-02-27 14:19, Pete Brunet wrote: In response to the review from Magnus I updated the webrev to add the definition of JDK_FTYPE. Please re-review and re-approve. http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.01/ Pete

Re: Request for approval of JDK-8032443: , Java Access Bridge version strings need to be fixed

2014-02-27 Thread Magnus Ihse Bursie
Looks good to me! /Magnus 27 feb 2014 kl. 14:19 skrev Pete Brunet : > In response to the review from Magnus I updated the webrev to add the > definition of JDK_FTYPE. Please re-review and re-approve. > http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.01/ > > Pete

Request for approval of JDK-8032443: ,Java Access Bridge version strings need to be fixed

2014-02-27 Thread Pete Brunet
In response to the review from Magnus I updated the webrev to add the definition of JDK_FTYPE. Please re-review and re-approve. http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.01/ Pete

Re: 8032443: ,Java Access Bridge version strings need to be fixed

2014-02-24 Thread Pete Brunet
Hi Magnus, Here's the update: http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.01 in particular line 134 at http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.01/windows/native/sun/bridge/AccessBridgeStatusWindow.RC.frames.html Pete On 2/24/14 1:55 PM, Pete Brunet wrote: > Hi Magnus,

Re: 8032443: ,Java Access Bridge version strings need to be fixed

2014-02-24 Thread Pete Brunet
Hi Magnus, Thanks very much for looking at this. On 2/19/14 3:55 AM, Magnus Ihse Bursie wrote: > On 2014-02-18 05:22, Pete Brunet wrote: >> Please review this change: >> http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.00/ >> >> for this bug: >> https://bugs.openjdk.java.net/browse/JDK-8032

Re: 8032443: ,Java Access Bridge version strings need to be fixed

2014-02-19 Thread Magnus Ihse Bursie
On 2014-02-18 05:22, Pete Brunet wrote: Please review this change: http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.00/ for this bug: https://bugs.openjdk.java.net/browse/JDK-8032443 Some resource compiler defines are need so the JAB DLLs Properties sheet will have the proper information

Re: 8032443: ,Java Access Bridge version strings need to be fixed

2014-02-17 Thread Erik Joelsson
Peter, Looks good to me. /Erik On 2014-02-18 05:22, Pete Brunet wrote: Please review this change: http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.00/ for this bug: https://bugs.openjdk.java.net/browse/JDK-8032443 Some resource compiler defines are need so the JAB DLLs Properties shee

8032443: ,Java Access Bridge version strings need to be fixed

2014-02-17 Thread Pete Brunet
Please review this change: http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.00/ for this bug: https://bugs.openjdk.java.net/browse/JDK-8032443 Some resource compiler defines are need so the JAB DLLs Properties sheet will have the proper information. This change fixes the names that are di