On 07/02/2014 01:06, Magnus Ihse Bursie wrote:
It looks basically good. Some comments:
In spec.gmk.in:
+RMICONNECTOR_IIOP=@RMICONNECTOR_IIOP@
Please use := as = has a special meaning in make (late evaluation). Simple
assignment is :=.
In jdk-options.m4:
Please add a set of AC_MSG_CHECKING/RESU
On 6 feb 2014, at 13:06, Alan Bateman wrote:
>
> This is the first time that I've added a configure option to the build so I
> may need help getting this right. The patch that I'm currently using is here:
>
> http://cr.openjdk.java.net/~alanb/8033366/webrev/
It looks basically good. Some com
On 06/02/2014 16:00, Mandy Chung wrote:
:
jdk/make/profile-rtjar-includes.txt references these classes. Would
the profile build ignore if these classes don't exist?
Yes, it's just used an exclude so it harmless when the classes aren't
present. Once we come to removing this feature then the exc
On 2/6/2014 4:06 AM, Alan Bateman wrote:
One of things that we are hoping to do in JDK 9 is to drop support for
the IIOP transport from RMI connector in the JMX Remote API [1]. The
motive is modules and the first step on this journey was to downgrade
the support to optional from required (som
On 2014-02-06 14:23, Alan Bateman wrote:
On 06/02/2014 12:23, Erik Joelsson wrote:
Looks good to me. Only a minor comment on indentation in
jdk/makeGenerateClasses.gmk. We try to keep block indentation at 2
spaces and continuation indentation at 4 spaces, so line 96 should
only be 2 spaces.
Th
On 06/02/2014 12:23, Erik Joelsson wrote:
Looks good to me. Only a minor comment on indentation in
jdk/makeGenerateClasses.gmk. We try to keep block indentation at 2
spaces and continuation indentation at 4 spaces, so line 96 should
only be 2 spaces.
Thanks Erik. I'll fix the indentation in Gen
Looks good to me. Only a minor comment on indentation in
jdk/makeGenerateClasses.gmk. We try to keep block indentation at 2
spaces and continuation indentation at 4 spaces, so line 96 should only
be 2 spaces.
/Erik
On 2014-02-06 13:06, Alan Bateman wrote:
One of things that we are hoping to
One of things that we are hoping to do in JDK 9 is to drop support for
the IIOP transport from RMI connector in the JMX Remote API [1]. The
motive is modules and the first step on this journey was to downgrade
the support to optional from required (something that we did in JDK 8 as
part of th
