Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-03-12 Thread Erik Joelsson
, 2020 5:51 AM To: Junyuan Zheng; Magnus Ihse Bursie; build-dev@openjdk.java.net Subject: Re: [EXTERNAL] Re: macOS build success but codesign fail on macOS 10.13.5 or older I couldn't find your name in the census [1] so I assume you need a sponsor for pushing this? /Erik [1] https://

Re: Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-03-12 Thread Junyuan Zheng
: macOS build success but codesign fail on macOS 10.13.5 or older I couldn't find your name in the census [1] so I assume you need a sponsor for pushing this? /Erik [1] https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fopenjdk.java.net%2Fcensus&data=02%7C01%7CJuny

Re: [EXTERNAL] Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-03-11 Thread Erik Joelsson
like me to help with backporting this change or anything. Thanks, Junyuan From: Erik Joelsson Sent: Friday, February 28, 2020 6:26 AM To: Magnus Ihse Bursie ; Junyuan Zheng ; build-dev@openjdk.java.net Subject: [EXTERNAL] Re: macOS build success but codesign fail on macOS 10.13.5 or older

Re: [EXTERNAL] Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-03-10 Thread Junyuan Zheng
build-dev@openjdk.java.net Subject: [EXTERNAL] Re: macOS build success but codesign fail on macOS 10.13.5 or older   On 2020-02-28 01:04, Magnus Ihse Bursie wrote: > On 2020-02-28 09:59, Magnus Ihse Bursie wrote: >> On 2020-02-27 16:07, Erik Joelsson wrote: >>> On 2020-02-

Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-02-28 Thread Erik Joelsson
On 2020-02-28 01:04, Magnus Ihse Bursie wrote: On 2020-02-28 09:59, Magnus Ihse Bursie wrote: On 2020-02-27 16:07, Erik Joelsson wrote: On 2020-02-27 06:16, Magnus Ihse Bursie wrote: I don't think it should be a fatal error. If you have a codesign binary on your path that does not support --op

Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-02-28 Thread Magnus Ihse Bursie
On 2020-02-28 09:59, Magnus Ihse Bursie wrote: On 2020-02-27 16:07, Erik Joelsson wrote: On 2020-02-27 06:16, Magnus Ihse Bursie wrote: I don't think it should be a fatal error. If you have a codesign binary on your path that does not support --option runtime, you should still be able to build

Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-02-28 Thread Magnus Ihse Bursie
On 2020-02-27 16:07, Erik Joelsson wrote: On 2020-02-27 06:16, Magnus Ihse Bursie wrote: I don't think it should be a fatal error. If you have a codesign binary on your path that does not support --option runtime, you should still be able to build, but not sign. Change it to a warning, and let

Re: Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-02-27 Thread Junyuan Zheng
To: Magnus Ihse Bursie ; Junyuan Zheng ; build-dev@openjdk.java.net Subject: [EXTERNAL] Re: macOS build success but codesign fail on macOS 10.13.5 or older   On 2020-02-27 06:16, Magnus Ihse Bursie wrote: > I don't think it should be a fatal error. If you have a codesign > bin

Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-02-27 Thread Erik Joelsson
On 2020-02-27 06:16, Magnus Ihse Bursie wrote: I don't think it should be a fatal error. If you have a codesign binary on your path that does not support --option runtime, you should still be able to build, but not sign. Change it to a warning, and let the user continue without CODESIGN. My i

Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-02-27 Thread Magnus Ihse Bursie
On 2020-02-26 18:30, Junyuan Zheng wrote: Hi all, A recent change in OpenJDK tip (https://hg.openjdk.java.net/jdk/jdk/rev/dcf88e5c8c07) contains a potential bug when try to sign the macOS binary on older macOS. The current macOS signing process will execute the following command in order: 1.

Re: macOS build success but codesign fail on macOS 10.13.5 or older

2020-02-26 Thread Erik Joelsson
This looks good to me. Style wise I would ask you to break the long line as it makes future side-by-side comparisons and merges annoying. /Erik On 2020-02-26 09:30, Junyuan Zheng wrote: Hi all, A recent change in OpenJDK tip (https://hg.openjdk.java.net/jdk/jdk/rev/dcf88e5c8c07) contains a p

macOS build success but codesign fail on macOS 10.13.5 or older

2020-02-26 Thread Junyuan Zheng
Hi all, A recent change in OpenJDK tip (https://hg.openjdk.java.net/jdk/jdk/rev/dcf88e5c8c07) contains a potential bug when try to sign the macOS binary on older macOS. The current macOS signing process will execute the following command in order: 1. Checking whether codesign certificate is pre

Build success!

2015-06-17 Thread Martijn Verburg
Hi all, In an attempt to be the most annoying person on build-dev in June (do you hand out prizes, because I'm totally winning). I'm now at the "error: comparison of array 'rasterP->sppsm.offsets' not equal to a null pointer is always true" bug aka https://bugs.openjdk.java.net/browse/JDK-8080993