Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

Thanks for everyone bothered by the thread ! On Sat, Nov 5, 2011 at 12:21 AM, Kelly O'Hair wrote: > Builds on all platforms looked ok, it's in the pipeline, should be pushed > into > http://hg.openjdk.java.net/jdk8/build/jdk today, and then be integrated > into the master jdk8 area > in the nex

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

Builds on all platforms looked ok, it's in the pipeline, should be pushed into http://hg.openjdk.java.net/jdk8/build/jdk today, and then be integrated into the master jdk8 area in the next week. I'll be traveling next week so won;t be able to check on the integration until after that. Thanks fo

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

Checking out the change now. -kto On Nov 3, 2011, at 10:02 AM, Neil Richards wrote: > On Wed, 2011-11-02 at 12:29 -0700, Kelly O'Hair wrote: >> It will be important that you create the changeset using the latest jdk8 >> build >> forest, e.g. using a clones from http://hg.openjdk.java.net/jdk8/b

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

On Wed, 2011-11-02 at 12:29 -0700, Kelly O'Hair wrote: > It will be important that you create the changeset using the latest jdk8 build > forest, e.g. using a clones from http://hg.openjdk.java.net/jdk8/build > Once you are happy that the change is ok on your system, then bundle up the > changese

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

On 3/11/2011 6:14 AM, Daniel D. Daugherty wrote: On 11/2/11 1:29 PM, Kelly O'Hair wrote: This change is both a build change and a serviceability change, but I would argue that it is more of a build change since the functionality of the jvmti demos shouldn't have changed with this. Although I am

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

Didn't Dan Dougherty review this too? Is he a "reviewer" for this project? If it helps you can put me down as a reviewer (kamg). On Nov 2, 2011, at 2:54 PM, Neil Richards wrote: On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote: Hi Neil, My understanding is that you need to have at le

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

This change is both a build change and a serviceability change, but I would argue that it is more of a build change since the functionality of the jvmti demos shouldn't have changed with this. Although I am listed as a member of the serviceability "group", I'm not exactly sure who leads that gr

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote: > Hi Neil, > > My understanding is that you need to have at least two reviewers who > have 'reviewer' privilege, (and I don't have 'reviewer' privilege). > I had a quick leaf through the OpenJDK Bylaws. It looks like the number of necessary

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

Hi Neil, My understanding is that you need to have at least two reviewers who have 'reviewer' privilege, (and I don't have 'reviewer' privilege). Yes, I am tied up, if you can handle the push, that will be great. What java bug id you need? can you use CR 6988099? BTW, here is the link to al

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

On Thu, 2011-10-20 at 09:21 -0700, Kelly O'Hair wrote: > Looks good. > > > -kto > Hi Zhengyu, Given Kelly's blessing, are you now happy to push this change to jdk8? (If you're otherwise tied up, I can drive the mechanics of the push if you provide me with a suitable java bug id to use.) Regar

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

Looks good. -kto On Oct 19, 2011, at 11:30 PM, Sean Chou wrote: > Hi all, > >Would anyone like to review this patch ? The problem it trying to fix is > very simple, just > add the version information to the dll files in demo. > >The bug link is: http://bugs.sun.com/bugdatabase/view_bu

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

Hi all, Would anyone like to review this patch ? The problem it trying to fix is very simple, just add the version information to the dll files in demo. The bug link is: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6988099 The webrev is: http://cr.openjdk.java.net/~ngmr/6988099/web

Code Review Request: CR 6988099 Add version information to jvmti demos.

Hi All, Could you please help with code review? After that, I can help to push to jdk8. Thanks, -Zhengyu On 9/19/2011 2:43 AM, Sean Chou wrote: Thanks to Gu and Neil. 2011/9/16 Zhengyu Gu > Okay, once review is completed, I would help you to push to jdk8